You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by "AngersZhuuuu (via GitHub)" <gi...@apache.org> on 2023/11/30 05:51:46 UTC
[PR] [KYUUBI-5780][FOLLOWUP] Format PermanentViewMarker tree string [kyuubi]
AngersZhuuuu opened a new pull request, #5792:
URL: https://github.com/apache/kyuubi/pull/5792
# :mag: Description
## Issue References 🔗
<!-- Append the issue number after #. If there is no issue for you to link create one or -->
<!-- If there are no issues to link, please provide details here. -->
This pull request fixes #5780
## Describe Your Solution 🔧
Format PermanentViewMarker tree string
## Types of changes :bookmark:
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Bugfix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
## Test Plan 🧪
#### Behavior Without This Pull Request :coffin:
```
Project [new_id2#100]
+- Project [new_id#102 AS new_id2#100]
+- RamPermanentViewMarker View (`test_default`.`my_view`, [new_id#102]), `test_default`.`my_view`, org.apache.hadoop.hive.serde2.lazy.LazySimpleSerDe
```
#### Behavior With This Pull Request :tada:
```
Project [new_id2#100]
+- Project [new_id#102 AS new_id2#100]
+- RamPermanentViewMarker
+- View (`test_default`.`my_view`, [new_id#102])
+- Project [cast(new_id#101 as int) AS new_id#102]
+- Project [id#103 AS new_id#101]
+- SubqueryAlias spark_catalog.test_default.v1
+- HiveTableRelation [`test_default`.`v1`, org.apache.hadoop.hive.serde2.lazy.LazySimpleSerDe, Data Cols: [id#103, name#104, grade#105, sex#106], Partition Cols: []]
```
#### Related Unit Tests
---
# Checklists
## 📝 Author Self Checklist
<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->
<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->
- [ ] My code follows the [style guidelines](https://kyuubi.readthedocs.io/en/master/contributing/code/style.html) of this project
- [ ] I have performed a self-review
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html)
## 📝 Committer Pre-Merge Checklist
- [ ] Pull request title is okay.
- [ ] No license issues.
- [ ] Milestone correctly set?
- [ ] Test coverage is ok
- [ ] Assignees are selected.
- [ ] Minimum number of approvals
- [ ] No changes are requested
**Be nice. Be informative.**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] [KYUUBI #5780][FOLLOWUP] Format PermanentViewMarker tree string [kyuubi]
Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn commented on code in PR #5792:
URL: https://github.com/apache/kyuubi/pull/5792#discussion_r1410451095
##########
extensions/spark/kyuubi-spark-authz/src/main/scala/org/apache/kyuubi/plugin/spark/authz/rule/permanentview/PermanentViewMarker.scala:
##########
@@ -19,9 +19,14 @@ package org.apache.kyuubi.plugin.spark.authz.rule.permanentview
import org.apache.spark.sql.catalyst.catalog.CatalogTable
import org.apache.spark.sql.catalyst.expressions.Attribute
+import org.apache.spark.sql.catalyst.plans.QueryPlan
import org.apache.spark.sql.catalyst.plans.logical.{LeafNode, LogicalPlan}
case class PermanentViewMarker(child: LogicalPlan, catalogTable: CatalogTable) extends LeafNode {
override def output: Seq[Attribute] = child.output
+
+ override def argString(maxFields: Int): String = ""
Review Comment:
can we update the PR desc after this？
##########
extensions/spark/kyuubi-spark-authz/src/main/scala/org/apache/kyuubi/plugin/spark/authz/rule/permanentview/PermanentViewMarker.scala:
##########
@@ -19,9 +19,14 @@ package org.apache.kyuubi.plugin.spark.authz.rule.permanentview
import org.apache.spark.sql.catalyst.catalog.CatalogTable
import org.apache.spark.sql.catalyst.expressions.Attribute
+import org.apache.spark.sql.catalyst.plans.QueryPlan
import org.apache.spark.sql.catalyst.plans.logical.{LeafNode, LogicalPlan}
case class PermanentViewMarker(child: LogicalPlan, catalogTable: CatalogTable) extends LeafNode {
override def output: Seq[Attribute] = child.output
+
+ override def argString(maxFields: Int): String = ""
Review Comment:
can we update the PR desc after this？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] [KYUUBI #5780][AUTHZ][FOLLOWUP] Format PermanentViewMarker tree string [kyuubi]
Posted by "AngersZhuuuu (via GitHub)" <gi...@apache.org>.
AngersZhuuuu commented on code in PR #5792:
URL: https://github.com/apache/kyuubi/pull/5792#discussion_r1411525905
##########
extensions/spark/kyuubi-spark-authz/src/main/scala/org/apache/kyuubi/plugin/spark/authz/rule/permanentview/PermanentViewMarker.scala:
##########
@@ -19,9 +19,14 @@ package org.apache.kyuubi.plugin.spark.authz.rule.permanentview
import org.apache.spark.sql.catalyst.catalog.CatalogTable
import org.apache.spark.sql.catalyst.expressions.Attribute
+import org.apache.spark.sql.catalyst.plans.QueryPlan
import org.apache.spark.sql.catalyst.plans.logical.{LeafNode, LogicalPlan}
case class PermanentViewMarker(child: LogicalPlan, catalogTable: CatalogTable) extends LeafNode {
override def output: Seq[Attribute] = child.output
+
+ override def argString(maxFields: Int): String = ""
Review Comment:
> can we update the PR desc after this？
Done
##########
extensions/spark/kyuubi-spark-authz/src/main/scala/org/apache/kyuubi/plugin/spark/authz/rule/permanentview/PermanentViewMarker.scala:
##########
@@ -19,9 +19,14 @@ package org.apache.kyuubi.plugin.spark.authz.rule.permanentview
import org.apache.spark.sql.catalyst.catalog.CatalogTable
import org.apache.spark.sql.catalyst.expressions.Attribute
+import org.apache.spark.sql.catalyst.plans.QueryPlan
import org.apache.spark.sql.catalyst.plans.logical.{LeafNode, LogicalPlan}
case class PermanentViewMarker(child: LogicalPlan, catalogTable: CatalogTable) extends LeafNode {
override def output: Seq[Attribute] = child.output
+
+ override def argString(maxFields: Int): String = ""
Review Comment:
> can we update the PR desc after this？
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] [KYUUBI #5780][FOLLOWUP] Format PermanentViewMarker tree string [kyuubi]
Posted by "AngersZhuuuu (via GitHub)" <gi...@apache.org>.
AngersZhuuuu commented on PR #5792:
URL: https://github.com/apache/kyuubi/pull/5792#issuecomment-1833197098
ping @yaooqinn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] [KYUUBI #5780][FOLLOWUP] Format PermanentViewMarker tree string [kyuubi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #5792:
URL: https://github.com/apache/kyuubi/pull/5792#issuecomment-1833347075
## [Codecov](https://app.codecov.io/gh/apache/kyuubi/pull/5792?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: `4 lines` in your changes are missing coverage. Please review.
> Comparison is base [(`19ae399`)](https://app.codecov.io/gh/apache/kyuubi/commit/19ae399445ca42cd3bcdbff41620203199acc64b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 61.36% compared to head [(`a3f025b`)](https://app.codecov.io/gh/apache/kyuubi/pull/5792?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 61.35%.
> Report is 1 commits behind head on master.
> :exclamation: Current head a3f025b differs from pull request most recent head 3073f6e. Consider uploading reports for the commit 3073f6e to get more accurate results
| [Files](https://app.codecov.io/gh/apache/kyuubi/pull/5792?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...authz/rule/permanentview/PermanentViewMarker.scala](https://app.codecov.io/gh/apache/kyuubi/pull/5792?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXh0ZW5zaW9ucy9zcGFyay9reXV1Ymktc3BhcmstYXV0aHovc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9reXV1YmkvcGx1Z2luL3NwYXJrL2F1dGh6L3J1bGUvcGVybWFuZW50dmlldy9QZXJtYW5lbnRWaWV3TWFya2VyLnNjYWxh) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/kyuubi/pull/5792?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #5792 +/- ##
============================================
- Coverage 61.36% 61.35% -0.02%
Complexity 23 23
============================================
Files 607 607
Lines 35935 35939 +4
Branches 4936 4937 +1
============================================
- Hits 22052 22050 -2
- Misses 11496 11502 +6
Partials 2387 2387
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/kyuubi/pull/5792?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] [KYUUBI #5780][AUTHZ][FOLLOWUP] Format PermanentViewMarker tree string [kyuubi]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #5792:
URL: https://github.com/apache/kyuubi/pull/5792#issuecomment-1835470143
Thanks, merged to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] [KYUUBI #5780][FOLLOWUP] Format PermanentViewMarker tree string [kyuubi]
Posted by "AngersZhuuuu (via GitHub)" <gi...@apache.org>.
AngersZhuuuu commented on code in PR #5792:
URL: https://github.com/apache/kyuubi/pull/5792#discussion_r1410204776
##########
extensions/spark/kyuubi-spark-authz/src/main/scala/org/apache/kyuubi/plugin/spark/authz/rule/permanentview/PermanentViewMarker.scala:
##########
@@ -24,4 +24,44 @@ import org.apache.spark.sql.catalyst.plans.logical.{LeafNode, LogicalPlan}
case class PermanentViewMarker(child: LogicalPlan, catalogTable: CatalogTable) extends LeafNode {
override def output: Seq[Attribute] = child.output
+
+ override def argString(maxFields: Int): String = {
+ catalogTable.storage.serde match {
+ case Some(serde) => (catalogTable.identifier :: serde :: Nil).mkString(", ")
+ case _ => (catalogTable.identifier :: Nil).mkString(", ")
+ }
+ }
+
+ override def generateTreeString(
+ depth: Int,
+ lastChildren: Seq[Boolean],
+ append: String => Unit,
+ verbose: Boolean,
+ prefix: String,
+ addSuffix: Boolean,
+ maxFields: Int,
+ printNodeId: Boolean,
+ indent: Int): Unit = {
+ super.generateTreeString(
+ depth,
+ lastChildren,
+ append,
+ verbose,
+ prefix,
+ addSuffix,
+ maxFields,
+ printNodeId,
+ indent)
+
+ child.generateTreeString(
Review Comment:
child not in `children`, so we need to implement here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] [KYUUBI #5780][FOLLOWUP] Format PermanentViewMarker tree string [kyuubi]
Posted by "AngersZhuuuu (via GitHub)" <gi...@apache.org>.
AngersZhuuuu commented on code in PR #5792:
URL: https://github.com/apache/kyuubi/pull/5792#discussion_r1410314987
##########
extensions/spark/kyuubi-spark-authz/src/main/scala/org/apache/kyuubi/plugin/spark/authz/rule/permanentview/PermanentViewMarker.scala:
##########
@@ -24,4 +24,44 @@ import org.apache.spark.sql.catalyst.plans.logical.{LeafNode, LogicalPlan}
case class PermanentViewMarker(child: LogicalPlan, catalogTable: CatalogTable) extends LeafNode {
override def output: Seq[Attribute] = child.output
+
+ override def argString(maxFields: Int): String = {
+ catalogTable.storage.serde match {
+ case Some(serde) => (catalogTable.identifier :: serde :: Nil).mkString(", ")
+ case _ => (catalogTable.identifier :: Nil).mkString(", ")
+ }
+ }
Review Comment:
Yea, still necessary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] [KYUUBI #5780][FOLLOWUP] Format PermanentViewMarker tree string [kyuubi]
Posted by "AngersZhuuuu (via GitHub)" <gi...@apache.org>.
AngersZhuuuu commented on code in PR #5792:
URL: https://github.com/apache/kyuubi/pull/5792#discussion_r1410205043
##########
extensions/spark/kyuubi-spark-authz/src/main/scala/org/apache/kyuubi/plugin/spark/authz/rule/permanentview/PermanentViewMarker.scala:
##########
@@ -24,4 +24,44 @@ import org.apache.spark.sql.catalyst.plans.logical.{LeafNode, LogicalPlan}
case class PermanentViewMarker(child: LogicalPlan, catalogTable: CatalogTable) extends LeafNode {
override def output: Seq[Attribute] = child.output
+
+ override def argString(maxFields: Int): String = {
+ catalogTable.storage.serde match {
+ case Some(serde) => (catalogTable.identifier :: serde :: Nil).mkString(", ")
+ case _ => (catalogTable.identifier :: Nil).mkString(", ")
+ }
+ }
+
+ override def generateTreeString(
+ depth: Int,
+ lastChildren: Seq[Boolean],
+ append: String => Unit,
+ verbose: Boolean,
+ prefix: String,
+ addSuffix: Boolean,
+ maxFields: Int,
+ printNodeId: Boolean,
+ indent: Int): Unit = {
+ super.generateTreeString(
+ depth,
+ lastChildren,
+ append,
+ verbose,
+ prefix,
+ addSuffix,
+ maxFields,
+ printNodeId,
+ indent)
+
+ child.generateTreeString(
+ depth + 1,
+ lastChildren :+ true,
Review Comment:
And here should be true since same as last children
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] [KYUUBI-5780][FOLLOWUP] Format PermanentViewMarker tree string [kyuubi]
Posted by "AngersZhuuuu (via GitHub)" <gi...@apache.org>.
AngersZhuuuu commented on code in PR #5792:
URL: https://github.com/apache/kyuubi/pull/5792#discussion_r1410204514
##########
extensions/spark/kyuubi-spark-authz/src/main/scala/org/apache/kyuubi/plugin/spark/authz/rule/permanentview/PermanentViewMarker.scala:
##########
@@ -24,4 +24,44 @@ import org.apache.spark.sql.catalyst.plans.logical.{LeafNode, LogicalPlan}
case class PermanentViewMarker(child: LogicalPlan, catalogTable: CatalogTable) extends LeafNode {
override def output: Seq[Attribute] = child.output
+
+ override def argString(maxFields: Int): String = {
+ catalogTable.storage.serde match {
+ case Some(serde) => (catalogTable.identifier :: serde :: Nil).mkString(", ")
+ case _ => (catalogTable.identifier :: Nil).mkString(", ")
+ }
+ }
Review Comment:
Overwrite this to avoid print `child` here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] [KYUUBI #5780][FOLLOWUP] Format PermanentViewMarker tree string [kyuubi]
Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn commented on code in PR #5792:
URL: https://github.com/apache/kyuubi/pull/5792#discussion_r1410340467
##########
extensions/spark/kyuubi-spark-authz/src/main/scala/org/apache/kyuubi/plugin/spark/authz/rule/permanentview/PermanentViewMarker.scala:
##########
@@ -24,4 +24,44 @@ import org.apache.spark.sql.catalyst.plans.logical.{LeafNode, LogicalPlan}
case class PermanentViewMarker(child: LogicalPlan, catalogTable: CatalogTable) extends LeafNode {
override def output: Seq[Attribute] = child.output
+
+ override def argString(maxFields: Int): String = {
+ catalogTable.storage.serde match {
+ case Some(serde) => (catalogTable.identifier :: serde :: Nil).mkString(", ")
+ case _ => (catalogTable.identifier :: Nil).mkString(", ")
+ }
+ }
Review Comment:
Can we remove it? catalogTable is duplicated in the tree
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] [KYUUBI #5780][FOLLOWUP] Format PermanentViewMarker tree string [kyuubi]
Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn commented on code in PR #5792:
URL: https://github.com/apache/kyuubi/pull/5792#discussion_r1410230341
##########
extensions/spark/kyuubi-spark-authz/src/main/scala/org/apache/kyuubi/plugin/spark/authz/rule/permanentview/PermanentViewMarker.scala:
##########
@@ -24,4 +24,44 @@ import org.apache.spark.sql.catalyst.plans.logical.{LeafNode, LogicalPlan}
case class PermanentViewMarker(child: LogicalPlan, catalogTable: CatalogTable) extends LeafNode {
override def output: Seq[Attribute] = child.output
+
+ override def argString(maxFields: Int): String = {
+ catalogTable.storage.serde match {
+ case Some(serde) => (catalogTable.identifier :: serde :: Nil).mkString(", ")
+ case _ => (catalogTable.identifier :: Nil).mkString(", ")
+ }
+ }
Review Comment:
Still necessary?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] [KYUUBI #5780][FOLLOWUP] Format PermanentViewMarker tree string [kyuubi]
Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn commented on PR #5792:
URL: https://github.com/apache/kyuubi/pull/5792#issuecomment-1833202079
Simply override innerChildern?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] [KYUUBI #5780][FOLLOWUP] Format PermanentViewMarker tree string [kyuubi]
Posted by "AngersZhuuuu (via GitHub)" <gi...@apache.org>.
AngersZhuuuu commented on PR #5792:
URL: https://github.com/apache/kyuubi/pull/5792#issuecomment-1833207571
> Simply override innerChildern?
Nice suggestion, changged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] [KYUUBI #5780][FOLLOWUP] Format PermanentViewMarker tree string [kyuubi]
Posted by "AngersZhuuuu (via GitHub)" <gi...@apache.org>.
AngersZhuuuu commented on PR #5792:
URL: https://github.com/apache/kyuubi/pull/5792#issuecomment-1833335981
Any more suggestion?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] [KYUUBI #5780][FOLLOWUP] Format PermanentViewMarker tree string [kyuubi]
Posted by "AngersZhuuuu (via GitHub)" <gi...@apache.org>.
AngersZhuuuu commented on code in PR #5792:
URL: https://github.com/apache/kyuubi/pull/5792#discussion_r1410350699
##########
extensions/spark/kyuubi-spark-authz/src/main/scala/org/apache/kyuubi/plugin/spark/authz/rule/permanentview/PermanentViewMarker.scala:
##########
@@ -24,4 +24,44 @@ import org.apache.spark.sql.catalyst.plans.logical.{LeafNode, LogicalPlan}
case class PermanentViewMarker(child: LogicalPlan, catalogTable: CatalogTable) extends LeafNode {
override def output: Seq[Attribute] = child.output
+
+ override def argString(maxFields: Int): String = {
+ catalogTable.storage.serde match {
+ case Some(serde) => (catalogTable.identifier :: serde :: Nil).mkString(", ")
+ case _ => (catalogTable.identifier :: Nil).mkString(", ")
+ }
+ }
Review Comment:
> Can we remove it? catalogTable is duplicated in the tree
Done, to remove `catalogTable` we should overwrite `argString` to empty
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] [KYUUBI #5780][AUTHZ][FOLLOWUP] Format PermanentViewMarker tree string [kyuubi]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 closed pull request #5792: [KYUUBI #5780][AUTHZ][FOLLOWUP] Format PermanentViewMarker tree string
URL: https://github.com/apache/kyuubi/pull/5792
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org