[GitHub] [hadoop-submarine] yuanzac commented on a change in pull request #60: SUBMARINE-256. Interpreter support cluster mode

[GitBox <gi...@apache.org>]

yuanzac commented on a change in pull request #60: SUBMARINE-256. Interpreter support cluster mode
URL: https://github.com/apache/hadoop-submarine/pull/60#discussion_r337384598
 
 

 ##########
 File path: submarine-commons/commons-cluster/src/main/java/org/apache/submarine/commons/cluster/ClusterServer.java
 ##########
 @@ -58,26 +58,26 @@
  * 1. Create a raft server
  * 2. Remotely create interpreter's thrift service
  */
-public class ClusterManagerServer extends ClusterManager {
-  private static Logger LOG = LoggerFactory.getLogger(ClusterManagerServer.class);
+public class ClusterServer extends ClusterManager {
+  private static Logger LOG = LoggerFactory.getLogger(ClusterServer.class);
 
-  private static ClusterManagerServer instance = null;
+  private static ClusterServer instance = null;
 
   // raft server
   protected RaftServer raftServer = null;
 
   protected MessagingService messagingService = null;
 
-  private ClusterManagerServer() {
+  private ClusterServer() {
     super();
   }
 
   // Do not use the getInstance function in the test case,
   // which will result in an inability to update the instance according to the configuration.
-  public static ClusterManagerServer getInstance() {
-    synchronized (ClusterManagerServer.class) {
+  public static ClusterServer getInstance() {
+    synchronized (ClusterServer.class) {
 
 Review comment:
   Can we change it like cluster client?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services