You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2021/11/19 23:31:09 UTC
[GitHub] [geode] Kris-10-0 opened a new pull request #7134: GEODE-9727: Updated COMMAND error message
Kris-10-0 opened a new pull request #7134:
URL: https://github.com/apache/geode/pull/7134
<!-- Thank you for submitting a contribution to Apache Geode. -->
<!-- In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
-->
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [x] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
- [x] Is your initial contribution a single, squashed commit?
- [x] Does `gradlew build` run cleanly?
- [x] Have you written or updated unit tests to verify your changes?
- [NA] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
<!-- Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] nonbinaryprogrammer commented on a change in pull request #7134: GEODE-9727: Updated COMMAND error message
Posted by GitBox <gi...@apache.org>.
nonbinaryprogrammer commented on a change in pull request #7134:
URL: https://github.com/apache/geode/pull/7134#discussion_r753604225
##########
File path: geode-for-redis/src/integrationTest/java/org/apache/geode/redis/internal/executor/server/CommandIntegrationTest.java
##########
@@ -81,6 +87,32 @@ public void commandReturnsResultsMatchingNativeRedis() {
softly.assertAll();
}
+ @Test
+ public void commandWithInvalidSubcommand_returnError() {
+ String invalidSubcommand = "fakeSubcommand";
+ RedisCodec<String, String> codec = StringCodec.UTF8;
+
+ CommandArgs<String, String> args =
+ new CommandArgs<>(codec).add(CommandType.COMMAND).add(invalidSubcommand);
+ assertThatThrownBy(
+ () -> radishClient.dispatch(CommandType.COMMAND, new NestedMultiOutput<>(codec), args))
+ .hasMessageContaining(
+ "ERR Unknown subcommand or wrong number of arguments for 'COMMAND'");
Review comment:
it would be good to use `ERROR_UNKNOWN_COMMAND_COMMAND_SUBCOMMAND` from `RedisConstants` so that if we change the error message it'll still work. I don't think we're really testing that the constant is right, just that the constant we expect gets returned.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] DonalEvans merged pull request #7134: GEODE-9727: Updated COMMAND error message
Posted by GitBox <gi...@apache.org>.
DonalEvans merged pull request #7134:
URL: https://github.com/apache/geode/pull/7134
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] dschneider-pivotal commented on a change in pull request #7134: GEODE-9727: Updated COMMAND error message
Posted by GitBox <gi...@apache.org>.
dschneider-pivotal commented on a change in pull request #7134:
URL: https://github.com/apache/geode/pull/7134#discussion_r754472392
##########
File path: geode-for-redis/src/main/java/org/apache/geode/redis/internal/executor/server/COMMANDCommandExecutor.java
##########
@@ -34,9 +39,24 @@
* CommandExecutor refers to the interface being implemented.
*/
public class COMMANDCommandExecutor implements CommandExecutor {
+ private static final List<String> supportedSubcommands =
Review comment:
It would be good to mark this static with the "@Immutable" tag
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] dschneider-pivotal commented on a change in pull request #7134: GEODE-9727: Updated COMMAND error message
Posted by GitBox <gi...@apache.org>.
dschneider-pivotal commented on a change in pull request #7134:
URL: https://github.com/apache/geode/pull/7134#discussion_r754472392
##########
File path: geode-for-redis/src/main/java/org/apache/geode/redis/internal/executor/server/COMMANDCommandExecutor.java
##########
@@ -34,9 +39,24 @@
* CommandExecutor refers to the interface being implemented.
*/
public class COMMANDCommandExecutor implements CommandExecutor {
+ private static final List<String> supportedSubcommands =
Review comment:
It would be good to mark this static with the \@Immutable tag
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] dschneider-pivotal commented on a change in pull request #7134: GEODE-9727: Updated COMMAND error message
Posted by GitBox <gi...@apache.org>.
dschneider-pivotal commented on a change in pull request #7134:
URL: https://github.com/apache/geode/pull/7134#discussion_r754472392
##########
File path: geode-for-redis/src/main/java/org/apache/geode/redis/internal/executor/server/COMMANDCommandExecutor.java
##########
@@ -34,9 +39,24 @@
* CommandExecutor refers to the interface being implemented.
*/
public class COMMANDCommandExecutor implements CommandExecutor {
+ private static final List<String> supportedSubcommands =
Review comment:
It would be good to mark this static with the @ Immutable tag
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] dschneider-pivotal commented on a change in pull request #7134: GEODE-9727: Updated COMMAND error message
Posted by GitBox <gi...@apache.org>.
dschneider-pivotal commented on a change in pull request #7134:
URL: https://github.com/apache/geode/pull/7134#discussion_r754472392
##########
File path: geode-for-redis/src/main/java/org/apache/geode/redis/internal/executor/server/COMMANDCommandExecutor.java
##########
@@ -34,9 +39,24 @@
* CommandExecutor refers to the interface being implemented.
*/
public class COMMANDCommandExecutor implements CommandExecutor {
+ private static final List<String> supportedSubcommands =
Review comment:
It would be good to mark this static with the @Immutable tag
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org