You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2021/09/24 08:00:38 UTC
[GitHub] [hudi] codope opened a new pull request #3712: [HUDI-2484] Fix hive sync mode setting
codope opened a new pull request #3712:
URL: https://github.com/apache/hudi/pull/3712
## What is the purpose of the pull request
Hive Sync configs in `HoodieDeltaStreamer` are set via `DataSourceUtils#buildHiveSyncConfig`, which did not set the sync mode even when it was passed. This caused the hive sync to take JDBC or HiveQL executor route instead of directly usins HMS APIs even when the `sync_mode` was set to `hms`. This PR fixes that issue.
## Brief change log
*(for example:)*
- *Modify AnnotationLocation checkstyle rule in checkstyle.xml*
## Verify this pull request
*(Please pick either of the following options)*
This pull request is a trivial rework / code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end.*
- *Added HoodieClientWriteTest to verify the change.*
- *Manually verified the change by running a job locally.*
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3712: [HUDI-2484] Fix hive sync mode setting
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3712:
URL: https://github.com/apache/hudi/pull/3712#issuecomment-926429803
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "49f57805c299650f835a8c47a904b51537010a03",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2369",
"triggerID" : "49f57805c299650f835a8c47a904b51537010a03",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 49f57805c299650f835a8c47a904b51537010a03 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2369)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3712: [HUDI-2484] Fix hive sync mode setting
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3712:
URL: https://github.com/apache/hudi/pull/3712#issuecomment-926429803
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "49f57805c299650f835a8c47a904b51537010a03",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2369",
"triggerID" : "49f57805c299650f835a8c47a904b51537010a03",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 49f57805c299650f835a8c47a904b51537010a03 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2369)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan merged pull request #3712: [HUDI-2484] Fix hive sync mode setting
Posted by GitBox <gi...@apache.org>.
nsivabalan merged pull request #3712:
URL: https://github.com/apache/hudi/pull/3712
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #3712: [HUDI-2484] Fix hive sync mode setting
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #3712:
URL: https://github.com/apache/hudi/pull/3712#issuecomment-926429803
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "49f57805c299650f835a8c47a904b51537010a03",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "49f57805c299650f835a8c47a904b51537010a03",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 49f57805c299650f835a8c47a904b51537010a03 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org