You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Jitendra Nath Pandey (JIRA)" <ji...@apache.org> on 2011/02/23 22:12:38 UTC

[jira] Created: (HDFS-1637) Federation: FSDataset in Datanode should be created after initial handshake with namenode

Federation: FSDataset in Datanode should be created after initial handshake with namenode
-----------------------------------------------------------------------------------------

                 Key: HDFS-1637
                 URL: https://issues.apache.org/jira/browse/HDFS-1637
             Project: Hadoop HDFS
          Issue Type: Bug
    Affects Versions: Federation Branch
            Reporter: Jitendra Nath Pandey
            Assignee: Jitendra Nath Pandey
             Fix For: Federation Branch


Currently storage is initialized only after handshake with a namenode.However FSDataset is created before handshake and hence before storage initialization. At this time, storage does not have storage directories resulting in FSDataset initialized with no volumes.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (HDFS-1637) Federation: FSDataset in Datanode should be created after initial handshake with namenode

Posted by "Jitendra Nath Pandey (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HDFS-1637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jitendra Nath Pandey updated HDFS-1637:
---------------------------------------

    Attachment: HDFS-1637.1.patch

Patch uploaded.

> Federation: FSDataset in Datanode should be created after initial handshake with namenode
> -----------------------------------------------------------------------------------------
>
>                 Key: HDFS-1637
>                 URL: https://issues.apache.org/jira/browse/HDFS-1637
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: Federation Branch
>            Reporter: Jitendra Nath Pandey
>            Assignee: Jitendra Nath Pandey
>             Fix For: Federation Branch
>
>         Attachments: HDFS-1637.1.patch
>
>
> Currently storage is initialized only after handshake with a namenode.However FSDataset is created before handshake and hence before storage initialization. At this time, storage does not have storage directories resulting in FSDataset initialized with no volumes.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (HDFS-1637) Federation: FSDataset in Datanode should be created after initial handshake with namenode

Posted by "Jitendra Nath Pandey (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HDFS-1637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jitendra Nath Pandey updated HDFS-1637:
---------------------------------------

    Issue Type: Sub-task  (was: Bug)
        Parent: HDFS-1052

> Federation: FSDataset in Datanode should be created after initial handshake with namenode
> -----------------------------------------------------------------------------------------
>
>                 Key: HDFS-1637
>                 URL: https://issues.apache.org/jira/browse/HDFS-1637
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>    Affects Versions: Federation Branch
>            Reporter: Jitendra Nath Pandey
>            Assignee: Jitendra Nath Pandey
>             Fix For: Federation Branch
>
>         Attachments: HDFS-1637.1.patch
>
>
> Currently storage is initialized only after handshake with a namenode.However FSDataset is created before handshake and hence before storage initialization. At this time, storage does not have storage directories resulting in FSDataset initialized with no volumes.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (HDFS-1637) Federation: FSDataset in Datanode should be created after initial handshake with namenode

Posted by "Jitendra Nath Pandey (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-1637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12998594#comment-12998594 ] 

Jitendra Nath Pandey commented on HDFS-1637:
--------------------------------------------

     [exec] -1 overall.
     [exec]
     [exec]     +1 @author.  The patch does not contain any @author tags.
     [exec]
     [exec]     +1 tests included.  The patch appears to include 3 new or modified tests.
     [exec]
     [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
     [exec]
     [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler warnings.
     [exec]
     [exec]     +1 findbugs.  The patch does not introduce any new Findbugs warnings.
     [exec]
     [exec]     +1 release audit.  The applied patch does not increase the total number of release audit warnings.
     [exec]
     [exec]     -1 system tests framework.  The patch failed system tests framework compile.


The system tests framework errors seem to be unrelated. For example:

     [exec]      [iajc] ..../branches/HDFS-1052/src/test/system/aop/org/apache/hadoop/hdfs/HDFSPolicyProviderAspect.aj:24 [error] The import org.apache.hadoop.test.system cannot be resolved
     [exec]      [iajc] import org.apache.hadoop.test.system.DaemonProtocol;
     [exec]      [iajc]        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^

  

> Federation: FSDataset in Datanode should be created after initial handshake with namenode
> -----------------------------------------------------------------------------------------
>
>                 Key: HDFS-1637
>                 URL: https://issues.apache.org/jira/browse/HDFS-1637
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: Federation Branch
>            Reporter: Jitendra Nath Pandey
>            Assignee: Jitendra Nath Pandey
>             Fix For: Federation Branch
>
>         Attachments: HDFS-1637.1.patch
>
>
> Currently storage is initialized only after handshake with a namenode.However FSDataset is created before handshake and hence before storage initialization. At this time, storage does not have storage directories resulting in FSDataset initialized with no volumes.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (HDFS-1637) Federation: FSDataset in Datanode should be created after initial handshake with namenode

Posted by "Jitendra Nath Pandey (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-1637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12998585#comment-12998585 ] 

Jitendra Nath Pandey commented on HDFS-1637:
--------------------------------------------

In this patch, the initFsDataSet is called when setupBP (which performs handshake with namenode) has succeeded for a namenode. Although, initFsDataSet will be called multiple times (once after handshake with each namenode), but FSDataset is initialized only once. 

> Federation: FSDataset in Datanode should be created after initial handshake with namenode
> -----------------------------------------------------------------------------------------
>
>                 Key: HDFS-1637
>                 URL: https://issues.apache.org/jira/browse/HDFS-1637
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: Federation Branch
>            Reporter: Jitendra Nath Pandey
>            Assignee: Jitendra Nath Pandey
>             Fix For: Federation Branch
>
>         Attachments: HDFS-1637.1.patch
>
>
> Currently storage is initialized only after handshake with a namenode.However FSDataset is created before handshake and hence before storage initialization. At this time, storage does not have storage directories resulting in FSDataset initialized with no volumes.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (HDFS-1637) Federation: FSDataset in Datanode should be created after initial handshake with namenode

Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-1637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12998589#comment-12998589 ] 

Suresh Srinivas commented on HDFS-1637:
---------------------------------------

+1 for the patch with test-patch results

> Federation: FSDataset in Datanode should be created after initial handshake with namenode
> -----------------------------------------------------------------------------------------
>
>                 Key: HDFS-1637
>                 URL: https://issues.apache.org/jira/browse/HDFS-1637
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: Federation Branch
>            Reporter: Jitendra Nath Pandey
>            Assignee: Jitendra Nath Pandey
>             Fix For: Federation Branch
>
>         Attachments: HDFS-1637.1.patch
>
>
> Currently storage is initialized only after handshake with a namenode.However FSDataset is created before handshake and hence before storage initialization. At this time, storage does not have storage directories resulting in FSDataset initialized with no volumes.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Resolved: (HDFS-1637) Federation: FSDataset in Datanode should be created after initial handshake with namenode

Posted by "Jitendra Nath Pandey (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HDFS-1637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jitendra Nath Pandey resolved HDFS-1637.
----------------------------------------

      Resolution: Fixed
    Hadoop Flags: [Reviewed]

> Federation: FSDataset in Datanode should be created after initial handshake with namenode
> -----------------------------------------------------------------------------------------
>
>                 Key: HDFS-1637
>                 URL: https://issues.apache.org/jira/browse/HDFS-1637
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: Federation Branch
>            Reporter: Jitendra Nath Pandey
>            Assignee: Jitendra Nath Pandey
>             Fix For: Federation Branch
>
>         Attachments: HDFS-1637.1.patch
>
>
> Currently storage is initialized only after handshake with a namenode.However FSDataset is created before handshake and hence before storage initialization. At this time, storage does not have storage directories resulting in FSDataset initialized with no volumes.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (HDFS-1637) Federation: FSDataset in Datanode should be created after initial handshake with namenode

Posted by "Jitendra Nath Pandey (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-1637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12998997#comment-12998997 ] 

Jitendra Nath Pandey commented on HDFS-1637:
--------------------------------------------

I committed this to the Federation branch.

> Federation: FSDataset in Datanode should be created after initial handshake with namenode
> -----------------------------------------------------------------------------------------
>
>                 Key: HDFS-1637
>                 URL: https://issues.apache.org/jira/browse/HDFS-1637
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: Federation Branch
>            Reporter: Jitendra Nath Pandey
>            Assignee: Jitendra Nath Pandey
>             Fix For: Federation Branch
>
>         Attachments: HDFS-1637.1.patch
>
>
> Currently storage is initialized only after handshake with a namenode.However FSDataset is created before handshake and hence before storage initialization. At this time, storage does not have storage directories resulting in FSDataset initialized with no volumes.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira