You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Santhosh Kumar Shanmugham <sa...@gmail.com> on 2018/05/15 21:56:53 UTC
Review Request 67142: Add SlaManager to encapsulate SLA operations.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67142/
-----------------------------------------------------------
Review request for Aurora, David McLaughlin, Jordan Ly, Renan DelValle, and Stephan Erb.
Bugs: AURORA-1978
https://issues.apache.org/jira/browse/AURORA-1978
Repository: aurora
Description
-------
Introduce an SlaManager that provies an interface
for perfoming SLA-safe actions. This will be used
by the MaintenanceController to perform SLA-safe
host maintenance and the JobUpdateController to
perform SLA-safe job updates.
Diffs
-----
src/main/java/org/apache/aurora/scheduler/sla/SlaManager.java PRE-CREATION
src/test/java/org/apache/aurora/scheduler/sla/SlaManagerTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/67142/diff/1/
Testing
-------
./build-support/jenkins/build.sh
Thanks,
Santhosh Kumar Shanmugham
Re: Review Request 67142: Add SlaManager to encapsulate SLA
operations.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67142/#review203174
-----------------------------------------------------------
Master (805a53f) is red with this patch.
./build-support/jenkins/build.sh
private boolean meetsSLAInstances(ISlaPolicy slaPolicy, long running, long total) {
^
symbol: class ISlaPolicy
location: class SlaManager
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/sla/SlaManager.java:184: error: cannot find symbol
private boolean checkSla(IScheduledTask task, ISlaPolicy slaPolicy, StoreProvider store) {
^
symbol: class ISlaPolicy
location: class SlaManager
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/sla/SlaManager.java:233: error: cannot find symbol
ICoordinatorSlaPolicy slaPolicy,
^
symbol: class ICoordinatorSlaPolicy
location: class SlaManager
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/sla/SlaManager.java:275: error: cannot find symbol
private boolean coordinatorAllows(String taskKey, ICoordinatorSlaPolicy slaPolicy)
^
symbol: class ICoordinatorSlaPolicy
location: class SlaManager
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/sla/SlaManager.java:344: error: cannot find symbol
ISlaPolicy slaPolicy,
^
symbol: class ISlaPolicy
location: class SlaManager
8 errors
FAILED
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':compileJava'.
> Compilation failed; see the compiler error output for details.
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.
* Get more help at https://help.gradle.org
BUILD FAILED in 2m 20s
16 actionable tasks: 10 executed, 6 up-to-date
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On May 15, 2018, 9:56 p.m., Santhosh Kumar Shanmugham wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67142/
> -----------------------------------------------------------
>
> (Updated May 15, 2018, 9:56 p.m.)
>
>
> Review request for Aurora, David McLaughlin, Jordan Ly, Renan DelValle, and Stephan Erb.
>
>
> Bugs: AURORA-1978
> https://issues.apache.org/jira/browse/AURORA-1978
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Introduce an SlaManager that provies an interface
> for perfoming SLA-safe actions. This will be used
> by the MaintenanceController to perform SLA-safe
> host maintenance and the JobUpdateController to
> perform SLA-safe job updates.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/sla/SlaManager.java PRE-CREATION
> src/test/java/org/apache/aurora/scheduler/sla/SlaManagerTest.java PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/67142/diff/1/
>
>
> Testing
> -------
>
> ./build-support/jenkins/build.sh
>
>
> Thanks,
>
> Santhosh Kumar Shanmugham
>
>