You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Gary VanMatre (Created) (JIRA)" <de...@myfaces.apache.org> on 2011/10/19 19:51:10 UTC

[jira] [Created] (TRINIDAD-2151) Missing new JSF 2 signatures on ServletExternalContext

Missing new JSF 2 signatures on ServletExternalContext
------------------------------------------------------

                 Key: TRINIDAD-2151
                 URL: https://issues.apache.org/jira/browse/TRINIDAD-2151
             Project: MyFaces Trinidad
          Issue Type: Bug
          Components: Components
    Affects Versions: 2.0.2-core
         Environment: n/a
            Reporter: Gary VanMatre


The ServeletExternalContext extension of the external context doesn't implement the "encodeRedirectURL" method and ends up calling on the base "JSF RI" implementation in ExternalContext.  This code is even more confusing as it reference a private "defaultExternalContext" that has no way to set its value.  Odd way to implement an abstract interface class IMO.

    public String encodeRedirectURL(String baseUrl,
                                    Map<String,List<String>> parameters) {

        if (defaultExternalContext != null) {
            return defaultExternalContext.encodeRedirectURL(baseUrl, parameters);
        }
        throw new UnsupportedOperationException();

    }

We need to implement a few more of these newer JSF 2 signatures on the ServeletExternalContext. 



--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (TRINIDAD-2151) Missing new JSF 2 signatures on ServletExternalContext

Posted by "Gary VanMatre (Updated) (JIRA)" <de...@myfaces.apache.org>.
     [ https://issues.apache.org/jira/browse/TRINIDAD-2151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gary VanMatre updated TRINIDAD-2151:
------------------------------------

    Status: Patch Available  (was: Open)
    
> Missing new JSF 2 signatures on ServletExternalContext
> ------------------------------------------------------
>
>                 Key: TRINIDAD-2151
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-2151
>             Project: MyFaces Trinidad
>          Issue Type: Bug
>          Components: Components
>    Affects Versions: 2.0.2-core
>         Environment: n/a
>            Reporter: Gary VanMatre
>
> The ServeletExternalContext extension of the external context doesn't implement the "encodeRedirectURL" method and ends up calling on the base "JSF RI" implementation in ExternalContext.  This code is even more confusing as it reference a private "defaultExternalContext" that has no way to set its value.  Odd way to implement an abstract interface class IMO.
>     public String encodeRedirectURL(String baseUrl,
>                                     Map<String,List<String>> parameters) {
>         if (defaultExternalContext != null) {
>             return defaultExternalContext.encodeRedirectURL(baseUrl, parameters);
>         }
>         throw new UnsupportedOperationException();
>     }
> We need to implement a few more of these newer JSF 2 signatures on the ServeletExternalContext. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (TRINIDAD-2151) Missing new JSF 2 signatures on ServletExternalContext

Posted by "Scott O'Bryan (Updated) (JIRA)" <de...@myfaces.apache.org>.
     [ https://issues.apache.org/jira/browse/TRINIDAD-2151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Scott O'Bryan updated TRINIDAD-2151:
------------------------------------

       Resolution: Fixed
    Fix Version/s: 2.0.2-core
           Status: Resolved  (was: Patch Available)

Thanks for the patch
                
> Missing new JSF 2 signatures on ServletExternalContext
> ------------------------------------------------------
>
>                 Key: TRINIDAD-2151
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-2151
>             Project: MyFaces Trinidad
>          Issue Type: Bug
>          Components: Components
>    Affects Versions: 2.0.2-core
>         Environment: n/a
>            Reporter: Gary VanMatre
>            Assignee: Scott O'Bryan
>             Fix For: 2.0.2-core
>
>         Attachments: ServletEC.patch
>
>
> The ServeletExternalContext extension of the external context doesn't implement the "encodeRedirectURL" method and ends up calling on the base "JSF RI" implementation in ExternalContext.  This code is even more confusing as it reference a private "defaultExternalContext" that has no way to set its value.  Odd way to implement an abstract interface class IMO.
>     public String encodeRedirectURL(String baseUrl,
>                                     Map<String,List<String>> parameters) {
>         if (defaultExternalContext != null) {
>             return defaultExternalContext.encodeRedirectURL(baseUrl, parameters);
>         }
>         throw new UnsupportedOperationException();
>     }
> We need to implement a few more of these newer JSF 2 signatures on the ServeletExternalContext. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira