You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Daryn Sharp (JIRA)" <ji...@apache.org> on 2011/04/29 03:45:03 UTC
[jira] [Created] (HADOOP-7249) Refactor FsShell's chmod/chown/chgrp
Refactor FsShell's chmod/chown/chgrp
------------------------------------
Key: HADOOP-7249
URL: https://issues.apache.org/jira/browse/HADOOP-7249
Project: Hadoop Common
Issue Type: Improvement
Components: fs
Affects Versions: 0.23.0
Reporter: Daryn Sharp
Assignee: Daryn Sharp
Need to refactor permissions commands to conform to new FsCommand class.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7249) Refactor FsShell's
chmod/chown/chgrp
Posted by "Matt Foley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13029490#comment-13029490 ]
Matt Foley commented on HADOOP-7249:
------------------------------------
Hi Daryn, generally looks good but in FsShellPermissions.parseOwnerGroup() a tab (instead of spaces) crept in to the added lines just below "group = null;", to wit:
if (group != null && group.length() == 0) {
- group = null;
- }
+ group = null;
+ } <-- problem here, and possibly prev line
> Refactor FsShell's chmod/chown/chgrp
> ------------------------------------
>
> Key: HADOOP-7249
> URL: https://issues.apache.org/jira/browse/HADOOP-7249
> Project: Hadoop Common
> Issue Type: Improvement
> Components: fs
> Affects Versions: 0.23.0
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Attachments: HADOOP-7249.patch
>
>
> Need to refactor permissions commands to conform to new FsCommand class.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7249) Refactor FsShell's
chmod/chown/chgrp
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13026814#comment-13026814 ]
Hadoop QA commented on HADOOP-7249:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12477719/HADOOP-7249.patch
against trunk revision 1097322.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 10 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
+1 system test framework. The patch passed system test framework compile.
Test results: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/384//testReport/
Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/384//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/384//console
This message is automatically generated.
> Refactor FsShell's chmod/chown/chgrp
> ------------------------------------
>
> Key: HADOOP-7249
> URL: https://issues.apache.org/jira/browse/HADOOP-7249
> Project: Hadoop Common
> Issue Type: Improvement
> Components: fs
> Affects Versions: 0.23.0
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Attachments: HADOOP-7249.patch
>
>
> Need to refactor permissions commands to conform to new FsCommand class.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7249) Refactor FsShell's
chmod/chown/chgrp
Posted by "Matt Foley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13029554#comment-13029554 ]
Matt Foley commented on HADOOP-7249:
------------------------------------
+1
> Refactor FsShell's chmod/chown/chgrp
> ------------------------------------
>
> Key: HADOOP-7249
> URL: https://issues.apache.org/jira/browse/HADOOP-7249
> Project: Hadoop Common
> Issue Type: Improvement
> Components: fs
> Affects Versions: 0.23.0
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Attachments: HADOOP-7249-2.patch, HADOOP-7249.patch
>
>
> Need to refactor permissions commands to conform to new FsCommand class.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7249) Refactor FsShell's
chmod/chown/chgrp
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13030315#comment-13030315 ]
Hudson commented on HADOOP-7249:
--------------------------------
Integrated in Hadoop-Common-trunk #681 (See [https://builds.apache.org/hudson/job/Hadoop-Common-trunk/681/])
Remove the empty file accidentally checked it with HADOOP-7249.
HADOOP-7249. Refactor the chmod/chown/chgrp command to conform to new FsCommand class. Contributed by Daryn Sharp
> Refactor FsShell's chmod/chown/chgrp
> ------------------------------------
>
> Key: HADOOP-7249
> URL: https://issues.apache.org/jira/browse/HADOOP-7249
> Project: Hadoop Common
> Issue Type: Improvement
> Components: fs
> Affects Versions: 0.23.0
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Fix For: 0.23.0
>
> Attachments: HADOOP-7249-2.patch, HADOOP-7249.patch
>
>
> Need to refactor permissions commands to conform to new FsCommand class.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7249) Refactor FsShell's chmod/chown/chgrp
Posted by "Daryn Sharp (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daryn Sharp updated HADOOP-7249:
--------------------------------
Status: Patch Available (was: Open)
> Refactor FsShell's chmod/chown/chgrp
> ------------------------------------
>
> Key: HADOOP-7249
> URL: https://issues.apache.org/jira/browse/HADOOP-7249
> Project: Hadoop Common
> Issue Type: Improvement
> Components: fs
> Affects Versions: 0.23.0
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Attachments: HADOOP-7249.patch
>
>
> Need to refactor permissions commands to conform to new FsCommand class.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7249) Refactor FsShell's chmod/chown/chgrp
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-7249:
-------------------------------------------
Resolution: Fixed
Fix Version/s: 0.23.0
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
I have committed this. Thanks, Daryn!
Thanks also Matt for reviewing it.
> Refactor FsShell's chmod/chown/chgrp
> ------------------------------------
>
> Key: HADOOP-7249
> URL: https://issues.apache.org/jira/browse/HADOOP-7249
> Project: Hadoop Common
> Issue Type: Improvement
> Components: fs
> Affects Versions: 0.23.0
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Fix For: 0.23.0
>
> Attachments: HADOOP-7249-2.patch, HADOOP-7249.patch
>
>
> Need to refactor permissions commands to conform to new FsCommand class.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7249) Refactor FsShell's
chmod/chown/chgrp
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13029505#comment-13029505 ]
Hadoop QA commented on HADOOP-7249:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12478308/HADOOP-7249-2.patch
against trunk revision 1099633.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 10 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
+1 system test framework. The patch passed system test framework compile.
Test results: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/406//testReport/
Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/406//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/406//console
This message is automatically generated.
> Refactor FsShell's chmod/chown/chgrp
> ------------------------------------
>
> Key: HADOOP-7249
> URL: https://issues.apache.org/jira/browse/HADOOP-7249
> Project: Hadoop Common
> Issue Type: Improvement
> Components: fs
> Affects Versions: 0.23.0
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Attachments: HADOOP-7249-2.patch, HADOOP-7249.patch
>
>
> Need to refactor permissions commands to conform to new FsCommand class.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7249) Refactor FsShell's
chmod/chown/chgrp
Posted by "Matt Foley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13029491#comment-13029491 ]
Matt Foley commented on HADOOP-7249:
------------------------------------
{code}
if (group != null && group.length() == 0) {
- group = null;
- }
+ group = null;
+ } <-- problem here, and possibly prev line
{code}
> Refactor FsShell's chmod/chown/chgrp
> ------------------------------------
>
> Key: HADOOP-7249
> URL: https://issues.apache.org/jira/browse/HADOOP-7249
> Project: Hadoop Common
> Issue Type: Improvement
> Components: fs
> Affects Versions: 0.23.0
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Attachments: HADOOP-7249.patch
>
>
> Need to refactor permissions commands to conform to new FsCommand class.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7249) Refactor FsShell's chmod/chown/chgrp
Posted by "Daryn Sharp (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daryn Sharp updated HADOOP-7249:
--------------------------------
Attachment: HADOOP-7249.patch
Converted commands to FsCommand.
Removed cruft in FsShell only used by these commands.
Add exitCodeForError() to account for inconsistencies in the exit code returned by various commands.
Greatly improved testing of exit codes related to these commands due to prior issues of returning the exit code of the last argument only.
> Refactor FsShell's chmod/chown/chgrp
> ------------------------------------
>
> Key: HADOOP-7249
> URL: https://issues.apache.org/jira/browse/HADOOP-7249
> Project: Hadoop Common
> Issue Type: Improvement
> Components: fs
> Affects Versions: 0.23.0
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Attachments: HADOOP-7249.patch
>
>
> Need to refactor permissions commands to conform to new FsCommand class.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7249) Refactor FsShell's
chmod/chown/chgrp
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13030171#comment-13030171 ]
Hudson commented on HADOOP-7249:
--------------------------------
Integrated in Hadoop-Common-trunk-Commit #580 (See [https://builds.apache.org/hudson/job/Hadoop-Common-trunk-Commit/580/])
Remove the empty file accidentally checked it with HADOOP-7249.
> Refactor FsShell's chmod/chown/chgrp
> ------------------------------------
>
> Key: HADOOP-7249
> URL: https://issues.apache.org/jira/browse/HADOOP-7249
> Project: Hadoop Common
> Issue Type: Improvement
> Components: fs
> Affects Versions: 0.23.0
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Fix For: 0.23.0
>
> Attachments: HADOOP-7249-2.patch, HADOOP-7249.patch
>
>
> Need to refactor permissions commands to conform to new FsCommand class.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7249) Refactor FsShell's chmod/chown/chgrp
Posted by "Daryn Sharp (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daryn Sharp updated HADOOP-7249:
--------------------------------
Attachment: HADOOP-7249-2.patch
Removed tabs.
> Refactor FsShell's chmod/chown/chgrp
> ------------------------------------
>
> Key: HADOOP-7249
> URL: https://issues.apache.org/jira/browse/HADOOP-7249
> Project: Hadoop Common
> Issue Type: Improvement
> Components: fs
> Affects Versions: 0.23.0
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Attachments: HADOOP-7249-2.patch, HADOOP-7249.patch
>
>
> Need to refactor permissions commands to conform to new FsCommand class.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7249) Refactor FsShell's
chmod/chown/chgrp
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13030123#comment-13030123 ]
Hudson commented on HADOOP-7249:
--------------------------------
Integrated in Hadoop-Common-trunk-Commit #578 (See [https://builds.apache.org/hudson/job/Hadoop-Common-trunk-Commit/578/])
HADOOP-7249. Refactor the chmod/chown/chgrp command to conform to new FsCommand class. Contributed by Daryn Sharp
> Refactor FsShell's chmod/chown/chgrp
> ------------------------------------
>
> Key: HADOOP-7249
> URL: https://issues.apache.org/jira/browse/HADOOP-7249
> Project: Hadoop Common
> Issue Type: Improvement
> Components: fs
> Affects Versions: 0.23.0
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Fix For: 0.23.0
>
> Attachments: HADOOP-7249-2.patch, HADOOP-7249.patch
>
>
> Need to refactor permissions commands to conform to new FsCommand class.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira