You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/07/10 01:06:15 UTC
[GitHub] [airflow] dimberman opened a new pull request #9748: Add TargetQueryValue to KEDA Autoscaler
dimberman opened a new pull request #9748:
URL: https://github.com/apache/airflow/pull/9748
---
Make sure to mark the boxes below before creating PR: [x]
- [ ] Description above provides context of the change
- [ ] Unit tests coverage for changes (not needed for documentation changes)
- [ ] Target Github ISSUE in description if exists
- [ ] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [ ] Relevant documentation is updated including usage instructions.
- [ ] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #9748: Add TargetQueryValue to KEDA Autoscaler
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #9748:
URL: https://github.com/apache/airflow/pull/9748#issuecomment-656482120
CC: @turbaszek ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on a change in pull request #9748: Add TargetQueryValue to KEDA Autoscaler
Posted by GitBox <gi...@apache.org>.
turbaszek commented on a change in pull request #9748:
URL: https://github.com/apache/airflow/pull/9748#discussion_r452625707
##########
File path: chart/templates/workers/worker-kedaautoscaler.yaml
##########
@@ -42,6 +42,7 @@ spec:
triggers:
- type: postgresql
metadata:
+ targetQueryValue: "1"
connection: AIRFLOW_CONN_AIRFLOW_DB
query: "SELECT ceil(COUNT(*)::decimal / 16) FROM task_instance WHERE state='running' OR state='queued'"
Review comment:
Btw. can we template the `16` value?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dimberman commented on a change in pull request #9748: Add TargetQueryValue to KEDA Autoscaler
Posted by GitBox <gi...@apache.org>.
dimberman commented on a change in pull request #9748:
URL: https://github.com/apache/airflow/pull/9748#discussion_r452891052
##########
File path: chart/templates/workers/worker-kedaautoscaler.yaml
##########
@@ -42,6 +42,7 @@ spec:
triggers:
- type: postgresql
metadata:
+ targetQueryValue: "1"
connection: AIRFLOW_CONN_AIRFLOW_DB
query: "SELECT ceil(COUNT(*)::decimal / 16) FROM task_instance WHERE state='running' OR state='queued'"
Review comment:
Yes we can but let's do a different PR for that
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dimberman merged pull request #9748: Add TargetQueryValue to KEDA Autoscaler
Posted by GitBox <gi...@apache.org>.
dimberman merged pull request #9748:
URL: https://github.com/apache/airflow/pull/9748
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org