You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2021/07/21 11:54:52 UTC

[GitHub] [iceberg] findepi commented on pull request #2836: [Python] support BucketByteBuffer and BucketUUID

findepi commented on pull request #2836:
URL: https://github.com/apache/iceberg/pull/2836#issuecomment-884131235


   Elevating the 'wrong' behavior to be 'the standard' will be hard for non-Java languages.
   Please take a look at my proposed fix in Guava https://github.com/google/guava/pull/5649 for this.
   In order to match Iceberg Java implementation, one would perhaps need to translate that code (without the fix) into Python.
   
   Waiting for Java bucketing version to be fixed seems reasonable though. This avoids correctness issues -- no support for bucketing in Python, means no bugs at all.
   
   FWIW, in Trino, bucketing did not have the bug (that's how we found https://github.com/apache/iceberg/issues/2837), so 'correctly' bucketed data can be out there too.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org