You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2022/05/13 12:09:21 UTC

[GitHub] [netbeans] vieiro opened a new pull request, #4114: [cnd] Dropping cpplite and fortran sample

vieiro opened a new pull request, #4114:
URL: https://github.com/apache/netbeans/pull/4114

   This PR:
   
   - Moves cpplite to contrib.
   - Restores some previously commented lines in cpplite now in contrib, for future reference.
   - Hides the "Fortran" sample in C/C++ projects (we may add Fortran LSP server in the future), though).,
   
   Users that use cpplite may still create a new C/C++ project and import sources there.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] vieiro commented on pull request #4114: [cnd] Dropping cpplite and fortran sample

Posted by GitBox <gi...@apache.org>.
vieiro commented on PR #4114:
URL: https://github.com/apache/netbeans/pull/4114#issuecomment-1126205019

   Yep, it seems we're using cpplite projects elsewhere through the [general ClassLoader](https://github.com/apache/netbeans/blob/6543326b16fdcb05092fbb7af86fe817a07586b3/java/java.openjdk.project/src/org/netbeans/modules/java/openjdk/project/CProjectConfigurationProviderImpl.java#L61), also [cpplite is registered in ergonomics](https://github.com/apache/netbeans/blob/master/ergonomics/ide.ergonomics/test/unit/src/org/netbeans/modules/ide/ergonomics/DynamicVerifyTest.java#L147)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] vieiro closed pull request #4114: [cnd] Dropping cpplite and fortran sample

Posted by GitBox <gi...@apache.org>.
vieiro closed pull request #4114: [cnd] Dropping cpplite and fortran sample
URL: https://github.com/apache/netbeans/pull/4114


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] vieiro commented on pull request #4114: [cnd] Dropping cpplite and fortran sample

Posted by GitBox <gi...@apache.org>.
vieiro commented on PR #4114:
URL: https://github.com/apache/netbeans/pull/4114#issuecomment-1126191329

   Mmm, it seems we didn't get rid of cpplite properly...
   
   ```
   2022-05-13T12:26:27.0959591Z     [junit] Testcase: testGetAllProjectFactories(org.netbeans.modules.ide.ergonomics.DynamicVerifyTest):	FAILED
   2022-05-13T12:26:27.0960092Z     [junit] Not all IDE projects are registered for ergonomics mode, see the list below.
   2022-05-13T12:26:27.0960510Z     [junit] This may mean that you are not using @AntBasedProjectRegistration to register
   2022-05-13T12:26:27.0960997Z     [junit] your projects, or that you need to hardcode the nature of your project into
   2022-05-13T12:26:27.0961363Z     [junit] ide.ergonomics/*.properties using XPath. For more information see
   2022-05-13T12:26:27.0961827Z     [junit] http://wiki.netbeans.org/FitnessForever The list of differences follows:
   2022-05-13T12:26:27.0962269Z     [junit] org.netbeans.modules.gradle.NbGradleProjectFactory OK
   2022-05-13T12:26:27.0962879Z     [junit] org.netbeans.modules.java.openjdk.project.FilterStandardProjects OK
   2022-05-13T12:26:27.0963341Z     [junit] org.netbeans.modules.java.mx.project.SuiteFactory OK
   2022-05-13T12:26:27.0979501Z     [junit] org.netbeans.modules.project.ant.AntBasedProjectFactorySingleton OK
   2022-05-13T12:26:27.0980021Z     [junit] org.netbeans.modules.cnd.makeproject.MakeBasedProjectFactorySingleton OK
   2022-05-13T12:26:27.0980479Z     [junit] org.netbeans.modules.maven.NbMavenProjectFactory OK
   2022-05-13T12:26:27.0980918Z     [junit] org.netbeans.modules.project.ui.convertor.ProjectConvertorFactory OK
   2022-05-13T12:26:27.0981596Z     [junit] org.netbeans.modules.java.openjdk.project.JDKProject$JDKProjectFactory OK
   2022-05-13T12:26:27.0981912Z     [junit] 
   2022-05-13T12:26:27.0982278Z     [junit] Should be empty: {NoProjectFileAvailable=org.netbeans.modules.cpplite.project.CPPLiteProject$FactoryImpl}
   2022-05-13T12:26:27.0982627Z     [junit] 
   2022-05-13T12:26:27.0982976Z     [junit] Not processed: NoProjectFileAvailable = org.netbeans.modules.cpplite.project.CPPLiteProject$FactoryImpl
   2022-05-13T12:26:27.0983486Z     [junit] junit.framework.AssertionFailedError: Not all IDE projects are registered for ergonomics mode, see the list below.
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] mbien commented on pull request #4114: [cnd] Dropping cpplite and fortran sample

Posted by GitBox <gi...@apache.org>.
mbien commented on PR #4114:
URL: https://github.com/apache/netbeans/pull/4114#issuecomment-1126562855

   > Yep, it seems we're using cpplite projects elsewhere through the [general ClassLoader](https://github.com/apache/netbeans/blob/6543326b16fdcb05092fbb7af86fe817a07586b3/java/java.openjdk.project/src/org/netbeans/modules/java/openjdk/project/CProjectConfigurationProviderImpl.java#L61), also [cpplite is registered in ergonomics](https://github.com/apache/netbeans/blob/master/ergonomics/ide.ergonomics/test/unit/src/org/netbeans/modules/ide/ergonomics/DynamicVerifyTest.java#L147)
   
   ergonomics isn't loaded anymore for IDE purposes (#3410), its still part of the platform though. This should be simply removed i believe otherwise it would load the module again :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] vieiro commented on pull request #4114: [cnd] Dropping cpplite and fortran sample

Posted by GitBox <gi...@apache.org>.
vieiro commented on PR #4114:
URL: https://github.com/apache/netbeans/pull/4114#issuecomment-1143981579

   Let's close this one. As discussed in the mailing list there's some internal internest in keeping cpplite stuff. Let's investigate how to make cnd and cpplite compatible, if possible.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists