[GitHub] [accumulo] EdColeman commented on a diff in pull request #3329: Throw new exception when invalid tablet hosting request made

["EdColeman (via GitHub)" <gi...@apache.org>]

EdColeman commented on code in PR #3329:
URL: https://github.com/apache/accumulo/pull/3329#discussion_r1174220897


##########
core/src/main/java/org/apache/accumulo/core/client/admin/TableOperations.java:
##########
@@ -213,10 +214,12 @@ Collection<Text> listSplits(String tableName, int maxSplits)
    * @param ranges The input ranges that should be mapped to tablet servers and tablets.
    *
    * @throws TableOfflineException if the table is offline or goes offline during the operation
+   * @throws InvalidTabletHostingRequestException if tablet hosting is requested for table with
+   *         NEVER goal
    * @since 1.8.0
    */
-  Locations locate(String tableName, Collection<Range> ranges)
-      throws AccumuloException, AccumuloSecurityException, TableNotFoundException;

Review Comment:
   If the method is only changing the exceptions - it may not be possible to mark the method as deprecated and provide the "new" method - if the only difference is the exceptions in the method signature.  



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org