Re: Review Request 63353: Don't clear the executor ID of non-command executors on re-registration.

[Mesos Reviewbot Windows <re...@mesos.apache.org>]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63353/#review189780
-----------------------------------------------------------



PASS: Mesos patch 63353 was successfully built and tested.

Reviews applied: `['63353']`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63353

- Mesos Reviewbot Windows


On Oct. 27, 2017, 7:48 a.m., Gaston Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63353/
> -----------------------------------------------------------
> 
> (Updated Oct. 27, 2017, 7:48 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Greg Mann, and Vinod Kone.
> 
> 
> Bugs: MESOS-8135
>     https://issues.apache.org/jira/browse/MESOS-8135
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Previously the agent would sometimes clear the executor ID of
> non-command executors before sending the `ReregisterSlaveMessage`
> message.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.cpp d8477b4e364270f5ad61311aa8fe48f823bc7aac 
>   src/tests/master_slave_reconciliation_tests.cpp d5eb7ba68c5308338236879e7cb1e970a01e48e6 
> 
> 
> Diff: https://reviews.apache.org/r/63353/diff/1/
> 
> 
> Testing
> -------
> 
> Verified that the new test fails on GNU/Linux without the rest of the patch, but passes with it.
> 
> 
> Thanks,
> 
> Gaston Kleiman
> 
>