[GitHub] [incubator-superset] bkyryliuk commented on a change in pull request #10506: fix: refactored SQL-based alerts to not pass sqlalchemy objects as args

[GitBox <gi...@apache.org>]

bkyryliuk commented on a change in pull request #10506:
URL: https://github.com/apache/incubator-superset/pull/10506#discussion_r464741076



##########
File path: superset/tasks/schedules.py
##########
@@ -612,10 +614,12 @@ def deliver_alert(alert: Alert, recipients: Optional[str] = None) -> None:
     _deliver_email(recipients, deliver_as_group, subject, body, data, images)
 
 
-def run_alert_query(alert: Alert) -> Optional[bool]:
+def run_alert_query(alert_id: int) -> Optional[bool]:

Review comment:
       @JasonD28 let's start adding tests




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org