You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "chickenlj (GitHub)" <gi...@apache.org> on 2018/11/22 19:25:28 UTC
[GitHub] [incubator-dubbo] chickenlj commented on pull request #2820:
Code review around Environment, AbstractConfig,
and AbstractPrefixConfiguration's impls.
I think caculatePrefix cannot be used here because the previous snippet will possibly try 2 times in the case when both neither and id are not empty. But with the new logic applies, it will only try once with the prefix returned in caculatePrefix.
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2820 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org