You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@paimon.apache.org by "jerry-024 (via GitHub)" <gi...@apache.org> on 2025/03/24 10:24:27 UTC
[PR] [core] support alter view [paimon]
jerry-024 opened a new pull request, #5335:
URL: https://github.com/apache/paimon/pull/5335
<!-- Please specify the module before the PR name: [core] ... or [flink] ... -->
### Purpose
<!-- Linking this pull request to the issue -->
Linked issue: close #xxx
<!-- What is the purpose of the change -->
### Tests
<!-- List UT and IT cases to verify this change -->
### API and Format
<!-- Does this change affect API or storage format -->
### Documentation
<!-- Does this change introduce a new feature -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [core] support alter view and alter view's dialect procedure [paimon]
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi commented on code in PR #5335:
URL: https://github.com/apache/paimon/pull/5335#discussion_r2013350707
##########
docs/content/flink/procedures.md:
##########
@@ -799,5 +799,30 @@ All available procedures are listed below.
CALL sys.rescale(`table` => 'default.T', `bucket_num` => 16, `partition` => 'dt=20250217,hh=08')
</td>
</tr>
+ <tr>
+ <td>alter_view_dialect</td>
+ <td>
+ -- add dialect in the view<br/>
+ CALL [catalog.]sys.alter_view_dialect('view', 'add', 'query')<br/><br/>
Review Comment:
Maybe we need a parameter: engine?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [core] support alter view and alter view's dialect procedure [paimon]
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi merged PR #5335:
URL: https://github.com/apache/paimon/pull/5335
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [core] support alter view and alter view's dialect procedure [paimon]
Posted by "jerry-024 (via GitHub)" <gi...@apache.org>.
jerry-024 commented on code in PR #5335:
URL: https://github.com/apache/paimon/pull/5335#discussion_r2013402529
##########
docs/content/flink/procedures.md:
##########
@@ -799,5 +799,30 @@ All available procedures are listed below.
CALL sys.rescale(`table` => 'default.T', `bucket_num` => 16, `partition` => 'dt=20250217,hh=08')
</td>
</tr>
+ <tr>
+ <td>alter_view_dialect</td>
+ <td>
+ -- add dialect in the view<br/>
+ CALL [catalog.]sys.alter_view_dialect('view', 'add', 'query')<br/><br/>
Review Comment:
get.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [core] support alter view and alter view's dialect procedure [paimon]
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi commented on code in PR #5335:
URL: https://github.com/apache/paimon/pull/5335#discussion_r2013517058
##########
docs/content/flink/procedures.md:
##########
@@ -799,5 +799,37 @@ All available procedures are listed below.
CALL sys.rescale(`table` => 'default.T', `bucket_num` => 16, `partition` => 'dt=20250217,hh=08')
</td>
</tr>
+ <tr>
+ <td>alter_view_dialect</td>
+ <td>
+ -- add dialect in the view<br/>
+ CALL [catalog.]sys.alter_view_dialect('view', 'add', 'query')<br/>
Review Comment:
Maybe we can just make engine required?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [core] support alter view and alter view's dialect procedure [paimon]
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi commented on code in PR #5335:
URL: https://github.com/apache/paimon/pull/5335#discussion_r2013517058
##########
docs/content/flink/procedures.md:
##########
@@ -799,5 +799,37 @@ All available procedures are listed below.
CALL sys.rescale(`table` => 'default.T', `bucket_num` => 16, `partition` => 'dt=20250217,hh=08')
</td>
</tr>
+ <tr>
+ <td>alter_view_dialect</td>
+ <td>
+ -- add dialect in the view<br/>
+ CALL [catalog.]sys.alter_view_dialect('view', 'add', 'query')<br/>
Review Comment:
Maybe the order can be:
view_identifier, action, engine, query.
If not specific engine, should use named arguement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [core] support alter view and alter view's dialect procedure [paimon]
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi commented on code in PR #5335:
URL: https://github.com/apache/paimon/pull/5335#discussion_r2013350179
##########
paimon-core/src/main/java/org/apache/paimon/view/ViewDialect.java:
##########
@@ -0,0 +1,40 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.paimon.view;
+
+/** Dialect of view. */
+public enum ViewDialect {
Review Comment:
Don't use enum, we have many other compute engines.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org