You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/04/01 08:27:46 UTC

[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #8770: [Bug] Fix some bugs(rewrite rule/symbol transport) of `like predicate`

EmmyMiao87 commented on a change in pull request #8770:
URL: https://github.com/apache/incubator-doris/pull/8770#discussion_r840354258



##########
File path: fe/fe-core/src/main/java/org/apache/doris/analysis/Analyzer.java
##########
@@ -311,7 +310,6 @@ public GlobalState(Catalog catalog, ConnectContext context) {
             rules.add(RewriteDateLiteralRule.INSTANCE);
             rules.add(RewriteEncryptKeyRule.INSTANCE);
             rules.add(RewriteAliasFunctionRule.INSTANCE);
-            rules.add(RewriteLikePredicateRule.INSTANCE);

Review comment:
       I understand that the reason why FE added this rule before is PR because the direct execution of non-vectorized code will make mistakes.
   If only changing FE but not BE, will the non-vectorized code now go wrong?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org