You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "jlprat (via GitHub)" <gi...@apache.org> on 2024/03/18 08:06:43 UTC

[PR] MINOR: Revert to Gradle 8.5 [kafka]

jlprat opened a new pull request, #15553:
URL: https://github.com/apache/kafka/pull/15553

   Rollback to Gradle 8.5.
   When upgrading to Gradle 8.6, Scala incremental compilation seems to be broken. See https://github.com/apache/kafka/pull/15404#discussion_r1526739190
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] MINOR: Revert to Gradle 8.5 [DO NOT MERGE YET] [kafka]

Posted by "gaurav-narula (via GitHub)" <gi...@apache.org>.
gaurav-narula commented on PR #15553:
URL: https://github.com/apache/kafka/pull/15553#issuecomment-2008277511

   Thanks @pasharik ! I was able to reproduce it using the steps you mentioned above.
   
   I've a potential fix. Can you please try updating the zinc version in `gradle/dependencies.gradle:166`  to `1.9.6` and try the steps once again? It seems to fix things on my end.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] MINOR: Revert to Gradle 8.5 [kafka]

Posted by "jlprat (via GitHub)" <gi...@apache.org>.
jlprat commented on PR #15553:
URL: https://github.com/apache/kafka/pull/15553#issuecomment-2003170494

   Oops, you are right @dajac I don't know what happened. I'll check


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] MINOR: Revert to Gradle 8.5 [kafka]

Posted by "jlprat (via GitHub)" <gi...@apache.org>.
jlprat commented on PR #15553:
URL: https://github.com/apache/kafka/pull/15553#issuecomment-2003177508

   I accidentally committed the `core/data` files from some failed test run.
   @dajac feel free to review now. Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] MINOR: Revert to Gradle 8.5 [DO NOT MERGE YET] [kafka]

Posted by "jlprat (via GitHub)" <gi...@apache.org>.
jlprat commented on PR #15553:
URL: https://github.com/apache/kafka/pull/15553#issuecomment-2044991965

   Closing this one, in favour of whatever comes out of https://issues.apache.org/jira/browse/KAFKA-16490


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] MINOR: Revert to Gradle 8.5 [DO NOT MERGE YET] [kafka]

Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on PR #15553:
URL: https://github.com/apache/kafka/pull/15553#issuecomment-2016789588

   > Open kafka.admin.AclCommandTest in IntelliJ Idea. I'm using 2023.3.5 Ultimate
       Add println("a") at the beginning of testAclCliWithAuthorizer method
       Run in terminal: ./gradlew core:test --tests "kafka.admin.AclCommandTest.testAclCliWithAuthorizer"
       Result: all tests in core module are re-compiled
   
   I can't reproduce it and my Idea is 2023.3.6  Ultimate. I add some changes to `testAclCliWithAuthorizer` and then run `./gradlew core:test --tests "kafka.admin.AclCommandTest.testAclCliWithAuthorizer"`. Only file `AclCommandTest.class` get recompiled. 
   
   ![螢幕快照 2024-03-24 20-08-53](https://github.com/apache/kafka/assets/6234750/95fb1d39-dc7c-46bf-a3ef-0a45fb8d59ec)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] MINOR: Revert to Gradle 8.5 [DO NOT MERGE YET] [kafka]

Posted by "pasharik (via GitHub)" <gi...@apache.org>.
pasharik commented on PR #15553:
URL: https://github.com/apache/kafka/pull/15553#issuecomment-2010846230

   @gaurav-narula I've tried zinc `1.9.6` with gradle `8.5` and `8.6`, but getting the same issue with all tests re-compiled.
   
   Probably one radical solution to this incremental compilation issue with Scala, can be re-writing the entire `AclCommandTest` in Java? :smile: I'm looking to add KRaft support for this test, so there will be lot of changes in it anyway, as I understand.  I see there are already some Java tests in `core` module


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] MINOR: Revert to Gradle 8.5 [DO NOT MERGE YET] [kafka]

Posted by "jlprat (via GitHub)" <gi...@apache.org>.
jlprat closed pull request #15553: MINOR: Revert to Gradle 8.5 [DO NOT MERGE YET]
URL: https://github.com/apache/kafka/pull/15553


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] MINOR: Revert to Gradle 8.5 [DO NOT MERGE YET] [kafka]

Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on PR #15553:
URL: https://github.com/apache/kafka/pull/15553#issuecomment-2044859084

   > Update to 8.7 is ok with me. For now, I'm compiling my test with scalac as a workaround anyway
   
   @jlprat thanks for response. ticket: https://issues.apache.org/jira/browse/KAFKA-16490


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] MINOR: Revert to Gradle 8.5 [DO NOT MERGE YET] [kafka]

Posted by "jlprat (via GitHub)" <gi...@apache.org>.
jlprat commented on PR #15553:
URL: https://github.com/apache/kafka/pull/15553#issuecomment-2012398621

   I'm restarting the build. The previous run I started this morning (CET timezone) got hung towards the end (it was running for over 6 hours).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] MINOR: Revert to Gradle 8.5 [DO NOT MERGE YET] [kafka]

Posted by "pasharik (via GitHub)" <gi...@apache.org>.
pasharik commented on PR #15553:
URL: https://github.com/apache/kafka/pull/15553#issuecomment-2007063040

   Hi All,
   
   Update on my original comment: issue with incremental compilation seems to happen only when changes made from IntelliJ.
   
   Would anybody mind trying to reproduce it on your local environment? Steps to reproduce:
   
   * Open `kafka.admin.AclCommandTest` in IntelliJ Idea. I'm using `2023.3.5 Ultimate`
   * Add `println("a")` at the beginning of `testAclCliWithAuthorizer` method
   * Run in terminal: `./gradlew core:test --tests "kafka.admin.AclCommandTest.testAclCliWithAuthorizer"`
   * Result: all tests in `core` module are re-compiled
   
   If test modified with `vim`, only single test class is re-compiled


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] MINOR: Revert to Gradle 8.5 [DO NOT MERGE YET] [kafka]

Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on PR #15553:
URL: https://github.com/apache/kafka/pull/15553#issuecomment-2043666756

   any updates here? gradle 8.7 has been released. we can update gradle to 8.7 if the issue is nonexistent


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] MINOR: Revert to Gradle 8.5 [DO NOT MERGE YET] [kafka]

Posted by "pasharik (via GitHub)" <gi...@apache.org>.
pasharik commented on PR #15553:
URL: https://github.com/apache/kafka/pull/15553#issuecomment-2043855618

   > any updates here? gradle 8.7 has been released. we can update gradle to 8.7 if the issue is nonexistent
   
   Update to 8.7 is ok with me. For now, I'm compiling my test with `scalac` as a workaround anyway


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] MINOR: Revert to Gradle 8.5 [kafka]

Posted by "jlprat (via GitHub)" <gi...@apache.org>.
jlprat commented on PR #15553:
URL: https://github.com/apache/kafka/pull/15553#issuecomment-2003653879

   I managed to reproduce the issue with Gradle 8.6 once, but now that I'm trying to reproduce it again, it seems that incremental compilation works as expected (I tried it on `trunk` and modified `kafka.admin.AclCommandTest.scala` as well).
   I think we should 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] MINOR: Revert to Gradle 8.5 [kafka]

Posted by "dajac (via GitHub)" <gi...@apache.org>.
dajac commented on PR #15553:
URL: https://github.com/apache/kafka/pull/15553#issuecomment-2003168800

   @jlprat Thanks for the PR. It looks like the PR contains unwanted files.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org