You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2022/08/01 12:50:30 UTC
[GitHub] [lucene-jira-archive] mikemccand opened a new pull request, #105: #93: insert extra newline when we see markdown-styled quoting (>) without extra newline after
mikemccand opened a new pull request, #105:
URL: https://github.com/apache/lucene-jira-archive/pull/105
This just inserts another newline when it sees what looks like a MD quote attempt (`> `) in Jira.
So this:
```
> hello
wow you said hello to me!
```
becomes:
```
> hello
wow you said hello to me!
```
Rendered by GitHub:
This:
> hello
wow you said hello to me!
becomes this:
> hello
wow you said hello to me!
It's sort of odd that GitHub MD renders in this way.
I tested on the one issue I saw this on (LUCENE-2328). I'm also counting how often this applies (alters the text) across my `jira-dump` from ~3 weeks ago maybe.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-jira-archive] mocobeta commented on pull request #105: #93: insert extra newline when we see markdown-styled quoting (>) without extra newline after
Posted by GitBox <gi...@apache.org>.
mocobeta commented on PR #105:
URL: https://github.com/apache/lucene-jira-archive/pull/105#issuecomment-1202681349
@mikemccand can we just commit this in main and see the result? I can run full-import tomorrow for the next trial, and I think we can manually tweak old issues with inlined patches as I said in #106.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-jira-archive] mikemccand commented on pull request #105: #93: insert extra newline when we see markdown-styled quoting (>) without extra newline after
Posted by GitBox <gi...@apache.org>.
mikemccand commented on PR #105:
URL: https://github.com/apache/lucene-jira-archive/pull/105#issuecomment-1201214903
NOTE: please don't merge this yet -- it is buggy, screws up inlined diffs, etc. I am still iterating.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-jira-archive] mikemccand closed pull request #105: #93: insert extra newline when we see markdown-styled quoting (>) without extra newline after
Posted by GitBox <gi...@apache.org>.
mikemccand closed pull request #105: #93: insert extra newline when we see markdown-styled quoting (>) without extra newline after
URL: https://github.com/apache/lucene-jira-archive/pull/105
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-jira-archive] mikemccand commented on pull request #105: #93: insert extra newline when we see markdown-styled quoting (>) without extra newline after
Posted by GitBox <gi...@apache.org>.
mikemccand commented on PR #105:
URL: https://github.com/apache/lucene-jira-archive/pull/105#issuecomment-1203207723
Hi @mocobeta -- I think this PR is not worth it and too buggy to fix properly. I'll cancel it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org