You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@httpd.apache.org by Wilfredo Sanchez <ws...@apple.com> on 1998/06/25 04:25:24 UTC

[PATCH] Check for MAP_FILE is fishy

setup_shared_mem() in http_main.c has a line

  #if defined(MAP_ANON) || defined(MAP_FILE)

which is suspicious. If MAP_ANON is not defined, the following code breaks, regardless of whether MAP_FILE is defined. MAP_FILE isn't even used anywhere.  So I'm thinking that this is odd, and  
submit the following patch.

	-Fred
	Apple Computer, Core OS


Index: src/main/http_main.c
===================================================================
RCS file: /CVSRoot/CoreOS/Services/apache/apache/src/main/http_main.c,v
retrieving revision 1.3
diff -u -b -d -r1.3 http_main.c
--- http_main.c 1998/06/24 23:57:48     1.3
+++ http_main.c 1998/06/25 02:20:49
@@ -1595,7 +1595,7 @@
 {
     caddr_t m;

-#if defined(MAP_ANON) || defined(MAP_FILE)
+#if defined(MAP_ANON)
 /* BSD style */
 #ifdef CONVEXOS11
     /*