You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/07/14 12:45:06 UTC

[GitHub] [incubator-superset] villebro opened a new pull request #10312: fix(chart-data-api): fix csv and query result type and QueryObject schema

villebro opened a new pull request #10312:
URL: https://github.com/apache/incubator-superset/pull/10312


   ### SUMMARY
   The recent PR #10300 introduced a regression due to the error property not being populated in for all result types, namely CSV and Query. In addition, the data type for `timeseries_limit_metric` was incorrect, causing errors when limiting series in timeseries charts by a custom metric. 
   
   ### TEST PLAN
   CI + new tests for all fixed errors
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] villebro merged pull request #10312: fix(chart-data-api): fix csv and query result type and QueryObject schema

Posted by GitBox <gi...@apache.org>.
villebro merged pull request #10312:
URL: https://github.com/apache/incubator-superset/pull/10312


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org