You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/09/13 14:25:12 UTC

[GitHub] [airflow] jedcunningham commented on a diff in pull request #26357: Require dag_id arg for dags list-runs and list-jobs

jedcunningham commented on code in PR #26357:
URL: https://github.com/apache/airflow/pull/26357#discussion_r969699923


##########
airflow/cli/cli_parser.py:
##########
@@ -245,6 +245,9 @@ def string_lower_type(val):
     choices={ColorMode.ON, ColorMode.OFF, ColorMode.AUTO},
     default=ColorMode.AUTO,
 )
+ARG_DAG_ID_REQ_FLAG = Arg(

Review Comment:
   We do need a suffix, because `ARG_DAG_ID` already exists for the positional dag id arg. I thought this new name was better than `_OPT` since it isn't actually optional.
   
   https://github.com/apache/airflow/blob/73257628219e09c6cfd14b38d0aeed8b6e46a83c/airflow/cli/cli_parser.py#L177



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org