Re: [PR] Start thread accountant just before serving queries [pinot]

["jadami10 (via GitHub)" <gi...@apache.org>]

jadami10 commented on code in PR #16326:
URL: https://github.com/apache/pinot/pull/16326#discussion_r2200584977


##########
pinot-broker/src/main/java/org/apache/pinot/broker/broker/helix/BaseBrokerStarter.java:
##########
@@ -418,6 +418,7 @@ public void start()
     Tracing.ThreadAccountantOps.initializeThreadAccountant(
         _brokerConf.subset(CommonConstants.PINOT_QUERY_SCHEDULER_PREFIX), _instanceId,
         org.apache.pinot.spi.config.instance.InstanceType.BROKER);
+    Tracing.ThreadAccountantOps.startThreadAccountant();

Review Comment:
   any reason not to move this closer to the bottom as well? I imagine brokers are typically not doing as expensive work as servers, but who knows with large tables with 100k+ segments for example



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org