You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/03/31 12:07:19 UTC
[GitHub] [cloudstack-primate] utchoang opened a new pull request #273: [FIX]
VM Deployment Wizard Issues
utchoang opened a new pull request #273: [FIX] VM Deployment Wizard Issues
URL: https://github.com/apache/cloudstack-primate/pull/273
Open for https://github.com/apache/cloudstack-primate/issues/254
* [ ] Pod, cluster, host should be hidden for normal and domain admin user
* [ ] Listing of all items are not done by passing account/domainid, or zoneid (for example listing of networks, template, isos for zone; keypair, affiinity groups etc for account/domain)
* [ ] Add a way to filter templates by featured, community, shared, mine?
* [ ] Multiple listing of templates for the same zone? (multiple radios button)
* [ ] Add button to add network that can open the add network popup or add a router-link?
* [ ] User data not properly base64 encoded (check encoding?)
* [ ] Add support for processing min/max cpu/ram based on type of compute offering selected and custom disk offering
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] utchoang commented on issue #273: [FIX] VM
Deployment Wizard Issues
Posted by GitBox <gi...@apache.org>.
utchoang commented on issue #273: [FIX] VM Deployment Wizard Issues
URL: https://github.com/apache/cloudstack-primate/pull/273#issuecomment-607065859
@rhtyd cc @svenvogel I have some question:
1. Listing of all items are not done by passing account/domainid, or zoneid (for example listing of networks, template, isos for zone; keypair, affiinity groups etc for account/domain)
=> I've checked against the old UI and I think that only https://github.com/apache/cloudstack/blob/ef14e195c4b40be53466f081e4632547aa0cf43c/ui/scripts/instanceWizard.js#L755 is the place where listings of network is done by passing account/domainid. May I know if there is any other listing?
2. User data not properly base64 encoded (check encoding?)
=> I failed to find out which object needs to be base64 encoded. Could you please show me?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] utchoang commented on issue #273: [FIX] VM
Deployment Wizard Issues
Posted by GitBox <gi...@apache.org>.
utchoang commented on issue #273: [FIX] VM Deployment Wizard Issues
URL: https://github.com/apache/cloudstack-primate/pull/273#issuecomment-606995420
* Filter template/isos by featured, community, shared, self
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] utchoang commented on issue #273: [FIX] VM
Deployment Wizard Issues
Posted by GitBox <gi...@apache.org>.
utchoang commented on issue #273: [FIX] VM Deployment Wizard Issues
URL: https://github.com/apache/cloudstack-primate/pull/273#issuecomment-611390585
@shwstppr How can i create a new compute offering with iscustomized=true?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] shwstppr commented on issue #273: [FIX] VM
Deployment Wizard Issues
Posted by GitBox <gi...@apache.org>.
shwstppr commented on issue #273: [FIX] VM Deployment Wizard Issues
URL: https://github.com/apache/cloudstack-primate/pull/273#issuecomment-615041942
@rhtyd this can be reviewed, though this will be a big one. It fixes #254 and #265
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] shwstppr commented on issue #273: [FIX] VM
Deployment Wizard Issues
Posted by GitBox <gi...@apache.org>.
shwstppr commented on issue #273: [FIX] VM Deployment Wizard Issues
URL: https://github.com/apache/cloudstack-primate/pull/273#issuecomment-611392904
@utchoang if you are creating offering from UI then you can just select `Custom Constrained` or `Unconstrained` for offering type
Custom constrained should show sliders with range and unconstrained should show input boxes
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] shwstppr commented on issue #273: [FIX] VM
Deployment Wizard Issues
Posted by GitBox <gi...@apache.org>.
shwstppr commented on issue #273: [FIX] VM Deployment Wizard Issues
URL: https://github.com/apache/cloudstack-primate/pull/273#issuecomment-611927156
@utchoang please also have a look at https://github.com/apache/cloudstack-primate/pull/288/commits/b8f1253cbd4ffd96ba9b5fdda283f6b6556bf2ab if you can include it.
It fixes #265
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] utchoang commented on issue #273: [FIX] VM
Deployment Wizard Issues
Posted by GitBox <gi...@apache.org>.
utchoang commented on issue #273: [FIX] VM Deployment Wizard Issues
URL: https://github.com/apache/cloudstack-primate/pull/273#issuecomment-613308364
@shwstppr cc @rhtyd, @svenvogel Yes. I've completed. Please start for testing/review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] shwstppr commented on issue #273: [FIX] VM
Deployment Wizard Issues
Posted by GitBox <gi...@apache.org>.
shwstppr commented on issue #273: [FIX] VM Deployment Wizard Issues
URL: https://github.com/apache/cloudstack-primate/pull/273#issuecomment-610869380
@utchoang challenge I'm facing with my implementation is that whenever we show ui elements for custom offering it must be a required field but if I add required key for the field it loses v-model binding
Also, I'm not able to set initial values in main deployvm.vue field
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] utchoang commented on issue #273: [FIX] VM
Deployment Wizard Issues
Posted by GitBox <gi...@apache.org>.
utchoang commented on issue #273: [FIX] VM Deployment Wizard Issues
URL: https://github.com/apache/cloudstack-primate/pull/273#issuecomment-606994842
* hidden Pod, cluster, host should for Domain Admin & User
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] utchoang edited a comment on issue #273: [FIX]
VM Deployment Wizard Issues
Posted by GitBox <gi...@apache.org>.
utchoang edited a comment on issue #273: [FIX] VM Deployment Wizard Issues
URL: https://github.com/apache/cloudstack-primate/pull/273#issuecomment-607065859
Hi @rhtyd cc @svenvogel, I have some question:
1. Listing of all items are not done by passing account/domainid, or zoneid (for example listing of networks, template, isos for zone; keypair, affiinity groups etc for account/domain)
=> I've checked against the old UI and I think that only https://github.com/apache/cloudstack/blob/ef14e195c4b40be53466f081e4632547aa0cf43c/ui/scripts/instanceWizard.js#L755 is the place where listings of network is done by passing account/domainid. May I know if there is any other listing?
2. User data not properly base64 encoded (check encoding?)
=> I failed to find out which object needs to be base64 encoded. Could you please show me?
3. Add support for processing min/max cpu/ram based on type of compute offering selected and custom disk offering.
=> Will this support be shown in the instance info? Do you have any suggestions?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] utchoang commented on issue #273: [FIX] VM
Deployment Wizard Issues
Posted by GitBox <gi...@apache.org>.
utchoang commented on issue #273: [FIX] VM Deployment Wizard Issues
URL: https://github.com/apache/cloudstack-primate/pull/273#issuecomment-611293945
Hi @shwstppr Thanks for your response. With regards to supporting custom compute offering, do you need me to merge from your branch? I will check the required field and initial values again
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] shwstppr commented on issue #273: [FIX] VM
Deployment Wizard Issues
Posted by GitBox <gi...@apache.org>.
shwstppr commented on issue #273: [FIX] VM Deployment Wizard Issues
URL: https://github.com/apache/cloudstack-primate/pull/273#issuecomment-611419537
@utchoang thanks and also the https://github.com/apache/cloudstack-primate/pull/288/commits/f4663734fd7e2733f0ebfbbed1dc812518f326b5
Account, domain filtering should happen automatically based on logged in user so don't have to make changes for that
With these, I think we will be able to address all subitems from the original issue(last subitem to some extent)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] utchoang removed a comment on issue #273:
[FIX] VM Deployment Wizard Issues
Posted by GitBox <gi...@apache.org>.
utchoang removed a comment on issue #273: [FIX] VM Deployment Wizard Issues
URL: https://github.com/apache/cloudstack-primate/pull/273#issuecomment-611390585
@shwstppr How can i create a new compute offering with iscustomized=true?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] utchoang commented on issue #273: [FIX] VM
Deployment Wizard Issues
Posted by GitBox <gi...@apache.org>.
utchoang commented on issue #273: [FIX] VM Deployment Wizard Issues
URL: https://github.com/apache/cloudstack-primate/pull/273#issuecomment-613766752
@shwstppr I've fixed slider is showing cut on left. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] shwstppr commented on issue #273: [FIX] VM
Deployment Wizard Issues
Posted by GitBox <gi...@apache.org>.
shwstppr commented on issue #273: [FIX] VM Deployment Wizard Issues
URL: https://github.com/apache/cloudstack-primate/pull/273#issuecomment-613304789
@utchoang please update when you think the PR is ready for testing/review
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] utchoang commented on issue #273: [FIX] VM
Deployment Wizard Issues
Posted by GitBox <gi...@apache.org>.
utchoang commented on issue #273: [FIX] VM Deployment Wizard Issues
URL: https://github.com/apache/cloudstack-primate/pull/273#issuecomment-607008679
* Add button help for add network
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] utchoang edited a comment on issue #273: [FIX]
VM Deployment Wizard Issues
Posted by GitBox <gi...@apache.org>.
utchoang edited a comment on issue #273: [FIX] VM Deployment Wizard Issues
URL: https://github.com/apache/cloudstack-primate/pull/273#issuecomment-607065859
@rhtyd cc @svenvogel I have some question:
1. Listing of all items are not done by passing account/domainid, or zoneid (for example listing of networks, template, isos for zone; keypair, affiinity groups etc for account/domain)
=> I've checked against the old UI and I think that only https://github.com/apache/cloudstack/blob/ef14e195c4b40be53466f081e4632547aa0cf43c/ui/scripts/instanceWizard.js#L755 is the place where listings of network is done by passing account/domainid. May I know if there is any other listing?
2. User data not properly base64 encoded (check encoding?)
=> I failed to find out which object needs to be base64 encoded. Could you please show me?
3. Add support for processing min/max cpu/ram based on type of compute offering selected and custom disk offering.
=> Will this support be shown in the instance info? Do you have any suggestions?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] shwstppr commented on issue #273: [FIX] VM
Deployment Wizard Issues
Posted by GitBox <gi...@apache.org>.
shwstppr commented on issue #273: [FIX] VM Deployment Wizard Issues
URL: https://github.com/apache/cloudstack-primate/pull/273#issuecomment-610868147
@utchoang for supporting custom compute offering maybe you can use a prettier version of UI I tried to implement here https://github.com/apache/cloudstack-primate/pull/288
There are 3 types of compute offerings:
- fixed - we don't show any additional ui for them
- custom constrained - we show cpu and memory sliders
- custom unconstrained - we show text input for cpu cores, speed and memory
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] shwstppr commented on issue #273: [FIX] VM
Deployment Wizard Issues
Posted by GitBox <gi...@apache.org>.
shwstppr commented on issue #273: [FIX] VM Deployment Wizard Issues
URL: https://github.com/apache/cloudstack-primate/pull/273#issuecomment-611354800
@utchoang sure you can pick those changes. See if that required field condition and the initial values without mobing slider can be fixed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] shwstppr commented on issue #273: [FIX] VM
Deployment Wizard Issues
Posted by GitBox <gi...@apache.org>.
shwstppr commented on issue #273: [FIX] VM Deployment Wizard Issues
URL: https://github.com/apache/cloudstack-primate/pull/273#issuecomment-611406504
@utchoang To fix userdata issue https://github.com/apache/cloudstack-primate/pull/288/commits/bc905001d46bc3a27b7c0011117b4924f0501efe
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] utchoang commented on issue #273: [FIX] VM
Deployment Wizard Issues
Posted by GitBox <gi...@apache.org>.
utchoang commented on issue #273: [FIX] VM Deployment Wizard Issues
URL: https://github.com/apache/cloudstack-primate/pull/273#issuecomment-609627940
@rhtyd Can you give me a few comments?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] utchoang commented on issue #273: [FIX] VM
Deployment Wizard Issues
Posted by GitBox <gi...@apache.org>.
utchoang commented on issue #273: [FIX] VM Deployment Wizard Issues
URL: https://github.com/apache/cloudstack-primate/pull/273#issuecomment-611412843
@shwstppr OK. I'll merge it later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] utchoang edited a comment on issue #273: [FIX]
VM Deployment Wizard Issues
Posted by GitBox <gi...@apache.org>.
utchoang edited a comment on issue #273: [FIX] VM Deployment Wizard Issues
URL: https://github.com/apache/cloudstack-primate/pull/273#issuecomment-607065859
@rhtyd cc @svenvogel I have some question:
1. Listing of all items are not done by passing account/domainid, or zoneid (for example listing of networks, template, isos for zone; keypair, affiinity groups etc for account/domain)
> I've checked against the old UI and I think that only https://github.com/apache/cloudstack/blob/ef14e195c4b40be53466f081e4632547aa0cf43c/ui/scripts/instanceWizard.js#L755 is the place where listings of network is done by passing account/domainid. May I know if there is any other listing?
2. User data not properly base64 encoded (check encoding?)
> I failed to find out which object needs to be base64 encoded. Could you please show me?
3. Add support for processing min/max cpu/ram based on type of compute offering selected and custom disk offering.
> Will this support be shown in the instance info? Do you have any suggestions?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] utchoang edited a comment on issue #273: [FIX]
VM Deployment Wizard Issues
Posted by GitBox <gi...@apache.org>.
utchoang edited a comment on issue #273: [FIX] VM Deployment Wizard Issues
URL: https://github.com/apache/cloudstack-primate/pull/273#issuecomment-607065859
@rhtyd cc @svenvogel I have some question:
1. Listing of all items are not done by passing account/domainid, or zoneid (for example listing of networks, template, isos for zone; keypair, affiinity groups etc for account/domain)
=> I've checked against the old UI and I think that only https://github.com/apache/cloudstack/blob/ef14e195c4b40be53466f081e4632547aa0cf43c/ui/scripts/instanceWizard.js#L755 is the place where listings of network is done by passing account/domainid. May I know if there is any other listing?
2. User data not properly base64 encoded (check encoding?)
=> I failed to find out which object needs to be base64 encoded. Could you please show me?
3. Add support for processing min/max cpu/ram based on type of compute offering selected and custom disk offering.
=> Will this support be shown in the instance info? Do you have any suggestions?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services