You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/02/08 08:59:37 UTC
[GitHub] [ozone] adoroszlai opened a new pull request #1909: HDDS-4801. Skip coverage check for PRs and in forks
adoroszlai opened a new pull request #1909:
URL: https://github.com/apache/ozone/pull/1909
## What changes were proposed in this pull request?
Currently _coverage_ CI check:
1. calculates combined test coverage
2. uploads it to Sonar only for Apache Ozone repo and only for builds on push/schedule
3. stores combined coverage in GitHub Actions artifact
Thus for PR in Apache Ozone and for all builds in forks, it only stores coverage in the artifact. These expire in 30 days and I don't think anybody really checks them manually.
I propose to completely skip _coverage_ check for PRs and in forks, instead of only skipping upload to Sonar. This would save ~12 minutes for such builds.
https://issues.apache.org/jira/browse/HDDS-4801
## How was this patch tested?
https://github.com/adoroszlai/hadoop-ozone/runs/1849668371
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] elek merged pull request #1909: HDDS-4801. Skip coverage check for PRs and in forks
Posted by GitBox <gi...@apache.org>.
elek merged pull request #1909:
URL: https://github.com/apache/ozone/pull/1909
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on pull request #1909: HDDS-4801. Skip coverage check for PRs and in forks
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on pull request #1909:
URL: https://github.com/apache/ozone/pull/1909#issuecomment-775825827
Thanks @elek for reviewing and committing it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on pull request #1909: HDDS-4801. Skip coverage check for PRs and in forks
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on pull request #1909:
URL: https://github.com/apache/ozone/pull/1909#issuecomment-775825670
> it would be easy to create a Github actions scripts to compare the coverage artifacts between PR and master and create a report.
That's also what Codecov was supposed to do, but it had been disabled earlier due to unreliability.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org