You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by guoxiaolongzte <gi...@git.apache.org> on 2017/05/11 11:08:58 UTC
[GitHub] spark pull request #17952: [SPARK-20705][WEB-UI]The sort function can not be...
GitHub user guoxiaolongzte opened a pull request:
https://github.com/apache/spark/pull/17952
[SPARK-20705][WEB-UI]The sort function can not be used in the master page when you use Firefox or Google Chrome.
## What changes were proposed in this pull request?
When you open the master page, the console of Firefox or Google Chrome is wrong, when you use Firefox or Google Chrome.But The IE is no problem.
e.g.
My Firefox version is 48.0.2.
My Google Chrome version is 49.0.2623.75 m.
'GetAttribute' should be replaced by 'getAttributeNode', because it will generate browser compatibility issues.
## How was this patch tested?
manual tests
Please review http://spark.apache.org/contributing.html before opening a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/guoxiaolongzte/spark SPARK-20705
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/17952.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #17952
----
commit d383efba12c66addb17006dea107bb0421d50bc3
Author: 郭小龙 10207633 <gu...@zte.com.cn>
Date: 2017-03-31T13:57:09Z
[SPARK-20177]Document about compression way has some little detail changes.
commit 3059013e9d2aec76def14eb314b6761bea0e7ca0
Author: 郭小龙 10207633 <gu...@zte.com.cn>
Date: 2017-04-01T01:38:02Z
[SPARK-20177] event log add a space
commit 555cef88fe09134ac98fd0ad056121c7df2539aa
Author: guoxiaolongzte <gu...@zte.com.cn>
Date: 2017-04-02T00:16:08Z
'/applications/[app-id]/jobs' in rest api,status should be [running|succeeded|failed|unknown]
commit 46bb1ad3ddd9fb55b5607ac4f20213a90186cfe9
Author: 郭小龙 10207633 <gu...@zte.com.cn>
Date: 2017-04-05T03:16:50Z
Merge branch 'master' of https://github.com/apache/spark into SPARK-20177
commit 0efb0dd9e404229cce638fe3fb0c966276784df7
Author: 郭小龙 10207633 <gu...@zte.com.cn>
Date: 2017-04-05T03:47:53Z
[SPARK-20218]'/applications/[app-id]/stages' in REST API,add description.
commit 0e37fdeee28e31fc97436dabd001d3c85c5a7794
Author: 郭小龙 10207633 <gu...@zte.com.cn>
Date: 2017-04-05T05:22:54Z
[SPARK-20218] '/applications/[app-id]/stages/[stage-id]' in REST API,remove redundant description.
commit 52641bb01e55b48bd9e8579fea217439d14c7dc7
Author: 郭小龙 10207633 <gu...@zte.com.cn>
Date: 2017-04-07T06:24:58Z
Merge branch 'SPARK-20218'
commit d3977c9cab0722d279e3fae7aacbd4eb944c22f6
Author: 郭小龙 10207633 <gu...@zte.com.cn>
Date: 2017-04-08T07:13:02Z
Merge branch 'master' of https://github.com/apache/spark
commit 137b90e5a85cde7e9b904b3e5ea0bb52518c4716
Author: 郭小龙 10207633 <gu...@zte.com.cn>
Date: 2017-04-10T05:13:40Z
Merge branch 'master' of https://github.com/apache/spark
commit 0fe5865b8022aeacdb2d194699b990d8467f7a0a
Author: 郭小龙 10207633 <gu...@zte.com.cn>
Date: 2017-04-10T10:25:22Z
Merge branch 'SPARK-20190' of https://github.com/guoxiaolongzte/spark
commit cf6f42ac84466960f2232c025b8faeb5d7378fe1
Author: 郭小龙 10207633 <gu...@zte.com.cn>
Date: 2017-04-10T10:26:27Z
Merge branch 'master' of https://github.com/apache/spark
commit 685cd6b6e3799c7be65674b2670159ba725f0b8f
Author: 郭小龙 10207633 <gu...@zte.com.cn>
Date: 2017-04-14T01:12:41Z
Merge branch 'master' of https://github.com/apache/spark
commit c716a9231e9ab117d2b03ba67a1c8903d8d9da93
Author: guoxiaolong <gu...@zte.com.cn>
Date: 2017-04-17T06:57:21Z
Merge branch 'master' of https://github.com/apache/spark
commit 679cec36a968fbf995b567ca5f6f8cbd8e32673f
Author: guoxiaolong <gu...@zte.com.cn>
Date: 2017-04-19T07:20:08Z
Merge branch 'master' of https://github.com/apache/spark
commit 3c9387af84a8f39cf8c1ce19e15de99dfcaf0ca5
Author: guoxiaolong <gu...@zte.com.cn>
Date: 2017-04-19T08:15:26Z
Merge branch 'master' of https://github.com/apache/spark
commit cb71f4462a0889cbb0843875b1e4cf14bcb0d020
Author: guoxiaolong <gu...@zte.com.cn>
Date: 2017-04-20T05:52:06Z
Merge branch 'master' of https://github.com/apache/spark
commit ce92a7415a2026f5bf909820110a13750a0949e1
Author: guoxiaolong <gu...@zte.com.cn>
Date: 2017-04-21T05:21:48Z
Merge branch 'master' of https://github.com/apache/spark
commit dd64342206041a8c3a282459e5f2b898dc558d89
Author: guoxiaolong <gu...@zte.com.cn>
Date: 2017-04-21T08:44:25Z
Merge branch 'master' of https://github.com/apache/spark
commit bffd2bd00c6b0e20313756e133adca4c97707c67
Author: guoxiaolong <gu...@zte.com.cn>
Date: 2017-04-28T01:36:29Z
Merge branch 'master' of https://github.com/apache/spark
commit 588d42a382345a071532ace1eab5457911f6aa46
Author: guoxiaolong <gu...@zte.com.cn>
Date: 2017-04-28T05:02:36Z
Merge branch 'master' of https://github.com/apache/spark
commit 4bbeee1231275d1afa0775dbb61fcc5817f6e57c
Author: guoxiaolong <gu...@zte.com.cn>
Date: 2017-05-02T02:30:52Z
Merge branch 'master' of https://github.com/apache/spark
commit 362e5ad12bfe013a7780d81b5067c2ff644efa05
Author: guoxiaolong <gu...@zte.com.cn>
Date: 2017-05-03T06:47:54Z
Merge branch 'master' of https://github.com/apache/spark
commit 4ed5e00e784ab3c31e1ba69f06fd64520c9d32e4
Author: guoxiaolong <gu...@zte.com.cn>
Date: 2017-05-11T06:48:27Z
增加代码
commit d871e01860de20502ecdda26187b2b47cd07aca0
Author: guoxiaolong <gu...@zte.com.cn>
Date: 2017-05-11T06:50:50Z
Merge branch 'master' of https://github.com/apache/spark
commit a1f775963e8c9113c3c6ab404c17c6e4385138bd
Author: guoxiaolong <gu...@zte.com.cn>
Date: 2017-05-11T10:52:08Z
Merge branch 'master' of https://github.com/apache/spark
commit 0b403607a6ba6bc819dbd6a2b552bcf72a7399f7
Author: guoxiaolong <gu...@zte.com.cn>
Date: 2017-05-11T10:54:36Z
[SPARK-20705]The sort function can not be used in the master page when you use Firefox or Google Chrome.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17952: [SPARK-20705][WEB-UI]The sort function can not be used i...
Posted by guoxiaolongzte <gi...@git.apache.org>.
Github user guoxiaolongzte commented on the issue:
https://github.com/apache/spark/pull/17952
@srowen @HyukjinKwon @ajbozarth
Help to review the code,thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17952: [SPARK-20705][WEB-UI]The sort function can not be used i...
Posted by ajbozarth <gi...@git.apache.org>.
Github user ajbozarth commented on the issue:
https://github.com/apache/spark/pull/17952
@srowen when I looked at Spark's copy of sorttable.js we have already edited a couple lines, so if we updated we would have to address that. Without another reason I'd say just adding this is probably ok for now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17952: [SPARK-20705][WEB-UI]The sort function can not be used i...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/17952
Should we just update to a later version of sorttable.js entirely?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17952: [SPARK-20705][WEB-UI]The sort function can not be used i...
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/17952
Also, not really a big deal but probably, it would be nicer if this branch `SPARK-20705` is rebased and synced to the master so that it only has few (or single) commits. It looks a bit messy.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17952: [SPARK-20705][WEB-UI]The sort function can not be used i...
Posted by guoxiaolongzte <gi...@git.apache.org>.
Github user guoxiaolongzte commented on the issue:
https://github.com/apache/spark/pull/17952
Obviously you said it was right. I have modified as requested. I have been manually tested, it is ok.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17952: [SPARK-20705][WEB-UI]The sort function can not be used i...
Posted by ajbozarth <gi...@git.apache.org>.
Github user ajbozarth commented on the issue:
https://github.com/apache/spark/pull/17952
This seems to have been fixed in a later version of sorttable.js (https://github.com/stuartlangridge/sorttable/pull/9). If you could use that implementation instead I'd prefer the simpler change.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17952: [SPARK-20705][WEB-UI]The sort function can not be used i...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/17952
Merged to master/2.2/2.1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17952: [SPARK-20705][WEB-UI]The sort function can not be used i...
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/17952
I am not used to UI code path but just while I am here I think this PR should explain why it happens and how the current change fixes it. I am willing to help reproduce this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #17952: [SPARK-20705][WEB-UI]The sort function can not be...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/17952
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17952: [SPARK-20705][WEB-UI]The sort function can not be used i...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17952
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org