You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2016/03/17 23:00:18 UTC
Review Request 44985: Fix the broken ProvisionerDockerPullerTest on
Centos7.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44985/
-----------------------------------------------------------
Review request for mesos, Bernd Mathiske and Joseph Wu.
Bugs: MESOS-4810
https://issues.apache.org/jira/browse/MESOS-4810
Repository: mesos
Description
-------
Fix the broken ProvisionerDockerPullerTest on Centos7.
Diffs
-----
src/tests/containerizer/provisioner_docker_tests.cpp 72d4c3e8756e1bea2332db20654af0a5fbb124f1
src/tests/mesos.hpp 93b9340d94d91663283fe5df5ad9febe69ffd2a3
Diff: https://reviews.apache.org/r/44985/diff/
Testing
-------
sudo make check.
Verified in our CI.
Thanks,
Jie Yu
Re: Review Request 44985: Fix the broken ProvisionerDockerPullerTest
on Centos7.
Posted by Jie Yu <yu...@gmail.com>.
> On March 17, 2016, 10:12 p.m., Gilbert Song wrote:
> > src/tests/containerizer/provisioner_docker_tests.cpp, line 401
> > <https://reviews.apache.org/r/44985/diff/1/?file=1303146#file1303146line401>
> >
> > `_NonShellCommand`?
I'll rename it to SimpleCommand.
- Jie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44985/#review124106
-----------------------------------------------------------
On March 17, 2016, 10 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44985/
> -----------------------------------------------------------
>
> (Updated March 17, 2016, 10 p.m.)
>
>
> Review request for mesos, Bernd Mathiske and Joseph Wu.
>
>
> Bugs: MESOS-4810
> https://issues.apache.org/jira/browse/MESOS-4810
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fix the broken ProvisionerDockerPullerTest on Centos7.
>
> See the ticket for root cause.
>
>
> Diffs
> -----
>
> src/tests/containerizer/provisioner_docker_tests.cpp 72d4c3e8756e1bea2332db20654af0a5fbb124f1
> src/tests/mesos.hpp 93b9340d94d91663283fe5df5ad9febe69ffd2a3
>
> Diff: https://reviews.apache.org/r/44985/diff/
>
>
> Testing
> -------
>
> sudo make check.
>
> Verified in our CI.
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 44985: Fix the broken ProvisionerDockerPullerTest
on Centos7.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44985/#review124106
-----------------------------------------------------------
Fix it, then Ship it!
src/tests/containerizer/provisioner_docker_tests.cpp (line 401)
<https://reviews.apache.org/r/44985/#comment186472>
`_NonShellCommand`?
- Gilbert Song
On March 17, 2016, 3 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44985/
> -----------------------------------------------------------
>
> (Updated March 17, 2016, 3 p.m.)
>
>
> Review request for mesos, Bernd Mathiske and Joseph Wu.
>
>
> Bugs: MESOS-4810
> https://issues.apache.org/jira/browse/MESOS-4810
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fix the broken ProvisionerDockerPullerTest on Centos7.
>
> See the ticket for root cause.
>
>
> Diffs
> -----
>
> src/tests/containerizer/provisioner_docker_tests.cpp 72d4c3e8756e1bea2332db20654af0a5fbb124f1
> src/tests/mesos.hpp 93b9340d94d91663283fe5df5ad9febe69ffd2a3
>
> Diff: https://reviews.apache.org/r/44985/diff/
>
>
> Testing
> -------
>
> sudo make check.
>
> Verified in our CI.
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 44985: Fix the broken ProvisionerDockerPullerTest
on Centos7.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44985/
-----------------------------------------------------------
(Updated March 17, 2016, 10 p.m.)
Review request for mesos, Bernd Mathiske and Joseph Wu.
Bugs: MESOS-4810
https://issues.apache.org/jira/browse/MESOS-4810
Repository: mesos
Description (updated)
-------
Fix the broken ProvisionerDockerPullerTest on Centos7.
See the ticket for root cause.
Diffs
-----
src/tests/containerizer/provisioner_docker_tests.cpp 72d4c3e8756e1bea2332db20654af0a5fbb124f1
src/tests/mesos.hpp 93b9340d94d91663283fe5df5ad9febe69ffd2a3
Diff: https://reviews.apache.org/r/44985/diff/
Testing
-------
sudo make check.
Verified in our CI.
Thanks,
Jie Yu