You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/11/11 02:24:58 UTC
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #34547: [SPARK-37272][TESTS] Add `ExtendedRocksDBTest` and disable RocksDB tests on Apple Silicon
dongjoon-hyun commented on a change in pull request #34547:
URL: https://github.com/apache/spark/pull/34547#discussion_r747154538
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamingSessionWindowSuite.scala
##########
@@ -43,12 +43,17 @@ class StreamingSessionWindowSuite extends StreamTest
val mergingSessionOptions = Seq(true, false).map { value =>
(SQLConf.STREAMING_SESSION_WINDOW_MERGE_SESSIONS_IN_LOCAL_PARTITION.key, value)
}
- val providerOptions = Seq(
+ var providerOptions = Seq(
classOf[HDFSBackedStateStoreProvider].getCanonicalName,
classOf[RocksDBStateStoreProvider].getCanonicalName
).map { value =>
(SQLConf.STATE_STORE_PROVIDER_CLASS.key, value.stripSuffix("$"))
}
+ // RocksDB doesn't support Apple Silicon yet
Review comment:
Yes, definitely. I'm currently working on this area and will do the similar with LevelDB.
I'll document it both together.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org