You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by johnament <gi...@git.apache.org> on 2015/06/04 19:26:12 UTC

[GitHub] activemq-artemis pull request: Artemis 120

GitHub user johnament opened a pull request:

    https://github.com/apache/activemq-artemis/pull/18

    Artemis 120

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/johnament/activemq-artemis ARTEMIS-120

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/18.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #18
    
----
commit daadc39829466dfaa52acde8f9fc0c622202c405
Author: John D. Ament <jo...@apache.org>
Date:   2015-06-04T02:10:51Z

    ARTEMIS-119 Upgraded to Jetty 9.2.

commit 83e9ba418c8793b6475221fd5346b856a973cc57
Author: John D. Ament <jo...@apache.org>
Date:   2015-06-04T13:33:41Z

    ARTEMIS-119 Changed dependency to use Tomcat Servlet API 3.1.

commit 2f644bc42c7f54d60339c5039560a5b4ae43815a
Author: John D. Ament <jo...@apache.org>
Date:   2015-06-04T13:53:49Z

    ARTEMIS-119 Added proper tests for webserver component startup checks.

commit f3b1523cab53c83db04f48d8a82ff8eca288ebf9
Author: John D. Ament <jo...@apache.org>
Date:   2015-06-04T17:23:30Z

    ARTEMIS-120 Updated readme to clarify how to run the test suite.

commit 79ec769d4bcefd4071a89147cd544c25245bb4a5
Author: John D. Ament <jo...@apache.org>
Date:   2015-06-04T17:24:02Z

    ARTEMIS-120 Downgraded netty.

commit ad48792b24deb02eb0e644a368ef35ea709c1511
Author: John D. Ament <jo...@apache.org>
Date:   2015-06-04T17:25:51Z

    Merge branch 'master' of https://github.com/apache/activemq-artemis into ARTEMIS-120
    
    Conflicts:
    	pom.xml

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request: Artemis 120

Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the pull request:

    https://github.com/apache/activemq-artemis/pull/18#issuecomment-109065071
  
    The issue is something changed on netty-buffer between 4.0.27 and 4.0.28. It seems that compositive buffers are not self expanding now and the write is failing for messages.
    
    It seems an easy fix but I wanted to pin point exactly why.
    
    
    I'm going to be off on this Friday but i could work on this when I'm back next week... 
    
    if you like you may look at this... it seems related to the allocation of the messages.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request: Artemis 120

Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the pull request:

    https://github.com/apache/activemq-artemis/pull/18#issuecomment-110212576
  
    Can you please close this PR. I have just submitted https://github.com/apache/activemq-artemis/pull/20 which the the upgrade again.
    
    I've fixed the issue and found the culprit change from netty.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request: Artemis 120

Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the pull request:

    https://github.com/apache/activemq-artemis/pull/18#issuecomment-109003209
  
    Please rebase your branch with:
    
    ```sh
    $ git remote add upstream https://github.com/apache/activemq-artemis.git
    $ git pull --rebase upstream master
    $ git push origin ARTEMIS-120 -f
    ```
    
    
    You have a merge commit as part of your PR and you would have conflicts if this was merged.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request: Artemis 120

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/activemq-artemis/pull/18


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---