[GitHub] [jackrabbit-filevault] kwin commented on a diff in pull request #277: JCRVLT-689: bad description of "isStrict" flag

["kwin (via GitHub)" <gi...@apache.org>]

kwin commented on code in PR #277:
URL: https://github.com/apache/jackrabbit-filevault/pull/277#discussion_r1109853538


##########
vault-core/src/main/java/org/apache/jackrabbit/vault/packaging/impl/PackagingImpl.java:
##########
@@ -101,7 +101,7 @@ public PackagingImpl() {
         @AttributeDefinition(name = "Allowed Users for Package Installation", description = "The authorizable ids or principal names which are allowed to install packages with the 'requireRoot' flag (in addition to 'admin', 'administrators' and 'system'")
         String[] authIdsForRootInstallation();
 
-        @AttributeDefinition(name = "Default Strict Mode", description = "The default value for strict imports. In strict mode every import failure leads to an exception, while with strict mode those failures are just logged but the import continues in a best effort manner")
+        @AttributeDefinition(name = "Default Strict Mode", description = "The default value for strict imports. In strict mode every import failure leads to an exception, while without strict mode those failures are just logged but the import continues in a best effort manner")

Review Comment:
   ```suggestion
           @AttributeDefinition(name = "Default Strict Mode", description = "The default value for imports. In strict mode every import failure leads to an exception, while without strict mode those failures are just logged but the import continues in a best effort manner")
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org