You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "hjtran (via GitHub)" <gi...@apache.org> on 2023/07/28 19:07:59 UTC

[GitHub] [beam] hjtran commented on a diff in pull request #27512: Remove more legacy Runner v1 cruft.

hjtran commented on code in PR #27512:
URL: https://github.com/apache/beam/pull/27512#discussion_r1277988523


##########
sdks/python/apache_beam/runners/runner.py:
##########
@@ -158,181 +177,39 @@ def run_pipeline(
     # type: (...) -> PipelineResult
 
     """Execute the entire pipeline or the sub-DAG reachable from a node.
-
-    Runners should override this method.
     """
-    raise NotImplementedError
+    pipeline.visit(
+        group_by_key_input_visitor(
+            not options.view_as(TypeOptions).allow_non_deterministic_key_coders)
+    )
+
+    # TODO: https://github.com/apache/beam/issues/19168
+    # portable runner specific default
+    if options.view_as(SetupOptions).sdk_location == 'default':
+      options.view_as(SetupOptions).sdk_location = 'container'
+
+    return self.run_full_pipeline(

Review Comment:
   Sorry for crashing, but I got tripped up by this already when writing code on top of these changes. I think any of `run_portable_pipeline` / `run_pipeline_proto` / `run_pipeline_from_proto` would be a bit clearer



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org