You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by GitBox <gi...@apache.org> on 2023/01/11 02:22:06 UTC

[GitHub] [incubator-uniffle] jerqi commented on a diff in pull request #467: [ISSUE-289] Support annotations

jerqi commented on code in PR #467:
URL: https://github.com/apache/incubator-uniffle/pull/467#discussion_r1066515130


##########
deploy/kubernetes/operator/api/uniffle/v1alpha1/remoteshuffleservice_types.go:
##########
@@ -200,6 +200,11 @@ type RSSPodSpec struct {
 	// LogHostPath represents host path used to save logs of shuffle servers.
 	// +optional
 	LogHostPath string `json:"logHostPath,omitempty"`
+
+	//Annotations is an unstructured key value map stored with a resource that may be

Review Comment:
   There should be a blank followed by `//`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org