[GitHub] [hudi] danny0405 commented on a diff in pull request #6917: [HUDI-5005] Flink stream write reuse abort instant will lead to coordinator delete file not right.

[GitBox <gi...@apache.org>]

danny0405 commented on code in PR #6917:
URL: https://github.com/apache/hudi/pull/6917#discussion_r991882732


##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/meta/CkpMetadata.java:
##########
@@ -175,8 +175,8 @@ public String lastPendingInstant() {
     load();
     if (this.messages.size() > 0) {
       CkpMessage ckpMsg = this.messages.get(this.messages.size() - 1);
-      // consider 'aborted' as pending too to reuse the instant
-      if (!ckpMsg.isComplete()) {
+      // should not consider 'aborted', which will lead writer instant not consistent with coordinator
+      if (ckpMsg.isInflight()) {
         return ckpMsg.getInstant();

Review Comment:
   We never abort a checkpoint in master code now, can you double check this logic again ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org