You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "bbovenzi (via GitHub)" <gi...@apache.org> on 2025/05/28 22:05:01 UTC
[PR] Migrate dags list plaintext to translate files [airflow]
bbovenzi opened a new pull request, #51181:
URL: https://github.com/apache/airflow/pull/51181
Continued work on [#50861](https://github.com/apache/airflow/issues/50861)
Replace all plain text on the Dags List page to english translation files.
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Migrate dags list plaintext to translate files [airflow]
Posted by "RoyLee1224 (via GitHub)" <gi...@apache.org>.
RoyLee1224 commented on code in PR #51181:
URL: https://github.com/apache/airflow/pull/51181#discussion_r2113679463
##########
airflow-core/src/airflow/ui/src/i18n/locales/en/dags.json:
##########
@@ -0,0 +1,52 @@
+{
+ "list": {
+ "searchPlaceholder": "Search Dags",
Review Comment:
While testing, I noticed that the "Advanced Search" don't seem to be translated, maybe we should add it to dags.json and modify the SearchBar.tsx

##########
airflow-core/src/airflow/ui/src/i18n/locales/en/dags.json:
##########
@@ -0,0 +1,52 @@
+{
+ "list": {
+ "searchPlaceholder": "Search Dags",
Review Comment:
```suggestion
"searchPlaceholder": "Search Dags",
"advancedSearch": "Advanced Search",
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Migrate dags list plaintext to translate files [airflow]
Posted by "RoyLee1224 (via GitHub)" <gi...@apache.org>.
RoyLee1224 commented on PR #51181:
URL: https://github.com/apache/airflow/pull/51181#issuecomment-2918531974
Hi, @bbovenzi
I'd like to help on this issue. Could you assign it to me?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Migrate dags list plaintext to translate files [airflow]
Posted by "bbovenzi (via GitHub)" <gi...@apache.org>.
bbovenzi merged PR #51181:
URL: https://github.com/apache/airflow/pull/51181
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org