You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2020/09/12 03:37:35 UTC
[GitHub] [incubator-dolphinscheduler] 597365581 opened a new pull request #3728: process definition need to support parallel or serial choose. and parallel mode support wait queue length
597365581 opened a new pull request #3728:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3728
process definition need to support parallel or serial choose.
if is serial in dispatch，need to the previous process_instance execute complete，next process_instance can to run。
流程实例中支持并发并行和串行。 如果是串行处理，需要等待上一个流程实例运行完成后，下一个流程实例才可以运行。
如果是并行处理，则不需要。当然在串行的时候，也可以设置串行等待的队列的长度
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] yangyichao-mango edited a comment on pull request #3728: [Feature][process_definition] process definition need to support parallel or serial choose. and parallel mode support wait queue length
Posted by GitBox <gi...@apache.org>.
yangyichao-mango edited a comment on pull request #3728:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3728#issuecomment-691455011
> @yangyichao-mango @break60 unit test fail because in database, table t_ds_process_definition need add cloum:is_parallel,serial_command_lengh. sql script need to exec in database.
If this pr need to change the database schema, you need to send a mail to mailing list to discuss this feature before submit a pr.
You can send a mail about why need to add the column and the necessity about adding the new column to `dev@dolphinscheduler.apache.org`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] xingchun-chen commented on pull request #3728: [Feature][process_definition] process definition need to support parallel or serial choose. and parallel mode support wait queue length
Posted by GitBox <gi...@apache.org>.
xingchun-chen commented on pull request #3728:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3728#issuecomment-691796212
1.e2e failed because of the addition of the serial field, you need to change the 8 of the following elements to 9
2.the database fields are only changed the upgrade, there isn't add 2 fields in the create table statement
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] 597365581 closed pull request #3728: [Feature][process_definition] process definition need to support parallel or serial choose. and parallel mode support wait queue length
Posted by GitBox <gi...@apache.org>.
597365581 closed pull request #3728:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3728
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] gabrywu commented on a change in pull request #3728: [Feature][process_definition] process definition need to support parallel or serial choose. and parallel mode support wait queue length
Posted by GitBox <gi...@apache.org>.
gabrywu commented on a change in pull request #3728:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3728#discussion_r487745578
##########
File path: sql/upgrade/1.3.3_schema/mysql/dolphinscheduler_ddl.sql
##########
@@ -112,4 +112,42 @@ CALL uc_dolphin_T_t_ds_resources_un();
DROP PROCEDURE IF EXISTS uc_dolphin_T_t_ds_resources_un;
+drop PROCEDURE if EXISTS uc_dolphin_T_t_ds_process_definition_A_is_parallel;
+delimiter d//
+CREATE PROCEDURE uc_dolphin_T_t_ds_process_definition_A_is_parallel()
+ BEGIN
+ IF NOT EXISTS (SELECT 1 FROM information_schema.COLUMNS
+ WHERE TABLE_NAME='t_ds_process_definition'
+ AND TABLE_SCHEMA=(SELECT DATABASE())
+ AND COLUMN_NAME ='is_parallel')
+ THEN
+ alter table t_ds_process_definition add is_parallel tinyint default '1' comment '0:serial,1:parallel';
Review comment:
why we should use the procedure to add one column?
##########
File path: dolphinscheduler-dao/src/main/resources/org/apache/dolphinscheduler/dao/mapper/CommandMapper.xml
##########
@@ -19,18 +19,30 @@
<!DOCTYPE mapper PUBLIC "-//mybatis.org//DTD Mapper 3.0//EN" "http://mybatis.org/dtd/mybatis-3-mapper.dtd" >
<mapper namespace="org.apache.dolphinscheduler.dao.mapper.CommandMapper">
<select id="getOneToRun" resultType="org.apache.dolphinscheduler.dao.entity.Command">
- select command.* from t_ds_command command
- join t_ds_process_definition definition on command.process_definition_id = definition.id
- where definition.release_state = 1 AND definition.flag = 1
- order by command.update_time asc
- limit 1
+ select * from
Review comment:
so complex the SQL is, could you simply it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] 597365581 commented on pull request #3728: [Feature][process_definition] process definition need to support parallel or serial choose. and parallel mode support wait queue length
Posted by GitBox <gi...@apache.org>.
597365581 commented on pull request #3728:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3728#issuecomment-692442122
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] 597365581 commented on pull request #3728: [Feature][process_definition] process definition need to support parallel or serial choose. and parallel mode support wait queue length
Posted by GitBox <gi...@apache.org>.
597365581 commented on pull request #3728:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3728#issuecomment-691451951
> Please resolve the ut check error.
unit test fail because in database, table t_ds_process_definition need add cloum:is_parallel,serial_command_lengh. sql script need to exec.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] 597365581 commented on pull request #3728: [Feature][process_definition] process definition need to support parallel or serial choose. and parallel mode support wait queue length
Posted by GitBox <gi...@apache.org>.
597365581 commented on pull request #3728:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3728#issuecomment-691454973
our company need this funcation. so we add this funcation into apache. and our company ‘s all old tasks will be switched to incubator-dolphinscheduler system.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] 597365581 commented on pull request #3728: process definition need to support parallel or serial choose. and parallel mode support wait queue length
Posted by GitBox <gi...@apache.org>.
597365581 commented on pull request #3728:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3728#issuecomment-691424156
unit test fail because in database, table t_ds_process_definition need add cloum:is_parallel,serial_command_lengh. sql script need to exec.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] 597365581 commented on a change in pull request #3728: [Feature][process_definition] process definition need to support parallel or serial choose. and parallel mode support wait queue length
Posted by GitBox <gi...@apache.org>.
597365581 commented on a change in pull request #3728:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3728#discussion_r491762608
##########
File path: sql/upgrade/1.3.3_schema/mysql/dolphinscheduler_ddl.sql
##########
@@ -112,4 +112,42 @@ CALL uc_dolphin_T_t_ds_resources_un();
DROP PROCEDURE IF EXISTS uc_dolphin_T_t_ds_resources_un;
+drop PROCEDURE if EXISTS uc_dolphin_T_t_ds_process_definition_A_is_parallel;
+delimiter d//
+CREATE PROCEDURE uc_dolphin_T_t_ds_process_definition_A_is_parallel()
+ BEGIN
+ IF NOT EXISTS (SELECT 1 FROM information_schema.COLUMNS
+ WHERE TABLE_NAME='t_ds_process_definition'
+ AND TABLE_SCHEMA=(SELECT DATABASE())
+ AND COLUMN_NAME ='is_parallel')
+ THEN
+ alter table t_ds_process_definition add is_parallel tinyint default '1' comment '0:serial,1:parallel';
Review comment:
> @gabrywu MySQL script and Postgresql script is separate in bofore project design。
> 
you can see bofore ‘s sql script， I keep it only。 hi，你可以查看之前和现有的项目，在mysql 中，都是以存储过程来加字段的，在Postgresql 中是以函数的方式来加字段的。我仅仅是尊照项目的要求来的。而且 mysql和 Postgresql 加字段的脚本 本来就没法去共用，我看ds 项目中一直是分开维护的。
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] 597365581 closed pull request #3728: [Feature][process_definition] process definition need to support parallel or serial choose. and parallel mode support wait queue length
Posted by GitBox <gi...@apache.org>.
597365581 closed pull request #3728:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3728
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] yangyichao-mango commented on pull request #3728: [Feature][process_definition] process definition need to support parallel or serial choose. and parallel mode support wait queue length
Posted by GitBox <gi...@apache.org>.
yangyichao-mango commented on pull request #3728:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3728#issuecomment-691451172
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] yangyichao-mango commented on pull request #3728: [Feature][process_definition] process definition need to support parallel or serial choose. and parallel mode support wait queue length
Posted by GitBox <gi...@apache.org>.
yangyichao-mango commented on pull request #3728:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3728#issuecomment-691455011
> @yangyichao-mango @break60 unit test fail because in database, table t_ds_process_definition need add cloum:is_parallel,serial_command_lengh. sql script need to exec in database.
If this pr need to change the database schema, you need to send a mail to mailing list to discuss this feature before submit a pr.
You can send a mail about why need to add the column to `dev@dolphinscheduler.apache.org`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] 597365581 commented on pull request #3728: [Feature][process_definition] process definition need to support parallel or serial choose. and parallel mode support wait queue length
Posted by GitBox <gi...@apache.org>.
597365581 commented on pull request #3728:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3728#issuecomment-691805352
> 1.e2e failed because of the addition of the serial field, you need to change the 8 of the following elements to 9
> 
>
> 2.the database fields are only changed the upgrade, there isn't add 2 fields in the create table statement
ok item 1 has resolved
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] 597365581 commented on a change in pull request #3728: [Feature][process_definition] process definition need to support parallel or serial choose. and parallel mode support wait queue length
Posted by GitBox <gi...@apache.org>.
597365581 commented on a change in pull request #3728:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3728#discussion_r488348921
##########
File path: sql/upgrade/1.3.3_schema/mysql/dolphinscheduler_ddl.sql
##########
@@ -112,4 +112,42 @@ CALL uc_dolphin_T_t_ds_resources_un();
DROP PROCEDURE IF EXISTS uc_dolphin_T_t_ds_resources_un;
+drop PROCEDURE if EXISTS uc_dolphin_T_t_ds_process_definition_A_is_parallel;
+delimiter d//
+CREATE PROCEDURE uc_dolphin_T_t_ds_process_definition_A_is_parallel()
+ BEGIN
+ IF NOT EXISTS (SELECT 1 FROM information_schema.COLUMNS
+ WHERE TABLE_NAME='t_ds_process_definition'
+ AND TABLE_SCHEMA=(SELECT DATABASE())
+ AND COLUMN_NAME ='is_parallel')
+ THEN
+ alter table t_ds_process_definition add is_parallel tinyint default '1' comment '0:serial,1:parallel';
Review comment:
I copy old ds project sql script and modify. I look old script is use procedure to add one column
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] 597365581 commented on pull request #3728: [Feature][process_definition] process definition need to support parallel or serial choose. and parallel mode support wait queue length
Posted by GitBox <gi...@apache.org>.
597365581 commented on pull request #3728:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3728#issuecomment-691435303
@dailidong this code can merge into dev? our company need this funcation. so we add this funcation into apache.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] 597365581 commented on pull request #3728: [Feature][process_definition] process definition need to support parallel or serial choose. and parallel mode support wait queue length
Posted by GitBox <gi...@apache.org>.
597365581 commented on pull request #3728:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3728#issuecomment-691600206
@dailidong @yangyichao-mango @break60
why I add two cloums in table t_ds_process_definition:
1、in process,need to solve serial run and serial run command can set wait queue length.
2、after later，we need to statistics serial commands for every projet or every processdef.
this function has uesd in our company. I hope can merger this function to apache，and in future our company can use more new apache release version。
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] yangyichao-mango commented on pull request #3728: [Feature][process_definition] process definition need to support parallel or serial choose. and parallel mode support wait queue length
Posted by GitBox <gi...@apache.org>.
yangyichao-mango commented on pull request #3728:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3728#issuecomment-691451172
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] 597365581 commented on a change in pull request #3728: [Feature][process_definition] process definition need to support parallel or serial choose. and parallel mode support wait queue length
Posted by GitBox <gi...@apache.org>.
597365581 commented on a change in pull request #3728:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3728#discussion_r491762101
##########
File path: sql/upgrade/1.3.3_schema/mysql/dolphinscheduler_ddl.sql
##########
@@ -112,4 +112,42 @@ CALL uc_dolphin_T_t_ds_resources_un();
DROP PROCEDURE IF EXISTS uc_dolphin_T_t_ds_resources_un;
+drop PROCEDURE if EXISTS uc_dolphin_T_t_ds_process_definition_A_is_parallel;
+delimiter d//
+CREATE PROCEDURE uc_dolphin_T_t_ds_process_definition_A_is_parallel()
+ BEGIN
+ IF NOT EXISTS (SELECT 1 FROM information_schema.COLUMNS
+ WHERE TABLE_NAME='t_ds_process_definition'
+ AND TABLE_SCHEMA=(SELECT DATABASE())
+ AND COLUMN_NAME ='is_parallel')
+ THEN
+ alter table t_ds_process_definition add is_parallel tinyint default '1' comment '0:serial,1:parallel';
Review comment:
@gabrywu MySQL script and Postgresql script is separate in bofore project design。
##########
File path: sql/upgrade/1.3.3_schema/mysql/dolphinscheduler_ddl.sql
##########
@@ -112,4 +112,42 @@ CALL uc_dolphin_T_t_ds_resources_un();
DROP PROCEDURE IF EXISTS uc_dolphin_T_t_ds_resources_un;
+drop PROCEDURE if EXISTS uc_dolphin_T_t_ds_process_definition_A_is_parallel;
+delimiter d//
+CREATE PROCEDURE uc_dolphin_T_t_ds_process_definition_A_is_parallel()
+ BEGIN
+ IF NOT EXISTS (SELECT 1 FROM information_schema.COLUMNS
+ WHERE TABLE_NAME='t_ds_process_definition'
+ AND TABLE_SCHEMA=(SELECT DATABASE())
+ AND COLUMN_NAME ='is_parallel')
+ THEN
+ alter table t_ds_process_definition add is_parallel tinyint default '1' comment '0:serial,1:parallel';
Review comment:
> @gabrywu MySQL script and Postgresql script is separate in bofore project design。
> 
you can see bofore ‘s sql script， I keep it only。 hi，你可以查看之前和现有的项目，在mysql 中，都是以存储过程来加字段的，在Postgresql 中是以函数的方式来加字段的。我仅仅是尊照项目的要求来的。而且 mysql和 Postgresql 加字段的脚本 本来就没法去共用，我看ds 项目中一直是分开维护的。
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] yangyichao-mango commented on pull request #3728: [Feature][process_definition] process definition need to support parallel or serial choose. and parallel mode support wait queue length
Posted by GitBox <gi...@apache.org>.
yangyichao-mango commented on pull request #3728:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3728#issuecomment-691451172
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] yangyichao-mango edited a comment on pull request #3728: [Feature][process_definition] process definition need to support parallel or serial choose. and parallel mode support wait queue length
Posted by GitBox <gi...@apache.org>.
yangyichao-mango edited a comment on pull request #3728:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3728#issuecomment-691455011
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] 597365581 commented on pull request #3728: [Feature][process_definition] process definition need to support parallel or serial choose. and parallel mode support wait queue length
Posted by GitBox <gi...@apache.org>.
597365581 commented on pull request #3728:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3728#issuecomment-691600303
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] gabrywu commented on a change in pull request #3728: [Feature][process_definition] process definition need to support parallel or serial choose. and parallel mode support wait queue length
Posted by GitBox <gi...@apache.org>.
gabrywu commented on a change in pull request #3728:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3728#discussion_r489236178
##########
File path: sql/upgrade/1.3.3_schema/mysql/dolphinscheduler_ddl.sql
##########
@@ -112,4 +112,42 @@ CALL uc_dolphin_T_t_ds_resources_un();
DROP PROCEDURE IF EXISTS uc_dolphin_T_t_ds_resources_un;
+drop PROCEDURE if EXISTS uc_dolphin_T_t_ds_process_definition_A_is_parallel;
+delimiter d//
+CREATE PROCEDURE uc_dolphin_T_t_ds_process_definition_A_is_parallel()
+ BEGIN
+ IF NOT EXISTS (SELECT 1 FROM information_schema.COLUMNS
+ WHERE TABLE_NAME='t_ds_process_definition'
+ AND TABLE_SCHEMA=(SELECT DATABASE())
+ AND COLUMN_NAME ='is_parallel')
+ THEN
+ alter table t_ds_process_definition add is_parallel tinyint default '1' comment '0:serial,1:parallel';
Review comment:
please refer to the lastest SQL script. Because the ddl SQL will be run on different DBMS, such as MySQL,Postgresql, and so on, however, they might no support procedure.
##########
File path: sql/upgrade/1.3.3_schema/mysql/dolphinscheduler_ddl.sql
##########
@@ -112,4 +112,42 @@ CALL uc_dolphin_T_t_ds_resources_un();
DROP PROCEDURE IF EXISTS uc_dolphin_T_t_ds_resources_un;
+drop PROCEDURE if EXISTS uc_dolphin_T_t_ds_process_definition_A_is_parallel;
+delimiter d//
+CREATE PROCEDURE uc_dolphin_T_t_ds_process_definition_A_is_parallel()
+ BEGIN
+ IF NOT EXISTS (SELECT 1 FROM information_schema.COLUMNS
+ WHERE TABLE_NAME='t_ds_process_definition'
+ AND TABLE_SCHEMA=(SELECT DATABASE())
+ AND COLUMN_NAME ='is_parallel')
+ THEN
+ alter table t_ds_process_definition add is_parallel tinyint default '1' comment '0:serial,1:parallel';
Review comment:
please refer to the lastest SQL script. Because the ddl SQL will be run on different DBMS, such as MySQL,Postgresql, and so on, however, they might not support procedure.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] 597365581 commented on pull request #3728: process definition need to support parallel or serial choose. and parallel mode support wait queue length
Posted by GitBox <gi...@apache.org>.
597365581 commented on pull request #3728:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3728#issuecomment-691424156
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] chengshiwen edited a comment on pull request #3728: [Feature][process_definition] process definition need to support parallel or serial choose. and parallel mode support wait queue length
Posted by GitBox <gi...@apache.org>.
chengshiwen edited a comment on pull request #3728:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3728#issuecomment-758451981
@597365581 What is the relationship between these 3 PRs: #3684, #3685, #3728? Are #3684 and #3685 duplicated with this PR #3728?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] chengshiwen commented on pull request #3728: [Feature][process_definition] process definition need to support parallel or serial choose. and parallel mode support wait queue length
Posted by GitBox <gi...@apache.org>.
chengshiwen commented on pull request #3728:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3728#issuecomment-758451981
@597365581 What is the relationship between these 3 PRs: #3684, #3685, #3728?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] dailidong commented on pull request #3728: [Feature][process_definition] process definition need to support parallel or serial choose. and parallel mode support wait queue length
Posted by GitBox <gi...@apache.org>.
dailidong commented on pull request #3728:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3728#issuecomment-766307796
> @597365581 What is the relationship between these 3 PRs: #3684, #3685, #3728? Are #3684 and #3685 duplicated with this PR #3728?
@597365581 , could you solve the confict files and reply ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] zhangb0120 commented on pull request #3728: [Feature][process_definition] process definition need to support parallel or serial choose. and parallel mode support wait queue length
Posted by GitBox <gi...@apache.org>.
zhangb0120 commented on pull request #3728:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3728#issuecomment-730260155
这个功能怎么样了，有合并到主分支吗？
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] 597365581 commented on pull request #3728: [Feature][process_definition] process definition need to support parallel or serial choose. and parallel mode support wait queue length
Posted by GitBox <gi...@apache.org>.
597365581 commented on pull request #3728:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3728#issuecomment-691456988
> > @yangyichao-mango @break60 unit test fail because in database, table t_ds_process_definition need add cloum:is_parallel,serial_command_lengh. sql script need to exec in database.
>
> If this pr need to change the database schema, you need to send a mail to mailing list to discuss this feature before submit a pr.
> You can send a mail about why need to add the column and the necessity about adding the new column to `dev@dolphinscheduler.apache.org`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] 597365581 commented on pull request #3728: process definition need to support parallel or serial choose. and parallel mode support wait queue length
Posted by GitBox <gi...@apache.org>.
597365581 commented on pull request #3728:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3728#issuecomment-691424156
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] 597365581 commented on a change in pull request #3728: [Feature][process_definition] process definition need to support parallel or serial choose. and parallel mode support wait queue length
Posted by GitBox <gi...@apache.org>.
597365581 commented on a change in pull request #3728:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3728#discussion_r488347821
##########
File path: dolphinscheduler-dao/src/main/resources/org/apache/dolphinscheduler/dao/mapper/CommandMapper.xml
##########
@@ -19,18 +19,30 @@
<!DOCTYPE mapper PUBLIC "-//mybatis.org//DTD Mapper 3.0//EN" "http://mybatis.org/dtd/mybatis-3-mapper.dtd" >
<mapper namespace="org.apache.dolphinscheduler.dao.mapper.CommandMapper">
<select id="getOneToRun" resultType="org.apache.dolphinscheduler.dao.entity.Command">
- select command.* from t_ds_command command
- join t_ds_process_definition definition on command.process_definition_id = definition.id
- where definition.release_state = 1 AND definition.flag = 1
- order by command.update_time asc
- limit 1
+ select * from
Review comment:
sql has simply it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] yangyichao-mango commented on pull request #3728: [Feature][process_definition] process definition need to support parallel or serial choose. and parallel mode support wait queue length
Posted by GitBox <gi...@apache.org>.
yangyichao-mango commented on pull request #3728:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3728#issuecomment-691451273
Please resolve the ut check error.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] 597365581 commented on pull request #3728: [Feature][process_definition] process definition need to support parallel or serial choose. and parallel mode support wait queue length
Posted by GitBox <gi...@apache.org>.
597365581 commented on pull request #3728:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3728#issuecomment-691785137
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] 597365581 commented on pull request #3728: [Feature][process_definition] process definition need to support parallel or serial choose. and parallel mode support wait queue length
Posted by GitBox <gi...@apache.org>.
597365581 commented on pull request #3728:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3728#issuecomment-691453324
@yangyichao-mango @break60 unit test fail because in database, table t_ds_process_definition need add cloum:is_parallel,serial_command_lengh. sql script need to exec in database.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] 597365581 commented on pull request #3728: [Feature][process_definition] process definition need to support parallel or serial choose. and parallel mode support wait queue length
Posted by GitBox <gi...@apache.org>.
597365581 commented on pull request #3728:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3728#issuecomment-691453202
@yangyichao-mango @break60 help to review.thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] 597365581 commented on a change in pull request #3728: [Feature][process_definition] process definition need to support parallel or serial choose. and parallel mode support wait queue length
Posted by GitBox <gi...@apache.org>.
597365581 commented on a change in pull request #3728:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3728#discussion_r491762101
##########
File path: sql/upgrade/1.3.3_schema/mysql/dolphinscheduler_ddl.sql
##########
@@ -112,4 +112,42 @@ CALL uc_dolphin_T_t_ds_resources_un();
DROP PROCEDURE IF EXISTS uc_dolphin_T_t_ds_resources_un;
+drop PROCEDURE if EXISTS uc_dolphin_T_t_ds_process_definition_A_is_parallel;
+delimiter d//
+CREATE PROCEDURE uc_dolphin_T_t_ds_process_definition_A_is_parallel()
+ BEGIN
+ IF NOT EXISTS (SELECT 1 FROM information_schema.COLUMNS
+ WHERE TABLE_NAME='t_ds_process_definition'
+ AND TABLE_SCHEMA=(SELECT DATABASE())
+ AND COLUMN_NAME ='is_parallel')
+ THEN
+ alter table t_ds_process_definition add is_parallel tinyint default '1' comment '0:serial,1:parallel';
Review comment:
@gabrywu MySQL script and Postgresql script is separate in bofore project design。
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] yangyichao-mango edited a comment on pull request #3728: [Feature][process_definition] process definition need to support parallel or serial choose. and parallel mode support wait queue length
Posted by GitBox <gi...@apache.org>.
yangyichao-mango edited a comment on pull request #3728:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3728#issuecomment-691455011
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org