You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Sebb (JIRA)" <ji...@apache.org> on 2008/11/25 11:37:44 UTC
[jira] Created: (SCXML-93) SCXMLTestHelper generates a lot of
serialisation files which are not tidied up
SCXMLTestHelper generates a lot of serialisation files which are not tidied up
------------------------------------------------------------------------------
Key: SCXML-93
URL: https://issues.apache.org/jira/browse/SCXML-93
Project: Commons SCXML
Issue Type: Bug
Reporter: Sebb
Priority: Minor
SCXMLTestHelper generates files to test serialisation of classes in testExecutorSerializability() and testModelSerializability().
These files are only used temporarily, but are not cleared up at the end of a run.
They can be replaced by using ByteArray classes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SCXML-93) SCXMLTestHelper generates a lot of
serialisation files which are not tidied up
Posted by "Rahul Akolkar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SCXML-93?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12654297#action_12654297 ]
Rahul Akolkar commented on SCXML-93:
------------------------------------
Patch looks good, thanks. As a minor nit, I'll request that you add the static int and the new method towards the top where the constants for the serialization tests are defined.
> SCXMLTestHelper generates a lot of serialisation files which are not tidied up
> ------------------------------------------------------------------------------
>
> Key: SCXML-93
> URL: https://issues.apache.org/jira/browse/SCXML-93
> Project: Commons SCXML
> Issue Type: Bug
> Reporter: Sebb
> Priority: Minor
> Fix For: 1.0
>
> Attachments: SCXMLTestHelper.patch
>
>
> SCXMLTestHelper generates files to test serialisation of classes in testExecutorSerializability() and testModelSerializability().
> These files are only used temporarily, but are not cleared up at the end of a run.
> They can be replaced by using ByteArray classes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SCXML-93) SCXMLTestHelper generates a lot of
serialisation files which are not tidied up
Posted by "Rahul Akolkar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SCXML-93?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rahul Akolkar updated SCXML-93:
-------------------------------
Fix Version/s: (was: 1.0)
0.10
It would've been fine to just apply this one :-) (atleast thats what I intended to say in the last comment)
Updating fix version to v0.10 since a patch is now available (I'm assuming you'll commit and resolve this).
> SCXMLTestHelper generates a lot of serialisation files which are not tidied up
> ------------------------------------------------------------------------------
>
> Key: SCXML-93
> URL: https://issues.apache.org/jira/browse/SCXML-93
> Project: Commons SCXML
> Issue Type: Bug
> Reporter: Sebb
> Priority: Minor
> Fix For: 0.10
>
> Attachments: SCXMLTestHelper2.patch
>
>
> SCXMLTestHelper generates files to test serialisation of classes in testExecutorSerializability() and testModelSerializability().
> These files are only used temporarily, but are not cleared up at the end of a run.
> They can be replaced by using ByteArray classes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SCXML-93) SCXMLTestHelper generates a lot of
serialisation files which are not tidied up
Posted by "Sebb (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SCXML-93?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sebb updated SCXML-93:
----------------------
Attachment: (was: SCXMLTestHelper.patch)
> SCXMLTestHelper generates a lot of serialisation files which are not tidied up
> ------------------------------------------------------------------------------
>
> Key: SCXML-93
> URL: https://issues.apache.org/jira/browse/SCXML-93
> Project: Commons SCXML
> Issue Type: Bug
> Reporter: Sebb
> Priority: Minor
> Fix For: 1.0
>
>
> SCXMLTestHelper generates files to test serialisation of classes in testExecutorSerializability() and testModelSerializability().
> These files are only used temporarily, but are not cleared up at the end of a run.
> They can be replaced by using ByteArray classes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SCXML-93) SCXMLTestHelper generates a lot of
serialisation files which are not tidied up
Posted by "Sebb (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SCXML-93?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sebb updated SCXML-93:
----------------------
Attachment: SCXMLTestHelper.patch
Patch to replace millisecond suffix with integer suffix to reduce number of files generated (and ensure uniqueness)
> SCXMLTestHelper generates a lot of serialisation files which are not tidied up
> ------------------------------------------------------------------------------
>
> Key: SCXML-93
> URL: https://issues.apache.org/jira/browse/SCXML-93
> Project: Commons SCXML
> Issue Type: Bug
> Reporter: Sebb
> Priority: Minor
> Fix For: 1.0
>
> Attachments: SCXMLTestHelper.patch
>
>
> SCXMLTestHelper generates files to test serialisation of classes in testExecutorSerializability() and testModelSerializability().
> These files are only used temporarily, but are not cleared up at the end of a run.
> They can be replaced by using ByteArray classes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SCXML-93) SCXMLTestHelper generates a lot of
serialisation files which are not tidied up
Posted by "Sebb (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SCXML-93?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sebb resolved SCXML-93.
-----------------------
Resolution: Fixed
Fixed in trunk:
URL: http://svn.apache.org/viewvc?rev=724565&view=rev
Log:
SCXML-93: SCXMLTestHelper generates a lot of serialisation files which are not tidied up
and in branch J6:
URL: http://svn.apache.org/viewvc?rev=724567&view=rev
Log:
SCXML-93: SCXMLTestHelper generates a lot of serialisation files which are not tidied up
> SCXMLTestHelper generates a lot of serialisation files which are not tidied up
> ------------------------------------------------------------------------------
>
> Key: SCXML-93
> URL: https://issues.apache.org/jira/browse/SCXML-93
> Project: Commons SCXML
> Issue Type: Bug
> Reporter: Sebb
> Priority: Minor
> Fix For: 0.10
>
> Attachments: SCXMLTestHelper2.patch
>
>
> SCXMLTestHelper generates files to test serialisation of classes in testExecutorSerializability() and testModelSerializability().
> These files are only used temporarily, but are not cleared up at the end of a run.
> They can be replaced by using ByteArray classes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (SCXML-93) SCXMLTestHelper generates a lot of
serialisation files which are not tidied up
Posted by "Sebb (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SCXML-93?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sebb reopened SCXML-93:
-----------------------
Yes, testing generates other artifacts, however these are regenerated for each run - they don't normally accumulate as in this case.
There's also no easy way to tie the file to the test case, so I don't see what purpose is served by keeping the files.
If you really want to keep the files, name them after the testcases that use them. At least then the number of files would be limited.
> SCXMLTestHelper generates a lot of serialisation files which are not tidied up
> ------------------------------------------------------------------------------
>
> Key: SCXML-93
> URL: https://issues.apache.org/jira/browse/SCXML-93
> Project: Commons SCXML
> Issue Type: Bug
> Reporter: Sebb
> Priority: Minor
>
> SCXMLTestHelper generates files to test serialisation of classes in testExecutorSerializability() and testModelSerializability().
> These files are only used temporarily, but are not cleared up at the end of a run.
> They can be replaced by using ByteArray classes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SCXML-93) SCXMLTestHelper generates a lot of
serialisation files which are not tidied up
Posted by "Sebb (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SCXML-93?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12654002#action_12654002 ]
Sebb commented on SCXML-93:
---------------------------
It's not too difficult to walk the call stack to find a calling method with the name textXXX, but this does not uniquely identify all usages.
So I suggest just replacing the millisecond stamp (which is not necessarily unique, by the way) with a simple int counter.
This can be a static (class) variable. If the test is re-run without reloading the class, then the counter will increase, but at least repeated "mvn test" runs won't create lots of files.
Is that OK?
> SCXMLTestHelper generates a lot of serialisation files which are not tidied up
> ------------------------------------------------------------------------------
>
> Key: SCXML-93
> URL: https://issues.apache.org/jira/browse/SCXML-93
> Project: Commons SCXML
> Issue Type: Bug
> Reporter: Sebb
> Priority: Minor
> Fix For: 1.0
>
>
> SCXMLTestHelper generates files to test serialisation of classes in testExecutorSerializability() and testModelSerializability().
> These files are only used temporarily, but are not cleared up at the end of a run.
> They can be replaced by using ByteArray classes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SCXML-93) SCXMLTestHelper generates a lot of
serialisation files which are not tidied up
Posted by "Rahul Akolkar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SCXML-93?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rahul Akolkar updated SCXML-93:
-------------------------------
Fix Version/s: 1.0
When running a single (problematic or new) test at a time, as I prefer to do, its actually not difficult to locate serialization artifacts (they are usually < 5 per test, and timestamp order corresponds to document order of serialization).
I agree on accumulation, and since you insist on this, I don't mind those bits being redone such that we use names that match the testcases etc. I agree its an improvement since the number would be limited on a complete run (or many runs) as you say above.
However, its not something I personally care to do (which is why the Won't Fix before).
So I'm setting the fix version to 1.0 (which currently means 'some time in the future if a well-tested patch appears on this ticket').
> SCXMLTestHelper generates a lot of serialisation files which are not tidied up
> ------------------------------------------------------------------------------
>
> Key: SCXML-93
> URL: https://issues.apache.org/jira/browse/SCXML-93
> Project: Commons SCXML
> Issue Type: Bug
> Reporter: Sebb
> Priority: Minor
> Fix For: 1.0
>
>
> SCXMLTestHelper generates files to test serialisation of classes in testExecutorSerializability() and testModelSerializability().
> These files are only used temporarily, but are not cleared up at the end of a run.
> They can be replaced by using ByteArray classes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SCXML-93) SCXMLTestHelper generates a lot of
serialisation files which are not tidied up
Posted by "Rahul Akolkar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SCXML-93?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rahul Akolkar resolved SCXML-93.
--------------------------------
Resolution: Won't Fix
I think the aspect of tidying up here is no different from what folks using any of the builds should expect -- to elaborate, lets say you execute this command:
mvn test
(or 'maven test', or 'ant'), you'll find a bunch of artifacts created in the target directory. These persist until you clean the build, so in the above case a:
mvn clean
will do the trick. The serialization files follow a similar pattern, they can be cleaned using the corresponding clean command.
A useful advantage of using File I/O is that the artifacts can be introspected once you run the tests and you can observe how certain changes to the datamodel or history affect size on disk etc.
You are right that this can be replaced by using ByteArray I/O instead, but at this point its unclear we should (its much harder to introspect serializations or track serialization timelines that way).
Resolving as Won't Fix.
> SCXMLTestHelper generates a lot of serialisation files which are not tidied up
> ------------------------------------------------------------------------------
>
> Key: SCXML-93
> URL: https://issues.apache.org/jira/browse/SCXML-93
> Project: Commons SCXML
> Issue Type: Bug
> Reporter: Sebb
> Priority: Minor
>
> SCXMLTestHelper generates files to test serialisation of classes in testExecutorSerializability() and testModelSerializability().
> These files are only used temporarily, but are not cleared up at the end of a run.
> They can be replaced by using ByteArray classes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SCXML-93) SCXMLTestHelper generates a lot of
serialisation files which are not tidied up
Posted by "Sebb (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SCXML-93?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sebb updated SCXML-93:
----------------------
Attachment: SCXMLTestHelper2.patch
Updated location for int and method
> SCXMLTestHelper generates a lot of serialisation files which are not tidied up
> ------------------------------------------------------------------------------
>
> Key: SCXML-93
> URL: https://issues.apache.org/jira/browse/SCXML-93
> Project: Commons SCXML
> Issue Type: Bug
> Reporter: Sebb
> Priority: Minor
> Fix For: 1.0
>
> Attachments: SCXMLTestHelper2.patch
>
>
> SCXMLTestHelper generates files to test serialisation of classes in testExecutorSerializability() and testModelSerializability().
> These files are only used temporarily, but are not cleared up at the end of a run.
> They can be replaced by using ByteArray classes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.