You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by Andrew Stitcher <as...@apache.org> on 2013/06/18 23:06:20 UTC
Review Request: Continuation of Qpid C++ spring cleaning - QPID-4905
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11944/
-----------------------------------------------------------
Review request for qpid and Gordon Sim.
Description
-------
This is a continuation of review 11628 - https://reviews.apache.org/r/11628/
Included in this review is the last change there merging broker::Connection and broker::ConnectionState and a further change that tidies up the interface of the Connection/Message classes to the Broker management code. This introduces a protocol independent "Publisher" interface that can be queried for the userID/Url/ObjectId and OwnershipToken of a message publisher. This is used primarily in authenticating management messages.
This addresses bug QPID-4905.
https://issues.apache.org/jira/browse/QPID-4905
Diffs
-----
/trunk/qpid/cpp/src/CMakeLists.txt 1493903
/trunk/qpid/cpp/src/Makefile.am 1493903
/trunk/qpid/cpp/src/qpid/broker/Bridge.h 1493903
/trunk/qpid/cpp/src/qpid/broker/Bridge.cpp 1493903
/trunk/qpid/cpp/src/qpid/broker/Broker.h 1493903
/trunk/qpid/cpp/src/qpid/broker/Broker.cpp 1493903
/trunk/qpid/cpp/src/qpid/broker/Connection.h 1493903
/trunk/qpid/cpp/src/qpid/broker/Connection.cpp 1493903
/trunk/qpid/cpp/src/qpid/broker/ConnectionHandler.cpp 1493903
/trunk/qpid/cpp/src/qpid/broker/ConnectionState.h 1493903
/trunk/qpid/cpp/src/qpid/broker/ConnectionState.cpp 1493903
/trunk/qpid/cpp/src/qpid/broker/ConnectionToken.h 1493903
/trunk/qpid/cpp/src/qpid/broker/HandlerImpl.h 1493903
/trunk/qpid/cpp/src/qpid/broker/Message.h 1493903
/trunk/qpid/cpp/src/qpid/broker/Message.cpp 1493903
/trunk/qpid/cpp/src/qpid/broker/OwnershipToken.h 1493903
/trunk/qpid/cpp/src/qpid/broker/Publisher.h PRE-CREATION
/trunk/qpid/cpp/src/qpid/broker/Queue.cpp 1493903
/trunk/qpid/cpp/src/qpid/broker/SaslAuthenticator.cpp 1493903
/trunk/qpid/cpp/src/qpid/broker/SemanticState.cpp 1493903
/trunk/qpid/cpp/src/qpid/broker/SessionAdapter.h 1493903
/trunk/qpid/cpp/src/qpid/broker/SessionAdapter.cpp 1493903
/trunk/qpid/cpp/src/qpid/broker/SessionContext.h 1493903
/trunk/qpid/cpp/src/qpid/broker/SessionHandler.h 1493903
/trunk/qpid/cpp/src/qpid/broker/SessionHandler.cpp 1493903
/trunk/qpid/cpp/src/qpid/broker/SessionState.h 1493903
/trunk/qpid/cpp/src/qpid/broker/SessionState.cpp 1493903
/trunk/qpid/cpp/src/qpid/broker/amqp/ManagedConnection.h 1493903
/trunk/qpid/cpp/src/qpid/broker/amqp/ManagedConnection.cpp 1493903
/trunk/qpid/cpp/src/qpid/broker/amqp/ManagedSession.h 1493903
/trunk/qpid/cpp/src/qpid/broker/amqp/ManagedSession.cpp 1493903
/trunk/qpid/cpp/src/qpid/broker/windows/SaslAuthenticator.cpp 1493903
/trunk/qpid/cpp/src/qpid/ha/ReplicatingSubscription.cpp 1493903
/trunk/qpid/cpp/src/qpid/management/ManagementAgent.h 1493903
/trunk/qpid/cpp/src/qpid/management/ManagementAgent.cpp 1493903
/trunk/qpid/cpp/src/qpid/sys/ConnectionOutputHandlerPtr.h 1493903
Diff: https://reviews.apache.org/r/11944/diff/
Testing
-------
cmake: make test
Thanks,
Andrew Stitcher
Re: Review Request: Continuation of Qpid C++ spring cleaning - QPID-4905
Posted by Gordon Sim <gs...@redhat.com>.
> On June 18, 2013, 9:08 p.m., Andrew Stitcher wrote:
> > I'm not especially attached the the terminology "Publisher", it comes from the pre-existing setPublisher() method on the Message. However, the purpose of this object is certainly to do with Authentication and Ownership of the "thing" that is publishing the message,
>
> Gordon Sim wrote:
> I think Publisher is a very poor name. At present that interface defines connection identity, with the identification of the publishing connection being the only concrete use. It could however just as well be used to identify the declaring connection for a queue.
>
> That said, I am going to be doing work to separate some of the protocol independent stuff from the 0-10 connection anyway and would rather this gets committed so I can move on. I may change the name o f that interface as part of that.
>
> Andrew Stitcher wrote:
> I could certainly change the interfce name to ConnectionIdentity if you prefer.
>
I certainly think that would be a better name.
- Gordon
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11944/#review22074
-----------------------------------------------------------
On June 18, 2013, 9:06 p.m., Andrew Stitcher wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11944/
> -----------------------------------------------------------
>
> (Updated June 18, 2013, 9:06 p.m.)
>
>
> Review request for qpid and Gordon Sim.
>
>
> Description
> -------
>
> This is a continuation of review 11628 - https://reviews.apache.org/r/11628/
>
> Included in this review is the last change there merging broker::Connection and broker::ConnectionState and a further change that tidies up the interface of the Connection/Message classes to the Broker management code. This introduces a protocol independent "Publisher" interface that can be queried for the userID/Url/ObjectId and OwnershipToken of a message publisher. This is used primarily in authenticating management messages.
>
>
> This addresses bug QPID-4905.
> https://issues.apache.org/jira/browse/QPID-4905
>
>
> Diffs
> -----
>
> /trunk/qpid/cpp/src/CMakeLists.txt 1493903
> /trunk/qpid/cpp/src/Makefile.am 1493903
> /trunk/qpid/cpp/src/qpid/broker/Bridge.h 1493903
> /trunk/qpid/cpp/src/qpid/broker/Bridge.cpp 1493903
> /trunk/qpid/cpp/src/qpid/broker/Broker.h 1493903
> /trunk/qpid/cpp/src/qpid/broker/Broker.cpp 1493903
> /trunk/qpid/cpp/src/qpid/broker/Connection.h 1493903
> /trunk/qpid/cpp/src/qpid/broker/Connection.cpp 1493903
> /trunk/qpid/cpp/src/qpid/broker/ConnectionHandler.cpp 1493903
> /trunk/qpid/cpp/src/qpid/broker/ConnectionState.h 1493903
> /trunk/qpid/cpp/src/qpid/broker/ConnectionState.cpp 1493903
> /trunk/qpid/cpp/src/qpid/broker/ConnectionToken.h 1493903
> /trunk/qpid/cpp/src/qpid/broker/HandlerImpl.h 1493903
> /trunk/qpid/cpp/src/qpid/broker/Message.h 1493903
> /trunk/qpid/cpp/src/qpid/broker/Message.cpp 1493903
> /trunk/qpid/cpp/src/qpid/broker/OwnershipToken.h 1493903
> /trunk/qpid/cpp/src/qpid/broker/Publisher.h PRE-CREATION
> /trunk/qpid/cpp/src/qpid/broker/Queue.cpp 1493903
> /trunk/qpid/cpp/src/qpid/broker/SaslAuthenticator.cpp 1493903
> /trunk/qpid/cpp/src/qpid/broker/SemanticState.cpp 1493903
> /trunk/qpid/cpp/src/qpid/broker/SessionAdapter.h 1493903
> /trunk/qpid/cpp/src/qpid/broker/SessionAdapter.cpp 1493903
> /trunk/qpid/cpp/src/qpid/broker/SessionContext.h 1493903
> /trunk/qpid/cpp/src/qpid/broker/SessionHandler.h 1493903
> /trunk/qpid/cpp/src/qpid/broker/SessionHandler.cpp 1493903
> /trunk/qpid/cpp/src/qpid/broker/SessionState.h 1493903
> /trunk/qpid/cpp/src/qpid/broker/SessionState.cpp 1493903
> /trunk/qpid/cpp/src/qpid/broker/amqp/ManagedConnection.h 1493903
> /trunk/qpid/cpp/src/qpid/broker/amqp/ManagedConnection.cpp 1493903
> /trunk/qpid/cpp/src/qpid/broker/amqp/ManagedSession.h 1493903
> /trunk/qpid/cpp/src/qpid/broker/amqp/ManagedSession.cpp 1493903
> /trunk/qpid/cpp/src/qpid/broker/windows/SaslAuthenticator.cpp 1493903
> /trunk/qpid/cpp/src/qpid/ha/ReplicatingSubscription.cpp 1493903
> /trunk/qpid/cpp/src/qpid/management/ManagementAgent.h 1493903
> /trunk/qpid/cpp/src/qpid/management/ManagementAgent.cpp 1493903
> /trunk/qpid/cpp/src/qpid/sys/ConnectionOutputHandlerPtr.h 1493903
>
> Diff: https://reviews.apache.org/r/11944/diff/
>
>
> Testing
> -------
>
> cmake: make test
>
>
> Thanks,
>
> Andrew Stitcher
>
>
Re: Review Request: Continuation of Qpid C++ spring cleaning - QPID-4905
Posted by Andrew Stitcher <as...@apache.org>.
> On June 18, 2013, 9:08 p.m., Andrew Stitcher wrote:
> > I'm not especially attached the the terminology "Publisher", it comes from the pre-existing setPublisher() method on the Message. However, the purpose of this object is certainly to do with Authentication and Ownership of the "thing" that is publishing the message,
>
> Gordon Sim wrote:
> I think Publisher is a very poor name. At present that interface defines connection identity, with the identification of the publishing connection being the only concrete use. It could however just as well be used to identify the declaring connection for a queue.
>
> That said, I am going to be doing work to separate some of the protocol independent stuff from the 0-10 connection anyway and would rather this gets committed so I can move on. I may change the name o f that interface as part of that.
>
> Andrew Stitcher wrote:
> I could certainly change the interfce name to ConnectionIdentity if you prefer.
>
>
> Gordon Sim wrote:
> I certainly think that would be a better name.
I've now committed this change with the interface name ConnectionIdentity
- Andrew
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11944/#review22074
-----------------------------------------------------------
On June 18, 2013, 9:06 p.m., Andrew Stitcher wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11944/
> -----------------------------------------------------------
>
> (Updated June 18, 2013, 9:06 p.m.)
>
>
> Review request for qpid and Gordon Sim.
>
>
> Description
> -------
>
> This is a continuation of review 11628 - https://reviews.apache.org/r/11628/
>
> Included in this review is the last change there merging broker::Connection and broker::ConnectionState and a further change that tidies up the interface of the Connection/Message classes to the Broker management code. This introduces a protocol independent "Publisher" interface that can be queried for the userID/Url/ObjectId and OwnershipToken of a message publisher. This is used primarily in authenticating management messages.
>
>
> This addresses bug QPID-4905.
> https://issues.apache.org/jira/browse/QPID-4905
>
>
> Diffs
> -----
>
> /trunk/qpid/cpp/src/CMakeLists.txt 1493903
> /trunk/qpid/cpp/src/Makefile.am 1493903
> /trunk/qpid/cpp/src/qpid/broker/Bridge.h 1493903
> /trunk/qpid/cpp/src/qpid/broker/Bridge.cpp 1493903
> /trunk/qpid/cpp/src/qpid/broker/Broker.h 1493903
> /trunk/qpid/cpp/src/qpid/broker/Broker.cpp 1493903
> /trunk/qpid/cpp/src/qpid/broker/Connection.h 1493903
> /trunk/qpid/cpp/src/qpid/broker/Connection.cpp 1493903
> /trunk/qpid/cpp/src/qpid/broker/ConnectionHandler.cpp 1493903
> /trunk/qpid/cpp/src/qpid/broker/ConnectionState.h 1493903
> /trunk/qpid/cpp/src/qpid/broker/ConnectionState.cpp 1493903
> /trunk/qpid/cpp/src/qpid/broker/ConnectionToken.h 1493903
> /trunk/qpid/cpp/src/qpid/broker/HandlerImpl.h 1493903
> /trunk/qpid/cpp/src/qpid/broker/Message.h 1493903
> /trunk/qpid/cpp/src/qpid/broker/Message.cpp 1493903
> /trunk/qpid/cpp/src/qpid/broker/OwnershipToken.h 1493903
> /trunk/qpid/cpp/src/qpid/broker/Publisher.h PRE-CREATION
> /trunk/qpid/cpp/src/qpid/broker/Queue.cpp 1493903
> /trunk/qpid/cpp/src/qpid/broker/SaslAuthenticator.cpp 1493903
> /trunk/qpid/cpp/src/qpid/broker/SemanticState.cpp 1493903
> /trunk/qpid/cpp/src/qpid/broker/SessionAdapter.h 1493903
> /trunk/qpid/cpp/src/qpid/broker/SessionAdapter.cpp 1493903
> /trunk/qpid/cpp/src/qpid/broker/SessionContext.h 1493903
> /trunk/qpid/cpp/src/qpid/broker/SessionHandler.h 1493903
> /trunk/qpid/cpp/src/qpid/broker/SessionHandler.cpp 1493903
> /trunk/qpid/cpp/src/qpid/broker/SessionState.h 1493903
> /trunk/qpid/cpp/src/qpid/broker/SessionState.cpp 1493903
> /trunk/qpid/cpp/src/qpid/broker/amqp/ManagedConnection.h 1493903
> /trunk/qpid/cpp/src/qpid/broker/amqp/ManagedConnection.cpp 1493903
> /trunk/qpid/cpp/src/qpid/broker/amqp/ManagedSession.h 1493903
> /trunk/qpid/cpp/src/qpid/broker/amqp/ManagedSession.cpp 1493903
> /trunk/qpid/cpp/src/qpid/broker/windows/SaslAuthenticator.cpp 1493903
> /trunk/qpid/cpp/src/qpid/ha/ReplicatingSubscription.cpp 1493903
> /trunk/qpid/cpp/src/qpid/management/ManagementAgent.h 1493903
> /trunk/qpid/cpp/src/qpid/management/ManagementAgent.cpp 1493903
> /trunk/qpid/cpp/src/qpid/sys/ConnectionOutputHandlerPtr.h 1493903
>
> Diff: https://reviews.apache.org/r/11944/diff/
>
>
> Testing
> -------
>
> cmake: make test
>
>
> Thanks,
>
> Andrew Stitcher
>
>
Re: Review Request: Continuation of Qpid C++ spring cleaning - QPID-4905
Posted by Gordon Sim <gs...@redhat.com>.
> On June 18, 2013, 9:08 p.m., Andrew Stitcher wrote:
> > I'm not especially attached the the terminology "Publisher", it comes from the pre-existing setPublisher() method on the Message. However, the purpose of this object is certainly to do with Authentication and Ownership of the "thing" that is publishing the message,
I think Publisher is a very poor name. At present that interface defines connection identity, with the identification of the publishing connection being the only concrete use. It could however just as well be used to identify the declaring connection for a queue.
That said, I am going to be doing work to separate some of the protocol independent stuff from the 0-10 connection anyway and would rather this gets committed so I can move on. I may change the name o f that interface as part of that.
- Gordon
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11944/#review22074
-----------------------------------------------------------
On June 18, 2013, 9:06 p.m., Andrew Stitcher wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11944/
> -----------------------------------------------------------
>
> (Updated June 18, 2013, 9:06 p.m.)
>
>
> Review request for qpid and Gordon Sim.
>
>
> Description
> -------
>
> This is a continuation of review 11628 - https://reviews.apache.org/r/11628/
>
> Included in this review is the last change there merging broker::Connection and broker::ConnectionState and a further change that tidies up the interface of the Connection/Message classes to the Broker management code. This introduces a protocol independent "Publisher" interface that can be queried for the userID/Url/ObjectId and OwnershipToken of a message publisher. This is used primarily in authenticating management messages.
>
>
> This addresses bug QPID-4905.
> https://issues.apache.org/jira/browse/QPID-4905
>
>
> Diffs
> -----
>
> /trunk/qpid/cpp/src/CMakeLists.txt 1493903
> /trunk/qpid/cpp/src/Makefile.am 1493903
> /trunk/qpid/cpp/src/qpid/broker/Bridge.h 1493903
> /trunk/qpid/cpp/src/qpid/broker/Bridge.cpp 1493903
> /trunk/qpid/cpp/src/qpid/broker/Broker.h 1493903
> /trunk/qpid/cpp/src/qpid/broker/Broker.cpp 1493903
> /trunk/qpid/cpp/src/qpid/broker/Connection.h 1493903
> /trunk/qpid/cpp/src/qpid/broker/Connection.cpp 1493903
> /trunk/qpid/cpp/src/qpid/broker/ConnectionHandler.cpp 1493903
> /trunk/qpid/cpp/src/qpid/broker/ConnectionState.h 1493903
> /trunk/qpid/cpp/src/qpid/broker/ConnectionState.cpp 1493903
> /trunk/qpid/cpp/src/qpid/broker/ConnectionToken.h 1493903
> /trunk/qpid/cpp/src/qpid/broker/HandlerImpl.h 1493903
> /trunk/qpid/cpp/src/qpid/broker/Message.h 1493903
> /trunk/qpid/cpp/src/qpid/broker/Message.cpp 1493903
> /trunk/qpid/cpp/src/qpid/broker/OwnershipToken.h 1493903
> /trunk/qpid/cpp/src/qpid/broker/Publisher.h PRE-CREATION
> /trunk/qpid/cpp/src/qpid/broker/Queue.cpp 1493903
> /trunk/qpid/cpp/src/qpid/broker/SaslAuthenticator.cpp 1493903
> /trunk/qpid/cpp/src/qpid/broker/SemanticState.cpp 1493903
> /trunk/qpid/cpp/src/qpid/broker/SessionAdapter.h 1493903
> /trunk/qpid/cpp/src/qpid/broker/SessionAdapter.cpp 1493903
> /trunk/qpid/cpp/src/qpid/broker/SessionContext.h 1493903
> /trunk/qpid/cpp/src/qpid/broker/SessionHandler.h 1493903
> /trunk/qpid/cpp/src/qpid/broker/SessionHandler.cpp 1493903
> /trunk/qpid/cpp/src/qpid/broker/SessionState.h 1493903
> /trunk/qpid/cpp/src/qpid/broker/SessionState.cpp 1493903
> /trunk/qpid/cpp/src/qpid/broker/amqp/ManagedConnection.h 1493903
> /trunk/qpid/cpp/src/qpid/broker/amqp/ManagedConnection.cpp 1493903
> /trunk/qpid/cpp/src/qpid/broker/amqp/ManagedSession.h 1493903
> /trunk/qpid/cpp/src/qpid/broker/amqp/ManagedSession.cpp 1493903
> /trunk/qpid/cpp/src/qpid/broker/windows/SaslAuthenticator.cpp 1493903
> /trunk/qpid/cpp/src/qpid/ha/ReplicatingSubscription.cpp 1493903
> /trunk/qpid/cpp/src/qpid/management/ManagementAgent.h 1493903
> /trunk/qpid/cpp/src/qpid/management/ManagementAgent.cpp 1493903
> /trunk/qpid/cpp/src/qpid/sys/ConnectionOutputHandlerPtr.h 1493903
>
> Diff: https://reviews.apache.org/r/11944/diff/
>
>
> Testing
> -------
>
> cmake: make test
>
>
> Thanks,
>
> Andrew Stitcher
>
>
Re: Review Request: Continuation of Qpid C++ spring cleaning - QPID-4905
Posted by Andrew Stitcher <as...@apache.org>.
> On June 18, 2013, 9:08 p.m., Andrew Stitcher wrote:
> > I'm not especially attached the the terminology "Publisher", it comes from the pre-existing setPublisher() method on the Message. However, the purpose of this object is certainly to do with Authentication and Ownership of the "thing" that is publishing the message,
>
> Gordon Sim wrote:
> I think Publisher is a very poor name. At present that interface defines connection identity, with the identification of the publishing connection being the only concrete use. It could however just as well be used to identify the declaring connection for a queue.
>
> That said, I am going to be doing work to separate some of the protocol independent stuff from the 0-10 connection anyway and would rather this gets committed so I can move on. I may change the name o f that interface as part of that.
I could certainly change the interfce name to ConnectionIdentity if you prefer.
- Andrew
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11944/#review22074
-----------------------------------------------------------
On June 18, 2013, 9:06 p.m., Andrew Stitcher wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11944/
> -----------------------------------------------------------
>
> (Updated June 18, 2013, 9:06 p.m.)
>
>
> Review request for qpid and Gordon Sim.
>
>
> Description
> -------
>
> This is a continuation of review 11628 - https://reviews.apache.org/r/11628/
>
> Included in this review is the last change there merging broker::Connection and broker::ConnectionState and a further change that tidies up the interface of the Connection/Message classes to the Broker management code. This introduces a protocol independent "Publisher" interface that can be queried for the userID/Url/ObjectId and OwnershipToken of a message publisher. This is used primarily in authenticating management messages.
>
>
> This addresses bug QPID-4905.
> https://issues.apache.org/jira/browse/QPID-4905
>
>
> Diffs
> -----
>
> /trunk/qpid/cpp/src/CMakeLists.txt 1493903
> /trunk/qpid/cpp/src/Makefile.am 1493903
> /trunk/qpid/cpp/src/qpid/broker/Bridge.h 1493903
> /trunk/qpid/cpp/src/qpid/broker/Bridge.cpp 1493903
> /trunk/qpid/cpp/src/qpid/broker/Broker.h 1493903
> /trunk/qpid/cpp/src/qpid/broker/Broker.cpp 1493903
> /trunk/qpid/cpp/src/qpid/broker/Connection.h 1493903
> /trunk/qpid/cpp/src/qpid/broker/Connection.cpp 1493903
> /trunk/qpid/cpp/src/qpid/broker/ConnectionHandler.cpp 1493903
> /trunk/qpid/cpp/src/qpid/broker/ConnectionState.h 1493903
> /trunk/qpid/cpp/src/qpid/broker/ConnectionState.cpp 1493903
> /trunk/qpid/cpp/src/qpid/broker/ConnectionToken.h 1493903
> /trunk/qpid/cpp/src/qpid/broker/HandlerImpl.h 1493903
> /trunk/qpid/cpp/src/qpid/broker/Message.h 1493903
> /trunk/qpid/cpp/src/qpid/broker/Message.cpp 1493903
> /trunk/qpid/cpp/src/qpid/broker/OwnershipToken.h 1493903
> /trunk/qpid/cpp/src/qpid/broker/Publisher.h PRE-CREATION
> /trunk/qpid/cpp/src/qpid/broker/Queue.cpp 1493903
> /trunk/qpid/cpp/src/qpid/broker/SaslAuthenticator.cpp 1493903
> /trunk/qpid/cpp/src/qpid/broker/SemanticState.cpp 1493903
> /trunk/qpid/cpp/src/qpid/broker/SessionAdapter.h 1493903
> /trunk/qpid/cpp/src/qpid/broker/SessionAdapter.cpp 1493903
> /trunk/qpid/cpp/src/qpid/broker/SessionContext.h 1493903
> /trunk/qpid/cpp/src/qpid/broker/SessionHandler.h 1493903
> /trunk/qpid/cpp/src/qpid/broker/SessionHandler.cpp 1493903
> /trunk/qpid/cpp/src/qpid/broker/SessionState.h 1493903
> /trunk/qpid/cpp/src/qpid/broker/SessionState.cpp 1493903
> /trunk/qpid/cpp/src/qpid/broker/amqp/ManagedConnection.h 1493903
> /trunk/qpid/cpp/src/qpid/broker/amqp/ManagedConnection.cpp 1493903
> /trunk/qpid/cpp/src/qpid/broker/amqp/ManagedSession.h 1493903
> /trunk/qpid/cpp/src/qpid/broker/amqp/ManagedSession.cpp 1493903
> /trunk/qpid/cpp/src/qpid/broker/windows/SaslAuthenticator.cpp 1493903
> /trunk/qpid/cpp/src/qpid/ha/ReplicatingSubscription.cpp 1493903
> /trunk/qpid/cpp/src/qpid/management/ManagementAgent.h 1493903
> /trunk/qpid/cpp/src/qpid/management/ManagementAgent.cpp 1493903
> /trunk/qpid/cpp/src/qpid/sys/ConnectionOutputHandlerPtr.h 1493903
>
> Diff: https://reviews.apache.org/r/11944/diff/
>
>
> Testing
> -------
>
> cmake: make test
>
>
> Thanks,
>
> Andrew Stitcher
>
>
Re: Review Request: Continuation of Qpid C++ spring cleaning - QPID-4905
Posted by Andrew Stitcher <as...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11944/#review22074
-----------------------------------------------------------
I'm not especially attached the the terminology "Publisher", it comes from the pre-existing setPublisher() method on the Message. However, the purpose of this object is certainly to do with Authentication and Ownership of the "thing" that is publishing the message,
- Andrew Stitcher
On June 18, 2013, 9:06 p.m., Andrew Stitcher wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11944/
> -----------------------------------------------------------
>
> (Updated June 18, 2013, 9:06 p.m.)
>
>
> Review request for qpid and Gordon Sim.
>
>
> Description
> -------
>
> This is a continuation of review 11628 - https://reviews.apache.org/r/11628/
>
> Included in this review is the last change there merging broker::Connection and broker::ConnectionState and a further change that tidies up the interface of the Connection/Message classes to the Broker management code. This introduces a protocol independent "Publisher" interface that can be queried for the userID/Url/ObjectId and OwnershipToken of a message publisher. This is used primarily in authenticating management messages.
>
>
> This addresses bug QPID-4905.
> https://issues.apache.org/jira/browse/QPID-4905
>
>
> Diffs
> -----
>
> /trunk/qpid/cpp/src/CMakeLists.txt 1493903
> /trunk/qpid/cpp/src/Makefile.am 1493903
> /trunk/qpid/cpp/src/qpid/broker/Bridge.h 1493903
> /trunk/qpid/cpp/src/qpid/broker/Bridge.cpp 1493903
> /trunk/qpid/cpp/src/qpid/broker/Broker.h 1493903
> /trunk/qpid/cpp/src/qpid/broker/Broker.cpp 1493903
> /trunk/qpid/cpp/src/qpid/broker/Connection.h 1493903
> /trunk/qpid/cpp/src/qpid/broker/Connection.cpp 1493903
> /trunk/qpid/cpp/src/qpid/broker/ConnectionHandler.cpp 1493903
> /trunk/qpid/cpp/src/qpid/broker/ConnectionState.h 1493903
> /trunk/qpid/cpp/src/qpid/broker/ConnectionState.cpp 1493903
> /trunk/qpid/cpp/src/qpid/broker/ConnectionToken.h 1493903
> /trunk/qpid/cpp/src/qpid/broker/HandlerImpl.h 1493903
> /trunk/qpid/cpp/src/qpid/broker/Message.h 1493903
> /trunk/qpid/cpp/src/qpid/broker/Message.cpp 1493903
> /trunk/qpid/cpp/src/qpid/broker/OwnershipToken.h 1493903
> /trunk/qpid/cpp/src/qpid/broker/Publisher.h PRE-CREATION
> /trunk/qpid/cpp/src/qpid/broker/Queue.cpp 1493903
> /trunk/qpid/cpp/src/qpid/broker/SaslAuthenticator.cpp 1493903
> /trunk/qpid/cpp/src/qpid/broker/SemanticState.cpp 1493903
> /trunk/qpid/cpp/src/qpid/broker/SessionAdapter.h 1493903
> /trunk/qpid/cpp/src/qpid/broker/SessionAdapter.cpp 1493903
> /trunk/qpid/cpp/src/qpid/broker/SessionContext.h 1493903
> /trunk/qpid/cpp/src/qpid/broker/SessionHandler.h 1493903
> /trunk/qpid/cpp/src/qpid/broker/SessionHandler.cpp 1493903
> /trunk/qpid/cpp/src/qpid/broker/SessionState.h 1493903
> /trunk/qpid/cpp/src/qpid/broker/SessionState.cpp 1493903
> /trunk/qpid/cpp/src/qpid/broker/amqp/ManagedConnection.h 1493903
> /trunk/qpid/cpp/src/qpid/broker/amqp/ManagedConnection.cpp 1493903
> /trunk/qpid/cpp/src/qpid/broker/amqp/ManagedSession.h 1493903
> /trunk/qpid/cpp/src/qpid/broker/amqp/ManagedSession.cpp 1493903
> /trunk/qpid/cpp/src/qpid/broker/windows/SaslAuthenticator.cpp 1493903
> /trunk/qpid/cpp/src/qpid/ha/ReplicatingSubscription.cpp 1493903
> /trunk/qpid/cpp/src/qpid/management/ManagementAgent.h 1493903
> /trunk/qpid/cpp/src/qpid/management/ManagementAgent.cpp 1493903
> /trunk/qpid/cpp/src/qpid/sys/ConnectionOutputHandlerPtr.h 1493903
>
> Diff: https://reviews.apache.org/r/11944/diff/
>
>
> Testing
> -------
>
> cmake: make test
>
>
> Thanks,
>
> Andrew Stitcher
>
>