[GitHub] [flink] lincoln-lil commented on a change in pull request #15117: [FLINK-21655] [table-planner-blink] Fix incorrect simplification for coalesce call on a groupingsets' result

[GitBox <gi...@apache.org>]

lincoln-lil commented on a change in pull request #15117:
URL: https://github.com/apache/flink/pull/15117#discussion_r594205345



##########
File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/plan/nodes/calcite/Expand.scala
##########
@@ -59,10 +60,13 @@ abstract class Expand(
     if (projects.size() <= 1) {
       return litmus.fail("Expand should output more than one rows, otherwise use Project.")
     }
-    if (projects.exists(_.size != outputRowType.getFieldCount)) {
+    if (null == outputFieldNames) {
+      return litmus.fail("Expand should have none empty output field names.")
+    }

Review comment:
       make sense




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org