You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Jim Apple (Code Review)" <ge...@cloudera.org> on 2017/02/14 06:48:11 UTC
[Impala-ASF-CR](asf-site) A blog post about IMPALA-4916
Jim Apple has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5995
Change subject: A blog post about IMPALA-4916
......................................................................
A blog post about IMPALA-4916
While I'm here, fix IMPALA-4928 and allow the install instructions to
work on Linux.
Change-Id: Ifa90bf5621ef6466a4821f77a6e8a8b20c5512ae
---
M blog/2017/index.html
M blog/archive.html
M blog/index.html
M blog/posts/impala-blog-coming-soon/index.html
M blog/sitemap.xml
M blog/sitemapindex.xml
A nikola_site_generator/posts/where-did-i-leave-my-keys.md
M nikola_site_generator/requirements.txt
8 files changed, 195 insertions(+), 12 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/95/5995/1
--
To view, visit http://gerrit.cloudera.org:8080/5995
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifa90bf5621ef6466a4821f77a6e8a8b20c5512ae
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-Owner: Jim Apple <jb...@apache.org>
[Impala-ASF-CR](asf-site) A blog post about IMPALA-4916
Posted by "Michael Brown (Code Review)" <ge...@cloudera.org>.
Michael Brown has posted comments on this change.
Change subject: A blog post about IMPALA-4916
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5995/1/nikola_site_generator/posts/where-did-i-leave-my-keys.md
File nikola_site_generator/posts/where-did-i-leave-my-keys.md:
PS1, Line 44: s.__iter__()
Nitiest of nits: while this is legal, and __iter__ is the method that returns an object's iterator, the proper way to do this is iter(s).next() . I realize this is on code not intended to work anyway...
--
To view, visit http://gerrit.cloudera.org:8080/5995
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifa90bf5621ef6466a4821f77a6e8a8b20c5512ae
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR](asf-site) A blog post about IMPALA-4916
Posted by "David Knupp (Code Review)" <ge...@cloudera.org>.
David Knupp has posted comments on this change.
Change subject: A blog post about IMPALA-4916
......................................................................
Patch Set 3: Code-Review+1
Agreed.
--
To view, visit http://gerrit.cloudera.org:8080/5995
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifa90bf5621ef6466a4821f77a6e8a8b20c5512ae
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR](asf-site) A blog post about IMPALA-4916
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has abandoned this change. ( http://gerrit.cloudera.org:8080/5995 )
Change subject: A blog post about IMPALA-4916
......................................................................
Abandoned
--
To view, visit http://gerrit.cloudera.org:8080/5995
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-MessageType: abandon
Gerrit-Change-Id: Ifa90bf5621ef6466a4821f77a6e8a8b20c5512ae
Gerrit-Change-Number: 5995
Gerrit-PatchSet: 3
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
[Impala-ASF-CR](asf-site) A blog post about IMPALA-4916
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change.
Change subject: A blog post about IMPALA-4916
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5995/1/nikola_site_generator/posts/where-did-i-leave-my-keys.md
File nikola_site_generator/posts/where-did-i-leave-my-keys.md:
PS1, Line 43: sets_contain_their_eleme
> I think cut-and-paste code from Impala could be a special case.
PS2 did change to underscores, but left two spaces.
--
To view, visit http://gerrit.cloudera.org:8080/5995
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifa90bf5621ef6466a4821f77a6e8a8b20c5512ae
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR](asf-site) A blog post about IMPALA-4916
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has uploaded a new patch set (#3).
Change subject: A blog post about IMPALA-4916
......................................................................
A blog post about IMPALA-4916
The work I authored is in nikola_site_generator/; blog/ contains the
content that Nikola generated from nikola_site_generator/, via 'nikola
build'.
While I'm here, fix IMPALA-4928 and allow the install instructions to
work on Linux.
Change-Id: Ifa90bf5621ef6466a4821f77a6e8a8b20c5512ae
---
M blog/2017/index.html
M blog/archive.html
A blog/authors/impala-dev/index.html
A blog/authors/index.html
A blog/authors/jim-apple/index.html
M blog/index.html
M blog/posts/impala-blog-coming-soon/index.html
A blog/posts/where-did-i-leave-my-keys/index.html
A blog/posts/where-did-i-leave-my-keys/index.md
M blog/sitemap.xml
M blog/sitemapindex.xml
A nikola_site_generator/posts/where-did-i-leave-my-keys.md
M nikola_site_generator/requirements.txt
13 files changed, 935 insertions(+), 12 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/95/5995/3
--
To view, visit http://gerrit.cloudera.org:8080/5995
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ifa90bf5621ef6466a4821f77a6e8a8b20c5512ae
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
[Impala-ASF-CR](asf-site) A blog post about IMPALA-4916
Posted by "David Knupp (Code Review)" <ge...@cloudera.org>.
David Knupp has posted comments on this change.
Change subject: A blog post about IMPALA-4916
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/5995/1//COMMIT_MSG
Commit Message:
PS1, Line 7: A blog post about IMPALA-4916
It might be helpful to specify which files contain the actual article content, and which files were auto-generated by the framework. I.e., it might not be immediately obvious to people that the .md file is the main one to focus upon.
http://gerrit.cloudera.org:8080/#/c/5995/1/nikola_site_generator/requirements.txt
File nikola_site_generator/requirements.txt:
PS1, Line 9:
Have you tested that after removing this, nikola still works on a Mac?
--
To view, visit http://gerrit.cloudera.org:8080/5995
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifa90bf5621ef6466a4821f77a6e8a8b20c5512ae
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR](asf-site) A blog post about IMPALA-4916
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change.
Change subject: A blog post about IMPALA-4916
......................................................................
Patch Set 1:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/5995/1//COMMIT_MSG
Commit Message:
PS1, Line 7: A blog post about IMPALA-4916
> It might be helpful to specify which files contain the actual article conte
Done
http://gerrit.cloudera.org:8080/#/c/5995/1/nikola_site_generator/posts/where-did-i-leave-my-keys.md
File nikola_site_generator/posts/where-did-i-leave-my-keys.md:
PS1, Line 43: SetsContainTheirElements
> Minor stylistic point. Let's follow strict PEP-8 for blog posts. PEP-8 call
I'v changed it to more closely match to code in tests/. To encourage developers to write blog posts, I'd suggest we should make it as easy as possible, partially by not requiring them to set up new editor defaults for Python style. This is especially true if someone wants to post about some Python code already in Impala - presumably they wouldn't rewrite it to match PEP-8. What do you think?
PS1, Line 44: s.__iter__()
> Nitiest of nits: while this is legal, and __iter__ is the method that retur
Thanks! The double underscore was bothering me.
http://gerrit.cloudera.org:8080/#/c/5995/1/nikola_site_generator/requirements.txt
File nikola_site_generator/requirements.txt:
PS1, Line 9:
> Have you tested that after removing this, nikola still works on a Mac?
Good point; I have not. I have now gone through my list of general purpose computing devices I have logins for and realized that not a single one is a Mac(!). Do you have a Mac with a Python environment that is compatible with testing this?
--
To view, visit http://gerrit.cloudera.org:8080/5995
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifa90bf5621ef6466a4821f77a6e8a8b20c5512ae
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR](asf-site) A blog post about IMPALA-4916
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change.
Change subject: A blog post about IMPALA-4916
......................................................................
Patch Set 1:
I'm not planning on committing this until I talk to a few other contributors and see if they would be interested in blogging from time to time.
--
To view, visit http://gerrit.cloudera.org:8080/5995
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifa90bf5621ef6466a4821f77a6e8a8b20c5512ae
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-HasComments: No
[Impala-ASF-CR](asf-site) A blog post about IMPALA-4916
Posted by "Laszlo Gaal (Code Review)" <ge...@cloudera.org>.
Laszlo Gaal has posted comments on this change.
Change subject: A blog post about IMPALA-4916
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5995/3/nikola_site_generator/posts/where-did-i-leave-my-keys.md
File nikola_site_generator/posts/where-did-i-leave-my-keys.md:
PS3, Line 91: le
Nit: I believe these characters were swapped
--
To view, visit http://gerrit.cloudera.org:8080/5995
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifa90bf5621ef6466a4821f77a6e8a8b20c5512ae
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR](asf-site) A blog post about IMPALA-4916
Posted by "David Knupp (Code Review)" <ge...@cloudera.org>.
David Knupp has posted comments on this change.
Change subject: A blog post about IMPALA-4916
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/5995/1/nikola_site_generator/posts/where-did-i-leave-my-keys.md
File nikola_site_generator/posts/where-did-i-leave-my-keys.md:
PS1, Line 43: SetsContainTheirElements
Minor stylistic point. Let's follow strict PEP-8 for blog posts. PEP-8 calls for 4 space indents, stipulates that only classes are capitalized, and also advises against camel case for function names.
PS1, Line 50: s.add(set())
This will throw an exception. You can't add a set to a set. Members of sets, like keys in dictionaries, need to be hashable, and so can't be mutable types.
>>> s = set()
>>> s.add(set())
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
TypeError: unhashable type: 'set'
--
To view, visit http://gerrit.cloudera.org:8080/5995
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifa90bf5621ef6466a4821f77a6e8a8b20c5512ae
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR](asf-site) A blog post about IMPALA-4916
Posted by "David Knupp (Code Review)" <ge...@cloudera.org>.
David Knupp has posted comments on this change.
Change subject: A blog post about IMPALA-4916
......................................................................
Patch Set 3:
(1 comment)
So, I believe that all of the pages still point to the old blog site. This patch doesn't seem to address that just yet. Was that by intention?
http://gerrit.cloudera.org:8080/#/c/5995/1/nikola_site_generator/requirements.txt
File nikola_site_generator/requirements.txt:
PS1, Line 9:
> Good point; I have not. I have now gone through my list of general purpose
I tried setting up a new environment using this requirements.txt, and nikola still seems to work fine. So I'm OK with this.
--
To view, visit http://gerrit.cloudera.org:8080/5995
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifa90bf5621ef6466a4821f77a6e8a8b20c5512ae
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR](asf-site) A blog post about IMPALA-4916
Posted by "David Knupp (Code Review)" <ge...@cloudera.org>.
David Knupp has posted comments on this change.
Change subject: A blog post about IMPALA-4916
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5995/1/nikola_site_generator/posts/where-did-i-leave-my-keys.md
File nikola_site_generator/posts/where-did-i-leave-my-keys.md:
PS1, Line 43: SetsContainTheirElements
> PS2 did change to underscores, but left two spaces.
Works for me.
--
To view, visit http://gerrit.cloudera.org:8080/5995
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifa90bf5621ef6466a4821f77a6e8a8b20c5512ae
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR](asf-site) A blog post about IMPALA-4916
Posted by "David Knupp (Code Review)" <ge...@cloudera.org>.
David Knupp has posted comments on this change.
Change subject: A blog post about IMPALA-4916
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5995/1/nikola_site_generator/posts/where-did-i-leave-my-keys.md
File nikola_site_generator/posts/where-did-i-leave-my-keys.md:
PS1, Line 50: s.add(set())
> This will throw an exception. You can't add a set to a set. Members of sets
Sorry -- didn't read far enough. :-/
--
To view, visit http://gerrit.cloudera.org:8080/5995
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifa90bf5621ef6466a4821f77a6e8a8b20c5512ae
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR](asf-site) A blog post about IMPALA-4916
Posted by "Michael Brown (Code Review)" <ge...@cloudera.org>.
Michael Brown has posted comments on this change.
Change subject: A blog post about IMPALA-4916
......................................................................
Patch Set 1:
This is interesting. How would I see the rendered blog?
--
To view, visit http://gerrit.cloudera.org:8080/5995
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifa90bf5621ef6466a4821f77a6e8a8b20c5512ae
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR](asf-site) A blog post about IMPALA-4916
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change.
Change subject: A blog post about IMPALA-4916
......................................................................
Patch Set 3:
> (1 comment)
>
> So, I believe that all of the pages still point to the old blog
> site. This patch doesn't seem to address that just yet. Was that by
> intention?
It wasn't but now that I'm thinking about it, I'd say this might be the right option. Maybe we should get a few posts +2ed and ready to commit, as well as a sustainable cadence going, before posting. What do you think?
--
To view, visit http://gerrit.cloudera.org:8080/5995
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifa90bf5621ef6466a4821f77a6e8a8b20c5512ae
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR](asf-site) A blog post about IMPALA-4916
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has uploaded a new patch set (#2).
Change subject: A blog post about IMPALA-4916
......................................................................
A blog post about IMPALA-4916
The work I authored is in nikola_site_generator/; blog/ contains the
content that Nikola generated from nikola_site_generator/, via 'nikola
build'.
While I'm here, fix IMPALA-4928 and allow the install instructions to
work on Linux.
Change-Id: Ifa90bf5621ef6466a4821f77a6e8a8b20c5512ae
---
M blog/2017/index.html
M blog/archive.html
M blog/index.html
M blog/posts/impala-blog-coming-soon/index.html
M blog/sitemap.xml
M blog/sitemapindex.xml
A nikola_site_generator/posts/where-did-i-leave-my-keys.md
M nikola_site_generator/requirements.txt
8 files changed, 195 insertions(+), 12 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/95/5995/2
--
To view, visit http://gerrit.cloudera.org:8080/5995
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ifa90bf5621ef6466a4821f77a6e8a8b20c5512ae
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
[Impala-ASF-CR](asf-site) A blog post about IMPALA-4916
Posted by "David Knupp (Code Review)" <ge...@cloudera.org>.
David Knupp has posted comments on this change.
Change subject: A blog post about IMPALA-4916
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5995/1/nikola_site_generator/posts/where-did-i-leave-my-keys.md
File nikola_site_generator/posts/where-did-i-leave-my-keys.md:
PS1, Line 43: SetsContainTheirElements
> I'v changed it to more closely match to code in tests/. To encourage develo
I think cut-and-paste code from Impala could be a special case.
FWIW, if I scan a blog post involving python code, and I see that the author hasn't followed commonly recognized PEP-8 conventions, it immediately colors how I read piece. Like, I immediately become a little skeptical. I'd at least change the function names to sets_contain_their_elements and change_keys, respectively.
--
To view, visit http://gerrit.cloudera.org:8080/5995
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifa90bf5621ef6466a4821f77a6e8a8b20c5512ae
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR](asf-site) A blog post about IMPALA-4916
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change.
Change subject: A blog post about IMPALA-4916
......................................................................
Patch Set 3:
PS3 was because I forgot in PS1 and PS2 to include the actual blog post HTML.
--
To view, visit http://gerrit.cloudera.org:8080/5995
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifa90bf5621ef6466a4821f77a6e8a8b20c5512ae
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-HasComments: No