[GitHub] [incubator-superset] graceguo-supercat commented on a change in pull request #10363: chore: uniform icons across list views

[GitBox <gi...@apache.org>]

graceguo-supercat commented on a change in pull request #10363:
URL: https://github.com/apache/incubator-superset/pull/10363#discussion_r457730841



##########
File path: superset-frontend/src/views/dashboardList/DashboardList.tsx
##########
@@ -173,7 +174,7 @@ class DashboardList extends React.PureComponent<Props, State> {
         },
       }: any) => (
         <span className="no-wrap">
-          {published ? <i className="fa fa-check" /> : ''}
+          {published ? <i className="fa fa-check text-muted" /> : ''}

Review comment:
       +1 this. I think we should move to use our own svg/Icon component and finally remove Font Awesome. otherwise, i always feel confused which icon to use :(




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org