You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "eddelbuettel (via GitHub)" <gi...@apache.org> on 2026/01/30 23:55:31 UTC
[PR] Use R_hasAttrib (from R 4.6.0 or later) to avoid ATTRIB [arrow-nanoarrow]
eddelbuettel opened a new pull request, #842:
URL: https://github.com/apache/arrow-nanoarrow/pull/842
It looks like CRAN is unhappy about a remaining use of `ATTRIB`. Having dealt with that myself, I think that `R_hasAttrib()`, added in R 4.6.0, should be a fine replacement for you. I am not 100% sure it is ALTREP-safe --- it says neither yay nor nay --- but I think it is as it does pretty much you do here:
```
bool R_hasAttrib(SEXP x, SEXP name)
{
if (isScalarString(name)) name = installTrChar(STRING_ELT(name, 0));
if (! isSymbol(name))
error(_("'name' is not a symbol or a scalar string"));
if (name == R_NamesSymbol && isListWithNames(x))
return true;
SEXP attr = ATTRIB(x);
while (attr != R_NilValue) {
if (TAG(attr) == name)
return true;
attr = CDR(attr);
}
return false;
}
```
(The PR also adds an `importFrom` as R(-devel) CMD check complained.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use R_hasAttrib (from R 4.6.0 or later) to avoid ATTRIB [arrow-nanoarrow]
Posted by "paleolimbot (via GitHub)" <gi...@apache.org>.
paleolimbot commented on PR #842:
URL: https://github.com/apache/arrow-nanoarrow/pull/842#issuecomment-3835488743
Agreed, sorry. I should have updated the NEWS file for the patch releases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use R_hasAttrib (from R 4.6.0 or later) to avoid ATTRIB [arrow-nanoarrow]
Posted by "eddelbuettel (via GitHub)" <gi...@apache.org>.
eddelbuettel commented on PR #842:
URL: https://github.com/apache/arrow-nanoarrow/pull/842#issuecomment-3831161312
Thanks for shepherding it to CRAN!
One thing that is a little ... weird is that I cannot find a list of changes defining 0.7.0-3-1 anywhere. Not here, not in releases, not in the package. There is one for 0.7.0-1 but that is also superceeded twice, "Not ideal." Anyway, and while I presume this gets filled in for 0.8.0 it would be nice to keep the log of changes current too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use R_hasAttrib (from R 4.6.0 or later) to avoid ATTRIB [arrow-nanoarrow]
Posted by "eddelbuettel (via GitHub)" <gi...@apache.org>.
eddelbuettel commented on PR #842:
URL: https://github.com/apache/arrow-nanoarrow/pull/842#issuecomment-3848885692
Yes I was glancing at the branch and eyeballing NEWS there. Will branch off maint-0.8.0 here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use R_hasAttrib (from R 4.6.0 or later) to avoid ATTRIB [arrow-nanoarrow]
Posted by "eddelbuettel (via GitHub)" <gi...@apache.org>.
eddelbuettel commented on PR #842:
URL: https://github.com/apache/arrow-nanoarrow/pull/842#issuecomment-3847973706
I see you are hard at work for 0.8.0 which is great -- you could mention this one (ie #842) along with your earlier #826.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use R_hasAttrib (from R 4.6.0 or later) to avoid ATTRIB [arrow-nanoarrow]
Posted by "paleolimbot (via GitHub)" <gi...@apache.org>.
paleolimbot merged PR #842:
URL: https://github.com/apache/arrow-nanoarrow/pull/842
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use R_hasAttrib (from R 4.6.0 or later) to avoid ATTRIB [arrow-nanoarrow]
Posted by "paleolimbot (via GitHub)" <gi...@apache.org>.
paleolimbot commented on PR #842:
URL: https://github.com/apache/arrow-nanoarrow/pull/842#issuecomment-3848251649
> you could mention this one (ie https://github.com/apache/arrow-nanoarrow/pull/842) along with your earlier https://github.com/apache/arrow-nanoarrow/pull/826.
I'm not sure exactly what you mean here but feel free to make a PR! If you're specifically referring to the NEWS in the maintenance branch, you can PR into `maint-0.8.0`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org