You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/09/15 18:00:43 UTC

[GitHub] [tvm] jroesch commented on a change in pull request #8849: [5/6] Arm(R) Ethos(TM)-U NPU codegen integration

jroesch commented on a change in pull request #8849:
URL: https://github.com/apache/tvm/pull/8849#discussion_r709441749



##########
File path: src/tir/transforms/lower_tvm_builtin.cc
##########
@@ -113,16 +113,6 @@ class BuiltinLower : public StmtExprMutator {
     op = stmt.as<AllocateNode>();
     // Get constant allocation bound.
     int64_t nbytes = GetVectorBytes(op->dtype);
-    if (device_type_.defined()) {

Review comment:
       cc @areusch @mbrookhart this is the code we discussed yesterday, currently CI passes with this code? that seems to contradict the conversations we had, but also I think these should be stack allocations for performance on cloud cpus.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org