[jira] [Commented] (NIFI-4816) Changes to ReportingTask name are not available to the ReportingTask

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NIFI-4816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16354204#comment-16354204 ] 

ASF GitHub Bot commented on NIFI-4816:
--------------------------------------

GitHub user mattyb149 opened a pull request:

    https://github.com/apache/nifi/pull/2452

    NIFI-4816: Allow name to be updated for ReportingTasks

    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [x] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
    - [x] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
    - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mattyb149/nifi NIFI-4816

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/2452.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2452
    
----
commit 32d8069a053e2468bd8d6bf7232954572732e391
Author: Matthew Burgess <ma...@...>
Date:   2018-02-06T17:11:45Z

    NIFI-4816: Allow name to be updated for ReportingTasks

----


> Changes to ReportingTask name are not available to the ReportingTask
> --------------------------------------------------------------------
>
>                 Key: NIFI-4816
>                 URL: https://issues.apache.org/jira/browse/NIFI-4816
>             Project: Apache NiFi
>          Issue Type: Bug
>          Components: Core Framework, Extensions
>            Reporter: Matt Burgess
>            Assignee: Matt Burgess
>            Priority: Major
>
> The Reporting Task name is only set on the ReportingTask itself during initialize(), which is only called the first time the ReportingTask is instantiated. This means if you change the name of the ReportingTask and restart it, The ReportingTask has its original name and the current name is inaccessible via the ConfigurationContext it is passed later. If you restart NiFi, the new name is set and stays that way.
> Rather than calling initialize() more than once, it is proposed to make the current name (and any other appropriate properties) available perhaps via ConfigurationContext which is passed to methods annotated with OnScheduled.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)