You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2022/02/22 03:49:21 UTC

[GitHub] [zookeeper] iamgd67 opened a new pull request #1818: ZOOKEEPER-4473: zooInspector root child creates fail with path validate fix

iamgd67 opened a new pull request #1818:
URL: https://github.com/apache/zookeeper/pull/1818


   zooInspector root child creates fail with path validate fix.
   create node update UI only if creation success, if fail show message dialog about the reason.
   add basic ZooInspectorManagerImpl tests using mocked zookeeper client.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zookeeper] iamgd67 commented on pull request #1818: ZOOKEEPER-4473: zooInspector root child creates fail with path validate fix

Posted by GitBox <gi...@apache.org>.
iamgd67 commented on pull request #1818:
URL: https://github.com/apache/zookeeper/pull/1818#issuecomment-1049376686


   @eolivelli are we waiting for more reviews?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zookeeper] iamgd67 commented on pull request #1818: ZOOKEEPER-4473: zooInspector root child creates fail with path validate fix

Posted by GitBox <gi...@apache.org>.
iamgd67 commented on pull request #1818:
URL: https://github.com/apache/zookeeper/pull/1818#issuecomment-1047444782


   CPP unit test failed, should be unrelated


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zookeeper] iamgd67 commented on pull request #1818: ZOOKEEPER-4473: zooInspector root child creates fail with path validate fix

Posted by GitBox <gi...@apache.org>.
iamgd67 commented on pull request #1818:
URL: https://github.com/apache/zookeeper/pull/1818#issuecomment-1054929299


   ping @symat for review


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zookeeper] symat commented on pull request #1818: ZOOKEEPER-4473: zooInspector root child creates fail with path validate fix

Posted by GitBox <gi...@apache.org>.
symat commented on pull request #1818:
URL: https://github.com/apache/zookeeper/pull/1818#issuecomment-1059178826


   I'll merge this to master, and branch-3.8 (will be released in 3.8.1, as the release of 3.8.0 is finished already)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zookeeper] iamgd67 closed pull request #1818: ZOOKEEPER-4473: zooInspector root child creates fail with path validate fix

Posted by GitBox <gi...@apache.org>.
iamgd67 closed pull request #1818:
URL: https://github.com/apache/zookeeper/pull/1818


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zookeeper] iamgd67 commented on pull request #1818: ZOOKEEPER-4473: zooInspector root child creates fail with path validate fix

Posted by GitBox <gi...@apache.org>.
iamgd67 commented on pull request #1818:
URL: https://github.com/apache/zookeeper/pull/1818#issuecomment-1059030825


   @eolivelli are we going to merge this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zookeeper] iamgd67 commented on pull request #1818: zooInspector root child creates fail with path validate fix

Posted by GitBox <gi...@apache.org>.
iamgd67 commented on pull request #1818:
URL: https://github.com/apache/zookeeper/pull/1818#issuecomment-1047387949


   without this fix, creation will fail with 
   `java.lang.IllegalArgumentException: Invalid path string "//test" caused by empty node name specified @1`
   
   link to Jira too [ZOOKEEPER-4473](https://issues.apache.org/jira/browse/ZOOKEEPER-4473)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zookeeper] symat commented on pull request #1818: ZOOKEEPER-4473: zooInspector root child creates fail with path validate fix

Posted by GitBox <gi...@apache.org>.
symat commented on pull request #1818:
URL: https://github.com/apache/zookeeper/pull/1818#issuecomment-1059186043


   merged, thanks for the contribution!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zookeeper] asfgit closed pull request #1818: ZOOKEEPER-4473: zooInspector root child creates fail with path validate fix

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #1818:
URL: https://github.com/apache/zookeeper/pull/1818


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org