You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@sling.apache.org by GitBox <gi...@apache.org> on 2022/01/13 01:04:28 UTC

[GitHub] [sling-org-apache-sling-repoinit-parser] klcodanr commented on pull request #14: SLING-10952 - Adding support for whitespace characters in group names

klcodanr commented on pull request #14:
URL: https://github.com/apache/sling-org-apache-sling-repoinit-parser/pull/14#issuecomment-1011611802


   @anchela Good points.
   
   Re:Naming, would you have any suggestion on the name for this class / the related tokens and methods given that it is used for Authorizable ID's and Principal Names?
   
   It feels like it may be easiest / most logical to call it PrincipalName (e.g. PrincipalNameUtil / principalName / principalName()) as long as that's not confusing since it an also be an Authorizable ID. 
   
   Would you agree?
   
   Re:the other changes I'll make those and send an update. 
   
   Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org