[GitHub] [spark] amaliujia commented on a diff in pull request #40109: [SPARK-42522][CONNECT] Fix DataFrameWriterV2 to find the default source

["amaliujia (via GitHub)" <gi...@apache.org>]

amaliujia commented on code in PR #40109:
URL: https://github.com/apache/spark/pull/40109#discussion_r1114755349


##########
connector/connect/common/src/main/protobuf/spark/connect/commands.proto:
##########
@@ -128,7 +128,7 @@ message WriteOperationV2 {
 
   // (Optional) A provider for the underlying output data source. Spark's default catalog supports
   // "parquet", "json", etc.
-  string provider = 3;
+  optional string provider = 3;

Review Comment:
   There is no need for `optional`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org