You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2019/12/24 05:47:37 UTC
[GitHub] [incubator-dolphinscheduler] break60 opened a new pull request
#1546: Front-end third-party js, css introduced using npm
break60 opened a new pull request #1546: Front-end third-party js, css introduced using npm
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1546
## *Tips*
- *Thanks very much for contributing to Apache DolphinScheduler.*
- *Please review https://dolphinscheduler.apache.org/en-us/community/index.html before opening a pull request.*
## What is the purpose of the pull request
*(For example: This pull request adds checkstyle plugin.)*
## Brief change log
*(for example:)*
- *Add maven-checkstyle-plugin to root pom.xml*
## Verify this pull request
*(Please pick either of the following options)*
This pull request is code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
*(example:)*
- *Added dolphinscheduler-dao tests for end-to-end.*
- *Added CronUtilsTest to verify the change.*
- *Manually verified the change by testing locally.*
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] codecov-io commented on issue #1546:
Front-end third-party js, css introduced using npm
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #1546: Front-end third-party js, css introduced using npm
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1546#issuecomment-568663165
# [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1546?src=pr&el=h1) Report
> Merging [#1546](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1546?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/41858fdb0b3a7a4ce5ceff85489c307804a923c1?src=pr&el=desc) will **increase** coverage by `0.37%`.
> The diff coverage is `91.42%`.
[](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1546?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #1546 +/- ##
========================================
+ Coverage 7.42% 7.79% +0.37%
========================================
Files 272 272
Lines 13634 13641 +7
Branches 2169 2166 -3
========================================
+ Hits 1012 1063 +51
+ Misses 12555 12506 -49
- Partials 67 72 +5
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1546?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [.../org/apache/dolphinscheduler/api/enums/Status.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1546/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL2VudW1zL1N0YXR1cy5qYXZh) | `100% <ø> (ø)` | :arrow_up: |
| [.../dolphinscheduler/server/utils/SparkArgsUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1546/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3V0aWxzL1NwYXJrQXJnc1V0aWxzLmphdmE=) | `92.15% <91.42%> (+92.15%)` | :arrow_up: |
| [...apache/dolphinscheduler/api/enums/ExecuteType.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1546/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL2VudW1zL0V4ZWN1dGVUeXBlLmphdmE=) | `66.66% <0%> (+66.66%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1546?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1546?src=pr&el=footer). Last update [41858fd...27ce4ac](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1546?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services