You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@echarts.apache.org by tan zhongyi <zh...@gmail.com> on 2019/09/03 09:49:30 UTC
Re: [VOTE] Release Apache brpc(incubating) 0.9.6-rc02
Hi， jiashun，
Your task is more complicated，
Please call me if you have any question,
Thanks.
1. Src/brpc/callback.h. original from google/protobuf/stubs/common.h. suggest to add its original copyright/license to the very first of file
https://github.com/protocolbuffers/protobuf/blob/master/src/google/protobuf/stubs/common.h
2. src/bthread/context.cpp
src/bthread/context.h
the same as item 1.
3. src/brpc/details/tcmalloc_extension.cpp please add standard apache header
4. src/butil/linux_magic.h please add standard apache header
5. src/butil/intrusive_ptr.hpp the same as item 1
See http://www.boost.org/libs/smart_ptr/intrusive_ptr.html
6. src/butil/recordio.cc please add standard apache header
7. src/butil/unique_ptr.h the same as item 1.
1. src/butil/third_party/modp_b64/modp_b64_data.h
This file has no header, please find its original source, and add license header accordingly.
9. src/butyl/third_party/rapidjson/internal/*.*
MIT license, tencent copyright, it is safe, leave it
发件人: tan zhongyi <je...@apache.org>
日期: 2019年9月2日 星期一 下午4:12
收件人: JiashunZhu <zh...@gmail.com>, "Tang,Hui(EE)" <ta...@baidu.com>, "dev@brpc.apache.org" <de...@brpc.apache.org>
主题: Re: [VOTE] Release Apache brpc(incubating) 0.9.6-rc02
Hi， guys，
According to apache release policy，
http://www.apache.org/legal/src-headers.html#headers
that all source files that created by brpc author need to add apache header file
and for third-party files which are not created by brpc author need to keep their copyright & license.
So I divide the files into three tasks:
1. Add missing apache header for scripts ( I will do it)
• build_in_travis_ci.sh
• config_brpc.sh
• example/multi_threaded_echo_fns_c++/random_kill.sh
• tools/add_syntax_equal_proto2_to_all.sh
• test/run_tests.sh
2. add missing header for c++ files under test directory and tools ( @Tang,Hui(EE)<ma...@baidu.com>, can you do that?)
test/bthread_sched_yield_unittest.cpp
test/file_watcher_unittest.cpp
test/recordio_unittest.cpp
test/string_splitter_unittest.cpp
tools/print_gcc_version.cc
tools/rpc_press/client.py
3. modified cc files that under src directory (@JiashunZhu<ma...@gmail.com>, can you work on that?)
src/brpc/callback.h
src/bthread/context.cpp
src/bthread/context.h
src/brpc/details/tcmalloc_extension.cpp
src/butil/linux_magic.h
src/butil/intrusive_ptr.hpp
src/butil/recordio.cc
src/butil/third_party/modp_b64/modp_b64_data.h
src/butil/third_party/rapidjson/internal/biginteger.h
src/butil/third_party/rapidjson/internal/diyfp.h
src/butil/third_party/rapidjson/internal/dtoa.h
src/butil/third_party/rapidjson/internal/ieee754.h
src/butil/third_party/rapidjson/internal/itoa.h
src/butil/third_party/rapidjson/internal/meta.h
src/butil/third_party/rapidjson/internal/pow10.h
src/butil/third_party/rapidjson/internal/stack.h
src/butil/third_party/rapidjson/internal/strfunc.h
src/butil/third_party/rapidjson/internal/strtod.h
src/butil/unique_ptr.h
发件人: JiashunZhu <zh...@gmail.com>
日期: 2019年8月30日 星期五 下午1:02
收件人: tan zhongyi <zh...@gmail.com>
抄送: "dev@brpc.apache.org" <de...@brpc.apache.org>
主题: Re: [VOTE] Release Apache brpc(incubating) 0.9.6-rc02
OK. I will build rc3 after all problems are solved.
tan zhongyi <zh...@gmail.com>> 于2019年8月29日周四 下午7:22写道：
Thanks， tangjie，
It seems that we have missed some third-party's file,
We need to check them again.
-1 , vote closed as not Go.
@JiashunZhu, we need to check these files one by one and build rc3 later.
BTW: JB, please cancel your investigation and focus on the next rc3 release , thanks
在 2019/8/29 下午2:02，“Tang,Jie(EE)”<ta...@baidu.com>> 写入:
A list of 30 files without license header, including CPP and shell, was compiled by Rat tool.
1. Rat tool will have false alarms and do some filtering work.
2. Makefile, markdown file, refer to other Apache projects without license, there is no license.
This is files list:
build_in_travis_ci.sh
config_brpc.sh
example/multi_threaded_echo_fns_c++/random_kill.sh
src/brpc/callback.h
src/bthread/context.cpp
src/bthread/context.h
src/brpc/details/tcmalloc_extension.cpp
src/butil/linux_magic.h
src/butil/intrusive_ptr.hpp
src/butil/recordio.cc
src/butil/third_party/modp_b64/modp_b64_data.h
src/butil/third_party/rapidjson/internal/biginteger.h
src/butil/third_party/rapidjson/internal/diyfp.h
src/butil/third_party/rapidjson/internal/dtoa.h
src/butil/third_party/rapidjson/internal/ieee754.h
src/butil/third_party/rapidjson/internal/itoa.h
src/butil/third_party/rapidjson/internal/meta.h
src/butil/third_party/rapidjson/internal/pow10.h
src/butil/third_party/rapidjson/internal/stack.h
src/butil/third_party/rapidjson/internal/strfunc.h
src/butil/third_party/rapidjson/internal/strtod.h
src/butil/unique_ptr.h
test/bthread_sched_yield_unittest.cpp
test/file_watcher_unittest.cpp
test/recordio_unittest.cpp
test/run_tests.sh
test/string_splitter_unittest.cpp
tools/add_syntax_equal_proto2_to_all.sh
tools/print_gcc_version.cc
tools/rpc_press/client.py
在 2019/8/14 下午9:46，“tan zhongyi”<zh...@gmail.com>> 写入:
Hi, guys,
another round of vote begins
I am pleased to be calling this vote for the release of apache brpc(incubating) 0.9.6-rc02.
The source code can be found at:
https://dist.apache.org/repos/dist/dev/incubator/brpc/0.9.6-rc02/apache-brpc-0.9.6.rc02-incubating-src.tar.gz
The release candidate has been tagged in GitHub as 0.9.6-rc01, available here:
https://github.com/apache/incubator-brpc/releases/tag/0.9.6-rc02
The SHA-512 checksum is:
cd737f4cc9c69cd15d58fbee0d64f14383ef0dc5727b74e2c1bdcec95fcaa1fad4d8e31fa9341931722552231f5b38aa5acfb5558007a03cc6b77f3c4b20c611
which can be found via:
https://dist.apache.org/repos/dist/dev/incubator/brpc/0.9.6-rc02/apache-brpc-0.9.6.rc02-incubating-src.tar.gz.sha512
The signature can be found via:
https://dist.apache.org/repos/dist/dev/incubator/brpc/0.9.6-rc02/apache-brpc-0.9.6.rc02-incubating-src.tar.gz.asc
KEYS file is available here:
https://dist.apache.org/repos/dist/dev/incubator/brpc/KEYS
[Release Note]
* Health (of a connection) can be checked at rpc-level
* Fix SSL-related compilation issues on Mac
* Support SSL-replacement lib MesaLink
* Support consistent hashing with ketama algo.
* bvar variables can be exported for prometheus services
* String[Multi]Splitter supports '\0' as separator
* Support for bilibili discovery service
* Improved CircuitBreaker
* grpc impl. supports timeout
Please vote on releasing this package as:
Apache brpc(incubating) 0.9.6-rc02
This vote will be open until “Fri Oct 19 2019 00:00:00 GMT+0800 (CST)" and
passes if a majority of at least three +1 Apache brpc IPMC votes are
cast.
[ ] +1 Release this package
[ ] 0 I don't feel strongly about it, but don't object
[ ] -1 Do not release this package because...
Checklist for reference:
[ ]Are release files in correct location?
[ ]Do release files have the word incubating in their name?
[ ] Are the digital signature and hashes correct?
[ ] Does DISCLAIMER file exist?
[ ]Do LICENSE and NOTICE files exists?
[ ] Is the LICENSE and NOTICE text correct?
[ ] Is the NOTICE year correct?
[ ] Un-included software dependencies are not mentioned in LICENSE or NOTICE?
[ ] License information is not mentioned in NOTICE?
Is there any 3rd party code contained inside the release? If so:
[ ] Does the software have a compatible license?
[ ] Are all software licenses mentioned in LICENSE?
[ ] Is the full text of the licenses (or pointers to it) in LICENSE?
Is any of this code Apache licensed? Do they have NOTICE files? If so:
[ ]Have relevant parts of those NOTICE files been added to this NOTICE file?
[ ]Do all source files have ASF headers?
[ ] Do the contents of the release match with what's tagged in version control?
[ ] Are there any unexpected binary files in the release?
[ ] Can you compile from source? Are the instruction clear?
Anyone can participate in testing and voting, not just committers, please
feel free to try out the release candidate and provide your votes.
Thanks
--
Jiashun Zhu
Re: [VOTE] Release Apache brpc(incubating) 0.9.6-rc02
Posted by "Tan,Zhongyi" <ta...@baidu.com>.
Sorry for wrong mail list name，
ECharts guys，please ignore this
Thanks
FW: [VOTE] Release Apache brpc(incubating) 0.9.6-rc02
Posted by tan zhongyi <zh...@gmail.com>.
在 2019/9/3 下午5:49，“tan zhongyi”<zh...@gmail.com> 写入:
Hi， jiashun，
Your task is more complicated，
Please call me if you have any question,
Thanks.
1. Src/brpc/callback.h. original from google/protobuf/stubs/common.h. suggest to add its original copyright/license to the very first of file
https://github.com/protocolbuffers/protobuf/blob/master/src/google/protobuf/stubs/common.h
2. src/bthread/context.cpp
src/bthread/context.h
the same as item 1.
3. src/brpc/details/tcmalloc_extension.cpp please add standard apache header
4. src/butil/linux_magic.h please add standard apache header
5. src/butil/intrusive_ptr.hpp the same as item 1
See http://www.boost.org/libs/smart_ptr/intrusive_ptr.html
6. src/butil/recordio.cc please add standard apache header
7. src/butil/unique_ptr.h the same as item 1.
1. src/butil/third_party/modp_b64/modp_b64_data.h
This file has no header, please find its original source, and add license header accordingly.
9. src/butyl/third_party/rapidjson/internal/*.*
MIT license, tencent copyright, it is safe, leave it
发件人: tan zhongyi <je...@apache.org>
日期: 2019年9月2日 星期一 下午4:12
收件人: JiashunZhu <zh...@gmail.com>, "Tang,Hui(EE)" <ta...@baidu.com>, "dev@brpc.apache.org" <de...@brpc.apache.org>
主题: Re: [VOTE] Release Apache brpc(incubating) 0.9.6-rc02
Hi， guys，
According to apache release policy，
http://www.apache.org/legal/src-headers.html#headers
that all source files that created by brpc author need to add apache header file
and for third-party files which are not created by brpc author need to keep their copyright & license.
So I divide the files into three tasks:
1. Add missing apache header for scripts ( I will do it)
• build_in_travis_ci.sh
• config_brpc.sh
• example/multi_threaded_echo_fns_c++/random_kill.sh
• tools/add_syntax_equal_proto2_to_all.sh
• test/run_tests.sh
2. add missing header for c++ files under test directory and tools ( @Tang,Hui(EE)<ma...@baidu.com>, can you do that?)
test/bthread_sched_yield_unittest.cpp
test/file_watcher_unittest.cpp
test/recordio_unittest.cpp
test/string_splitter_unittest.cpp
tools/print_gcc_version.cc
tools/rpc_press/client.py
3. modified cc files that under src directory (@JiashunZhu<ma...@gmail.com>, can you work on that?)
src/brpc/callback.h
src/bthread/context.cpp
src/bthread/context.h
src/brpc/details/tcmalloc_extension.cpp
src/butil/linux_magic.h
src/butil/intrusive_ptr.hpp
src/butil/recordio.cc
src/butil/third_party/modp_b64/modp_b64_data.h
src/butil/third_party/rapidjson/internal/biginteger.h
src/butil/third_party/rapidjson/internal/diyfp.h
src/butil/third_party/rapidjson/internal/dtoa.h
src/butil/third_party/rapidjson/internal/ieee754.h
src/butil/third_party/rapidjson/internal/itoa.h
src/butil/third_party/rapidjson/internal/meta.h
src/butil/third_party/rapidjson/internal/pow10.h
src/butil/third_party/rapidjson/internal/stack.h
src/butil/third_party/rapidjson/internal/strfunc.h
src/butil/third_party/rapidjson/internal/strtod.h
src/butil/unique_ptr.h
发件人: JiashunZhu <zh...@gmail.com>
日期: 2019年8月30日 星期五 下午1:02
收件人: tan zhongyi <zh...@gmail.com>
抄送: "dev@brpc.apache.org" <de...@brpc.apache.org>
主题: Re: [VOTE] Release Apache brpc(incubating) 0.9.6-rc02
OK. I will build rc3 after all problems are solved.
tan zhongyi <zh...@gmail.com>> 于2019年8月29日周四 下午7:22写道：
Thanks， tangjie，
It seems that we have missed some third-party's file,
We need to check them again.
-1 , vote closed as not Go.
@JiashunZhu, we need to check these files one by one and build rc3 later.
BTW: JB, please cancel your investigation and focus on the next rc3 release , thanks
在 2019/8/29 下午2:02，“Tang,Jie(EE)”<ta...@baidu.com>> 写入:
A list of 30 files without license header, including CPP and shell, was compiled by Rat tool.
1. Rat tool will have false alarms and do some filtering work.
2. Makefile, markdown file, refer to other Apache projects without license, there is no license.
This is files list:
build_in_travis_ci.sh
config_brpc.sh
example/multi_threaded_echo_fns_c++/random_kill.sh
src/brpc/callback.h
src/bthread/context.cpp
src/bthread/context.h
src/brpc/details/tcmalloc_extension.cpp
src/butil/linux_magic.h
src/butil/intrusive_ptr.hpp
src/butil/recordio.cc
src/butil/third_party/modp_b64/modp_b64_data.h
src/butil/third_party/rapidjson/internal/biginteger.h
src/butil/third_party/rapidjson/internal/diyfp.h
src/butil/third_party/rapidjson/internal/dtoa.h
src/butil/third_party/rapidjson/internal/ieee754.h
src/butil/third_party/rapidjson/internal/itoa.h
src/butil/third_party/rapidjson/internal/meta.h
src/butil/third_party/rapidjson/internal/pow10.h
src/butil/third_party/rapidjson/internal/stack.h
src/butil/third_party/rapidjson/internal/strfunc.h
src/butil/third_party/rapidjson/internal/strtod.h
src/butil/unique_ptr.h
test/bthread_sched_yield_unittest.cpp
test/file_watcher_unittest.cpp
test/recordio_unittest.cpp
test/run_tests.sh
test/string_splitter_unittest.cpp
tools/add_syntax_equal_proto2_to_all.sh
tools/print_gcc_version.cc
tools/rpc_press/client.py
在 2019/8/14 下午9:46，“tan zhongyi”<zh...@gmail.com>> 写入:
Hi, guys,
another round of vote begins
I am pleased to be calling this vote for the release of apache brpc(incubating) 0.9.6-rc02.
The source code can be found at:
https://dist.apache.org/repos/dist/dev/incubator/brpc/0.9.6-rc02/apache-brpc-0.9.6.rc02-incubating-src.tar.gz
The release candidate has been tagged in GitHub as 0.9.6-rc01, available here:
https://github.com/apache/incubator-brpc/releases/tag/0.9.6-rc02
The SHA-512 checksum is:
cd737f4cc9c69cd15d58fbee0d64f14383ef0dc5727b74e2c1bdcec95fcaa1fad4d8e31fa9341931722552231f5b38aa5acfb5558007a03cc6b77f3c4b20c611
which can be found via:
https://dist.apache.org/repos/dist/dev/incubator/brpc/0.9.6-rc02/apache-brpc-0.9.6.rc02-incubating-src.tar.gz.sha512
The signature can be found via:
https://dist.apache.org/repos/dist/dev/incubator/brpc/0.9.6-rc02/apache-brpc-0.9.6.rc02-incubating-src.tar.gz.asc
KEYS file is available here:
https://dist.apache.org/repos/dist/dev/incubator/brpc/KEYS
[Release Note]
* Health (of a connection) can be checked at rpc-level
* Fix SSL-related compilation issues on Mac
* Support SSL-replacement lib MesaLink
* Support consistent hashing with ketama algo.
* bvar variables can be exported for prometheus services
* String[Multi]Splitter supports '\0' as separator
* Support for bilibili discovery service
* Improved CircuitBreaker
* grpc impl. supports timeout
Please vote on releasing this package as:
Apache brpc(incubating) 0.9.6-rc02
This vote will be open until “Fri Oct 19 2019 00:00:00 GMT+0800 (CST)" and
passes if a majority of at least three +1 Apache brpc IPMC votes are
cast.
[ ] +1 Release this package
[ ] 0 I don't feel strongly about it, but don't object
[ ] -1 Do not release this package because...
Checklist for reference:
[ ]Are release files in correct location?
[ ]Do release files have the word incubating in their name?
[ ] Are the digital signature and hashes correct?
[ ] Does DISCLAIMER file exist?
[ ]Do LICENSE and NOTICE files exists?
[ ] Is the LICENSE and NOTICE text correct?
[ ] Is the NOTICE year correct?
[ ] Un-included software dependencies are not mentioned in LICENSE or NOTICE?
[ ] License information is not mentioned in NOTICE?
Is there any 3rd party code contained inside the release? If so:
[ ] Does the software have a compatible license?
[ ] Are all software licenses mentioned in LICENSE?
[ ] Is the full text of the licenses (or pointers to it) in LICENSE?
Is any of this code Apache licensed? Do they have NOTICE files? If so:
[ ]Have relevant parts of those NOTICE files been added to this NOTICE file?
[ ]Do all source files have ASF headers?
[ ] Do the contents of the release match with what's tagged in version control?
[ ] Are there any unexpected binary files in the release?
[ ] Can you compile from source? Are the instruction clear?
Anyone can participate in testing and voting, not just committers, please
feel free to try out the release candidate and provide your votes.
Thanks
--
Jiashun Zhu