You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/01/20 18:53:37 UTC

[GitHub] [beam] dandy10 commented on a change in pull request #13756: Allow extension of SdkContainerImageBuilder

dandy10 commented on a change in pull request #13756:
URL: https://github.com/apache/beam/pull/13756#discussion_r561198346



##########
File path: sdks/python/apache_beam/options/pipeline_options.py
##########
@@ -1036,7 +1036,6 @@ def _add_argparse_args(cls, parser):
             'the command line.'))
     parser.add_argument(
         '--prebuild_sdk_container_engine',
-        choices=['local_docker', 'cloud_build'],

Review comment:
       Does that cover what you were thinking of? I think if people are aware of the option and go to the trouble of implementing a subclass they will realise what build key to provide.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org