You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/05/26 18:46:29 UTC

[GitHub] [arrow-rs] alamb opened a new issue, #1755: Implement `concat_elements_dyn` kernel

alamb opened a new issue, #1755:
URL: https://github.com/apache/arrow-rs/issues/1755

   **Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
   The idea is to add kernels to support concatenating arrays element wise, such as `concat_elements_utf8` where arrays like
   
   ```text
   ┌──────┐ ┌──────┐             ┌──────┐
   │ foo  │ │ aaa  │             │fooaaa│
   ├──────┤ ├──────┤  ────────▶  ├──────┤
   │<null>│ │ bbb  │             │<null>│
   ├──────┤ ├──────┤             ├──────┤
   │ baz  │ │ ccc  │             │bazccc│
   └──────┘ └──────┘             └──────┘
   ```
   
   **Describe the solution you'd like**
   I would like a function like:
   
   ```rust
   fn concat_elements_dyn(left: &dyn Array, right: &dyn Array) -> ArrayRef {
   }
   ```
   
   That dispatches on type of arrays:
   1. If the types are different, it will return an error
   2. if the types are `DataType::Utf8` it will invoke `concat_elements_utf8`
   
   It would also be awesome to add support for other data types such as `DataType::LargeUtf8`, `DataType::Binary`, and `DataType::LargeBinary`
   
   
   **Describe alternatives you've considered**
   A clear and concise description of any alternative solutions or features you've considered.
   
   **Additional context**
   See https://github.com/apache/arrow-rs/issues/1747 and the original PR https://github.com/apache/arrow-rs/pull/1720 from @Ismail-Maj


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] tustvold closed issue #1755: Implement `concat_elements_dyn` kernel

Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold closed issue #1755: Implement `concat_elements_dyn` kernel
URL: https://github.com/apache/arrow-rs/issues/1755


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] Weijun-H commented on issue #1755: Implement `concat_elements_dyn` kernel

Posted by "Weijun-H (via GitHub)" <gi...@apache.org>.
Weijun-H commented on issue #1755:
URL: https://github.com/apache/arrow-rs/issues/1755#issuecomment-1444259882

   Hi there, is this feature done? If not, I want to pick it up.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] Ismail-Maj commented on issue #1755: Implement `concat_elements_dyn` kernel

Posted by GitBox <gi...@apache.org>.
Ismail-Maj commented on issue #1755:
URL: https://github.com/apache/arrow-rs/issues/1755#issuecomment-1142223666

   Might as well continue :D Can I get assigned please?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] alamb commented on issue #1755: Implement `concat_elements_dyn` kernel

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on issue #1755:
URL: https://github.com/apache/arrow-rs/issues/1755#issuecomment-1445129533

   Hi @Weijun-H  -- thanks!
   
   I do not think it is done yet
   https://docs.rs/arrow/33.0.0/arrow/compute/kernels/concat_elements/index.html
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] alamb commented on issue #1755: Implement `concat_elements_dyn` kernel

Posted by GitBox <gi...@apache.org>.
alamb commented on issue #1755:
URL: https://github.com/apache/arrow-rs/issues/1755#issuecomment-1142521191

   Done!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org